mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Joseph Salisbury <joseph.salisbury@canonical.com>, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com,
	linux-rt-users@vger.kernel.org
Subject: Re: Issue With real-time patches on 5.15.y
Date: Thu, 5 May 2022 16:35:39 -0700	[thread overview]
Message-ID: <32803e0b-8ff6-ae8d-f9cb-ce2d3fd37229@intel.com> (raw)
In-Reply-To: <bdb23fe5-51ae-8873-a3d7-85f377877c79@canonical.com>

On 5/5/22 16:18, Joseph Salisbury wrote:
> The real-time kernel build failure can be resolved by reverting commit
> b50854eca0e0.  The failure seems to be due to the removal of an include
> of xstate.h from pkru.h and caused spinlock_t to not be defined.  The
> commit would only be reverted for the real-time kernel and not any other
> kernels.  I wanted to see if reverting the commit is the proper
> approach, or if cherry-picking additional commits might be a better
> solution in preparation for additional changes that might be coming in
> the future?
> 
> Any suggestions would be greatly appreciated.

I thought you distro folks were the franenkernel experts. :)

But, seriously...  This isn't rocket science.  Just look at the pkru.h
in your tree and figure out what includes it needs.  If it needs FPU
gunk, include the FPU header.  If you get a compile error for spinlock_t
...  well ...  find the code using spinlock_t and make sure it includes
spinlock.h.


  parent reply	other threads:[~2022-05-05 23:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-05 23:18 Joseph Salisbury
2022-05-05 23:20 ` Joseph Salisbury
2022-05-09 10:14   ` Mike Galbraith
2022-05-10 20:00     ` Joseph Salisbury
2022-05-05 23:35 ` Dave Hansen [this message]
2022-05-06 19:15   ` Joseph Salisbury

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32803e0b-8ff6-ae8d-f9cb-ce2d3fd37229@intel.com \
    --to=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=joseph.salisbury@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®