From: Mukesh Ojha <mojha@codeaurora.org>
To: jotun9935@gmail.com, axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] partitions: fix coding style
Date: Fri, 14 Dec 2018 16:26:01 +0530 [thread overview]
Message-ID: <3282d005-53e1-b5cd-bd14-964467639403@codeaurora.org> (raw)
In-Reply-To: <20181214101958.90690-1-jotun9935@gmail.com>
Please read the guideline as well before sending patch.
you need to maintain patchset version as well, e.g: in which patchset
what is changed on whose comments.
-Mukesh
On 12/14/2018 3:49 PM, jotun9935@gmail.com wrote:
> From: Sungkyung Kim <jotun9935@gmail.com>
>
> Fix coding style of osf.c
>
> Signed-off-by: Sungkyung Kim <jotun9935@gmail.com>
> ---
> block/partitions/osf.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/block/partitions/osf.c b/block/partitions/osf.c
> index 4b873973d6c0..19f8e91979f0 100644
> --- a/block/partitions/osf.c
> +++ b/block/partitions/osf.c
> @@ -22,7 +22,7 @@ int osf_partition(struct parsed_partitions *state)
> unsigned char *data;
> struct disklabel {
> __le32 d_magic;
> - __le16 d_type,d_subtype;
> + __le16 d_type, d_subtype;
> u8 d_typename[16];
> u8 d_packname[16];
> __le32 d_secsize;
> @@ -50,14 +50,14 @@ int osf_partition(struct parsed_partitions *state)
> u8 p_frag;
> __le16 p_cpg;
> } d_partitions[MAX_OSF_PARTITIONS];
> - } * label;
> - struct d_partition * partition;
> + } *label;
> + struct d_partition *partition;
>
> data = read_part_sector(state, 0, §);
> if (!data)
> return -1;
>
> - label = (struct disklabel *) (data+64);
> + label = (struct disklabel *) (data + 64);
> partition = label->d_partitions;
> if (le32_to_cpu(label->d_magic) != DISKLABELMAGIC) {
> put_dev_sector(sect);
> @@ -74,7 +74,7 @@ int osf_partition(struct parsed_partitions *state)
> }
> for (i = 0 ; i < npartitions; i++, partition++) {
> if (slot == state->limit)
> - break;
> + break;
> if (le32_to_cpu(partition->p_size))
> put_partition(state, slot,
> le32_to_cpu(partition->p_offset),
next prev parent reply other threads:[~2018-12-14 10:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 10:19 jotun9935
2018-12-14 10:56 ` Mukesh Ojha [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-12-14 7:04 jotun9935
2018-12-14 8:47 ` Mukesh Ojha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3282d005-53e1-b5cd-bd14-964467639403@codeaurora.org \
--to=mojha@codeaurora.org \
--cc=axboe@kernel.dk \
--cc=jotun9935@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome