From: "Andrew F. Davis" <afd@ti.com>
To: Charles Keepax <ckeepax@opensource.cirrus.com>, <lee.jones@linaro.org>
Cc: <robh+dt@kernel.org>, <mark.rutland@arm.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<patches@opensource.cirrus.com>
Subject: Re: [PATCH 1/3] mfd: wm8998: Remove some unused registers
Date: Fri, 4 Oct 2019 10:47:46 -0400 [thread overview]
Message-ID: <32854b25-d7b8-af85-b5a6-0d37386cee4a@ti.com> (raw)
In-Reply-To: <20191001134617.12093-1-ckeepax@opensource.cirrus.com>
On 10/1/19 9:46 AM, Charles Keepax wrote:
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
>
Why do this? There is no commit message..
Andrew
> Patch is new to the series.
>
> Thanks,
> Charles
>
> drivers/mfd/wm8998-tables.c | 12 ------------
> include/linux/mfd/arizona/registers.h | 7 -------
> 2 files changed, 19 deletions(-)
>
> diff --git a/drivers/mfd/wm8998-tables.c b/drivers/mfd/wm8998-tables.c
> index ebf0eadd2075c..9b34a6d760949 100644
> --- a/drivers/mfd/wm8998-tables.c
> +++ b/drivers/mfd/wm8998-tables.c
> @@ -806,12 +806,6 @@ static const struct reg_default wm8998_reg_default[] = {
> { 0x00000EF3, 0x0000 }, /* R3827 - ISRC 2 CTRL 1 */
> { 0x00000EF4, 0x0001 }, /* R3828 - ISRC 2 CTRL 2 */
> { 0x00000EF5, 0x0000 }, /* R3829 - ISRC 2 CTRL 3 */
> - { 0x00001700, 0x0000 }, /* R5888 - FRF_COEFF_1 */
> - { 0x00001701, 0x0000 }, /* R5889 - FRF_COEFF_2 */
> - { 0x00001702, 0x0000 }, /* R5890 - FRF_COEFF_3 */
> - { 0x00001703, 0x0000 }, /* R5891 - FRF_COEFF_4 */
> - { 0x00001704, 0x0000 }, /* R5892 - DAC_COMP_1 */
> - { 0x00001705, 0x0000 }, /* R5893 - DAC_COMP_2 */
> };
>
> static bool wm8998_readable_register(struct device *dev, unsigned int reg)
> @@ -1492,12 +1486,6 @@ static bool wm8998_readable_register(struct device *dev, unsigned int reg)
> case ARIZONA_ISRC_2_CTRL_1:
> case ARIZONA_ISRC_2_CTRL_2:
> case ARIZONA_ISRC_2_CTRL_3:
> - case ARIZONA_FRF_COEFF_1:
> - case ARIZONA_FRF_COEFF_2:
> - case ARIZONA_FRF_COEFF_3:
> - case ARIZONA_FRF_COEFF_4:
> - case ARIZONA_V2_DAC_COMP_1:
> - case ARIZONA_V2_DAC_COMP_2:
> return true;
> default:
> return false;
> diff --git a/include/linux/mfd/arizona/registers.h b/include/linux/mfd/arizona/registers.h
> index bb1a2530ae279..49e24d1de8d47 100644
> --- a/include/linux/mfd/arizona/registers.h
> +++ b/include/linux/mfd/arizona/registers.h
> @@ -1186,13 +1186,6 @@
> #define ARIZONA_DSP4_SCRATCH_1 0x1441
> #define ARIZONA_DSP4_SCRATCH_2 0x1442
> #define ARIZONA_DSP4_SCRATCH_3 0x1443
> -#define ARIZONA_FRF_COEFF_1 0x1700
> -#define ARIZONA_FRF_COEFF_2 0x1701
> -#define ARIZONA_FRF_COEFF_3 0x1702
> -#define ARIZONA_FRF_COEFF_4 0x1703
> -#define ARIZONA_V2_DAC_COMP_1 0x1704
> -#define ARIZONA_V2_DAC_COMP_2 0x1705
> -
>
> /*
> * Field Definitions.
>
prev parent reply other threads:[~2019-10-04 14:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 13:46 Charles Keepax
2019-10-01 13:46 ` [PATCH v3 2/3] mfd: madera: Update DT binding document to support clock supplies Charles Keepax
2019-10-01 13:46 ` [PATCH v3 3/3] mfd: madera: Add support for requesting the supply clocks Charles Keepax
2019-10-04 14:34 ` Lee Jones
2019-10-04 15:21 ` Charles Keepax
2019-10-04 14:47 ` Andrew F. Davis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32854b25-d7b8-af85-b5a6-0d37386cee4a@ti.com \
--to=afd@ti.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=patches@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®