From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Grant Likely <grant.likely@hpe.com>, Linn Crosetto <linn@hpe.com>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] pci: remove error message when device not present
Date: Thu, 29 Sep 2016 14:34:40 +0200 [thread overview]
Message-ID: <3286868.r1zjOMuMhU@vostro.rjw.lan> (raw)
In-Reply-To: <20160929112843.13552-1-grant.likely@secretlab.ca>
On Thursday, September 29, 2016 12:28:43 PM Grant Likely wrote:
> It's not an error if the IBM ACPI pseudo-device isn't present, it merely
> means the kernel isn't running on that IBM hardware. Get rid of the
> error report so as not to pollute the kernel log with an message
> irrelevant to the vast majority of users.
>
> If someone wants to debug it, they can turn on the pr_debug() message
> which will show progress through the .init function.
>
> Reported-by: Jim Hull <jim.hull@hpe.com>
> Signed-off-by: Grant Likely <grant.likely@hpe.com>
> Cc: Linn Crosetto <linn@hpe.com>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
ACK
> ---
> drivers/pci/hotplug/acpiphp_ibm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/hotplug/acpiphp_ibm.c b/drivers/pci/hotplug/acpiphp_ibm.c
> index f6221d7..ec43510 100644
> --- a/drivers/pci/hotplug/acpiphp_ibm.c
> +++ b/drivers/pci/hotplug/acpiphp_ibm.c
> @@ -439,7 +439,6 @@ static int __init ibm_acpiphp_init(void)
> if (acpi_walk_namespace(ACPI_TYPE_DEVICE, ACPI_ROOT_OBJECT,
> ACPI_UINT32_MAX, ibm_find_acpi_device, NULL,
> &ibm_acpi_handle, NULL) != FOUND_APCI) {
> - pr_err("%s: acpi_walk_namespace failed\n", __func__);
> retval = -ENODEV;
> goto init_return;
> }
>
Thanks,
Rafael
prev parent reply other threads:[~2016-09-29 12:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 11:28 Grant Likely
2016-09-29 12:34 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3286868.r1zjOMuMhU@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=bhelgaas@google.com \
--cc=grant.likely@hpe.com \
--cc=grant.likely@secretlab.ca \
--cc=linn@hpe.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®