Re: [PATCH v7 0/7] x86,fs/resctrl: Pave the way for MPAM counter assignment

["Moger, Babu" <bmoger@amd.com>]

Hi Ben,

The patches look good overall. Just one small note: I was testing v6 and 
noticed that v7 has already been posted. It would be helpful to leave a 
few days between versions unless you’re trying to make the merge window.

Tested-by: Babu Moger <babu.moger@amd.com>
Reviewed-by: Babu Moger <babu.moger@amd.com>

Thanks
Babu

On 5/6/2026 3:28 AM, Ben Horgan wrote:
> Essentially a resend of v6, just adding a missing commit message separator, ---,
> in the first commit. All patches now have Reinette's Reviewed-by tag, thanks!
> 
> Cover letter from v6:
> 
> No functional changes from v5. Just comment and commit message changes based on
> review comments. Changelogs in patches.
> 
> Description from a previous version's cover letter:
> 
> A little bit of preparatory work to get ready for MPAM counter
> assignment. Resctrl gained support last year for counter assignment for AMD
> machines supporting ABMC. Tighten a few things up, that weren't needed for
> AMD, so that the MPAM driver can emulate ABMC and hence support counter
> assignment.
> 
> Based on v7.1-rc2
> 
> v1:
> https://lore.kernel.org/lkml/20260225201905.3568624-1-ben.horgan@arm.com/
> v2:
> https://lore.kernel.org/lkml/20260313174524.3482767-1-ben.horgan@arm.com/
> v3:
> https://lore.kernel.org/lkml/20260319162225.378485-1-ben.horgan@arm.com/
> v4:
> https://lore.kernel.org/lkml/20260326172551.1553871-1-ben.horgan@arm.com/
> v5:
> https://lore.kernel.org/lkml/20260428130422.2287302-1-ben.horgan@arm.com/
> v6:
> https://lore.kernel.org/lkml/20260505155741.3591201-1-ben.horgan@arm.com/
> 
> Ben Horgan (7):
>    fs/resctrl: Tidy up the error path in resctrl_mkdir_event_configs()
>    x86,fs/resctrl: Create 'event_filter' files read only if they're not
>      configurable
>    fs/resctrl: Disallow the software controller when MBM counters are
>      assignable
>    fs/resctrl: Add monitor property 'mbm_cntr_assign_fixed'
>    fs/resctrl: Continue counter allocation after failure
>    fs/resctrl: Document that automatic counter assignment is best effort
>    fs/resctrl: Document tasks file behaviour for task id 0 and idle tasks
> 
>   Documentation/filesystems/resctrl.rst | 22 +++++++++++-----
>   arch/x86/kernel/cpu/resctrl/monitor.c |  1 +
>   fs/resctrl/internal.h                 |  2 ++
>   fs/resctrl/monitor.c                  | 30 ++++++++++++++++------
>   fs/resctrl/rdtgroup.c                 | 36 ++++++++++++++++++---------
>   include/linux/resctrl.h               | 18 ++++++++------
>   6 files changed, 77 insertions(+), 32 deletions(-)
>