From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 145793B530D for ; Tue, 20 Jan 2026 07:56:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768895771; cv=none; b=RoOFZej6+Tg/B/0NALiJQegq1ezQgFK6j9xWrwbuBkUUrkPOyXxOs0LGIkakkYXD0yDbZ5YGNWkTkrqJkF9qrdoX+TzkQZd2JhrW+TIXtdzR6hpuneVjhFwPSRObD63u1HpNKoumgpTAMbe+ekwEpP6qOJLIXUIU6GNEK7qZ35Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768895771; c=relaxed/simple; bh=OGh0veNi//haBVMN+b6cSjciQM0klpprK47DoiMQjDk=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=pTbiIwGlxFLTg40GKjvRBN+n0Yk66Ar0VPRbCuzLUAyRufcauUZYSggsh1HUJAPKZLuUBdV4up5eJ/IMPpiHrN5AYJSpda7HjXD5V89TEPQrOWZR6Tm9+Xs9duB+a6koRrCPN/pDDapjJQwn2J+XLDJmnAJHT9HPsQ+jEkiOMss= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=eOfOLxJq; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=IO2c8FKO; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eOfOLxJq"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="IO2c8FKO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768895769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OGh0veNi//haBVMN+b6cSjciQM0klpprK47DoiMQjDk=; b=eOfOLxJqIvyevOavHOHxj+zToCqGlVqG39IrtmZ7ojwNXcHddZBdonrpDVgp/EocKpCUK0 QCyCo27cNdLeqKSam3YB63cnY+MSfpHalXsfASjvwww5vOciznohJZBLYOOu4/LiOf+yQn TyoQlg/4YOd7yh0hyeAsMhdUT9A5DWg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-592-3ARU_x2UPYKoPGWVH6VR0w-1; Tue, 20 Jan 2026 02:56:07 -0500 X-MC-Unique: 3ARU_x2UPYKoPGWVH6VR0w-1 X-Mimecast-MFC-AGG-ID: 3ARU_x2UPYKoPGWVH6VR0w_1768895766 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-47ee8808ffbso38237275e9.2 for ; Mon, 19 Jan 2026 23:56:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768895766; x=1769500566; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=OGh0veNi//haBVMN+b6cSjciQM0klpprK47DoiMQjDk=; b=IO2c8FKO2lNn2SuVV954h2wm2CkONn1mBK+p4vYA+kHyl/Cir5btE61VDh68e27rB0 0OMh74Pe1VKaJztlPuxrgXjGd+gYgx6bx9mWPO5VsfrdBRy9eJEaD2uJMkQ1sY+4kcCR K/6sfjcvzuP6b582Uy6RVUcXm5XQbn1In0RWc54wqiXPIbx0qvLZAkXudurqcwwr58kO 6H8ND1vp6XGtGJVg/uOOfgDOBv6x7/zhDjgjyXTHYO0DzF76xZky9qJUggb3QD0W2mmR ngqtjG8++J0rjDrdaF3w0mOJxWmy7Cunpp5zV4oeYDEU3zW8cxEvOY2+++B9gv3/y98e ii1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768895766; x=1769500566; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OGh0veNi//haBVMN+b6cSjciQM0klpprK47DoiMQjDk=; b=Jrw31BBUzvHVhqWin04DHQsl9zk6hOruV7PJGdueYNVW6c0YQLSo34Ct7f5mY4yREp hLy6LVzzscQIB5YvFVTVb3Br24JM0OG1tEDlJNMQ9Gmq6bjT9E9KH78kQnUrSNN94EdX V+MHV33Ze1nY8xeTZPGoRIwlZAc32FnTHZTWQZTLRuvvJjkS9H4CAyK69sWBIoEqUwf9 1B18maB9om/d9iVnm8FVpg6mYNtLLcCb02zWm5Tr5F8XWwX0/JXdt1JfPgrhW0sCnq4X i115zNvfeRi/PlTZ6ekzOwEJ+C2JELIXQuP02GOpuwZSGFsVkey9+CpJBVsWijkQl+xc 0X9g== X-Forwarded-Encrypted: i=1; AJvYcCVO0JVCGx4CIJrtX6ydul7eeG3eSGY9PjppMISJPZ0k6KdEDp89wiRncV1STOW/MxokPYvHaCDt/4T0FOY=@vger.kernel.org X-Gm-Message-State: AOJu0YwanQyuKg/71KSt8WMsMJV7MbIVXBPQjmj+jcL6rrYaEg7B7lZF fCfRxw14qpiQaFniO42MqrwlRBzu6nbgXa8Uk/oVa04dE4BzbDE3IZjX13khTh/DZwOAWTV8+BH pQ/JAHJ8F0U52x0OaDKRqDVP91RH5IxOt3H1VPBeWKlMvTSlBtDfIfODcI1VRPhFTew== X-Gm-Gg: AY/fxX5AxwIjBaUTTya02Hxg+XpZl1gU9PrSTp2Xevus9+G9lg/pbBPyl1UAAYuQmJB gp3q4S3h8V6BHSokfaiBuzeaGJIBMwGFZmTO7pFaObhjKuW5CwibsKyScXbrpIbBa8YgsVpazNI i6uxKizUa77tP4jbbyar5vMvALBU7mTmMjFHMz/EuD/aJrNPE+nTTzAuTRr0MtpShJLPuYxD1BH FandqFdaYb7vDRjAZhZpa/spmyEEj5q64DzMgBZK3OIXlqo5/IG9ap7nb15IJeBSckCDxbX51i4 bqodHvODm2Jc422KeDA5GIROAaW+zNTSHe+gGbPvY5soHUbIyaN9xPtzyXXU2M2b+5Lk9+NFxN8 Erz3jzaAVhqE45tVIoS3EWNf0RzKzIGgJXZffTi7ao9pc4HFJJ1AbiLVCH2Dhbfl0MrgpP/YaYk 8Vpu6fB9SU X-Received: by 2002:a05:600c:1387:b0:47a:935f:618e with SMTP id 5b1f17b1804b1-4801e30ba55mr195432775e9.15.1768895766004; Mon, 19 Jan 2026 23:56:06 -0800 (PST) X-Received: by 2002:a05:600c:1387:b0:47a:935f:618e with SMTP id 5b1f17b1804b1-4801e30ba55mr195432535e9.15.1768895765655; Mon, 19 Jan 2026 23:56:05 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (185-132-178-103.hosted-by-worldstream.net. [185.132.178.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4801e879537sm235505055e9.5.2026.01.19.23.56.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 23:56:05 -0800 (PST) Message-ID: <328a77d7b602242763597b45592fbffc20b9c528.camel@redhat.com> Subject: Re: [PATCH 13/26] rv/rvgen: fix DOT file validation logic error From: Gabriele Monaco To: Wander Lairson Costa Cc: Steven Rostedt , Nam Cao , open list , "open list:RUNTIME VERIFICATION (RV)" Date: Tue, 20 Jan 2026 08:56:04 +0100 In-Reply-To: <20260119205601.105821-14-wander@redhat.com> References: <20260119205601.105821-1-wander@redhat.com> <20260119205601.105821-14-wander@redhat.com> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-01-19 at 17:45 -0300, Wander Lairson Costa wrote: > Fix incorrect boolean logic in automata DOT file format validation > that allowed malformed files to pass undetected. The previous > implementation used a logical AND operator where OR was required, > causing the validation to only reject files when both the first > token was not "digraph" AND the second token was not > "state_automaton". This meant a file starting with "digraph" but > having an incorrect second token would incorrectly pass validation. >=20 > The corrected logic properly rejects DOT files where either the > first token is not "digraph" or the second token is not > "state_automaton", ensuring that only properly formatted automaton > definition files are accepted for processing. Without this fix, > invalid DOT files could cause downstream parsing failures or > generate incorrect C code for runtime verification monitors. >=20 > Signed-off-by: Wander Lairson Costa Right, that slipped. Thanks! Reviewed-by: Gabriele Monaco > --- > =C2=A0tools/verification/rvgen/rvgen/automata.py | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tools/verification/rvgen/rvgen/automata.py > b/tools/verification/rvgen/rvgen/automata.py > index 9e1c097ad0e4a..7841a6e70bad2 100644 > --- a/tools/verification/rvgen/rvgen/automata.py > +++ b/tools/verification/rvgen/rvgen/automata.py > @@ -59,7 +59,7 @@ class Automata: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # checking the first lin= e: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 line =3D dot_lines[curso= r].split() > =C2=A0 > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (line[0] !=3D "digraph") a= nd (line[1] !=3D "state_automaton"): > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (line[0] !=3D "digraph") o= r (line[1] !=3D "state_automaton"): > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = raise AutomataError(f"Not a valid .dot format: > {self.__dot_path}") > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 else: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = cursor +=3D 1