From: Markus Elfring <Markus.Elfring@web.de>
To: Stephen Boyd <swboyd@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel-janitors@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Javier Martinez Canillas <javierm@redhat.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Mark Brown <broonie@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Marek Szyprowski <m.szyprowski@samsung.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [v5 2/3] treewide: Remove dev_err() usage after platform_get_irq()
Date: Tue, 30 Jul 2019 12:00:40 +0200 [thread overview]
Message-ID: <328b98da-7e76-145f-0684-a8623efe2cc4@web.de> (raw)
In-Reply-To: <20190730053845.126834-3-swboyd@chromium.org>
> We don't need dev_err() messages when platform_get_irq() fails now that
> platform_get_irq() prints an error message itself when something goes
> wrong. Let's remove these prints with a simple semantic patch.
Will the current patch review result in adjustments for the SmPL code
in the commit description?
> While we're here, remove braces on if statements that only have one
> statement (manually).
Would you like to reduce manual change efforts any further for the shown
source code transformation approach?
Regards,
Markus
next prev parent reply other threads:[~2019-07-30 10:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 5:38 [PATCH v5 0/3] Add error message to platform_get_irq*() Stephen Boyd
2019-07-30 5:38 ` [PATCH v5 1/3] driver core: platform: Add an " Stephen Boyd
2019-07-30 9:44 ` Markus Elfring
2019-07-30 12:30 ` Markus Elfring
2019-07-30 5:38 ` [PATCH v5 2/3] treewide: Remove dev_err() usage after platform_get_irq() Stephen Boyd
2019-07-30 6:49 ` Greg Kroah-Hartman
2019-07-30 15:35 ` Stephen Boyd
2019-07-30 15:51 ` Greg Kroah-Hartman
2019-07-30 17:16 ` Andy Shevchenko
2019-07-30 17:17 ` Andy Shevchenko
2019-07-30 17:21 ` Stephen Boyd
2019-07-30 17:31 ` Andy Shevchenko
2019-07-30 10:00 ` [v5 " Markus Elfring
2019-07-30 10:00 ` Markus Elfring [this message]
2019-07-30 5:38 ` [PATCH v5 3/3] coccinelle: Add script to check for platform_get_irq() excessive prints Stephen Boyd
2019-07-30 8:49 ` Markus Elfring
2019-07-31 14:26 ` [Cocci] [PATCH v5 0/3] Add error message to platform_get_irq*() Wolfram Sang
2019-07-31 14:52 ` Stephen Boyd
2019-08-01 12:25 ` Wolfram Sang
2019-08-08 7:51 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=328b98da-7e76-145f-0684-a8623efe2cc4@web.de \
--to=markus.elfring@web.de \
--cc=a.hajda@samsung.com \
--cc=andy.shevchenko@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=javierm@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robh@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome