From: Valentin Schneider <valentin.schneider@arm.com>
To: Tao Zhou <t1zhou@aliyun.com>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
peterz@infradead.org, vincent.guittot@linaro.org,
Dietmar.Eggemann@arm.com, patrick.bellasi@matbug.net,
qais.yousef@arm.com
Subject: Re: [PATCH 2/3] sched/debug: Bunch up printing formats in common macros
Date: Wed, 26 Feb 2020 10:15:15 +0000 [thread overview]
Message-ID: <32939f53-3916-07d5-c92b-1b57339dfe65@arm.com> (raw)
In-Reply-To: <20200226072121.GA8957@geo.homenetwork>
On 26/02/2020 07:21, Tao Zhou wrote:
>> @@ -963,8 +962,7 @@ void proc_sched_show_task(struct task_struct *p, struct pid_namespace *ns,
>>
>> t0 = cpu_clock(this_cpu);
>> t1 = cpu_clock(this_cpu);
>> - SEQ_printf(m, "%-45s:%21Ld\n",
>> - "clock-delta", (long long)(t1-t0));
>> + __PS("clock-delta", t1-t0);
>
> __PS("clock-delta", (t1-t0));
Oh snap indeed! I think I may just as well shove parentheses in the macro
definitions.
Thanks.
>
> Thanks,
> Tao
>> }
>>
>> sched_show_numa(p, m);
>> --
>> 2.24.0
>>
next prev parent reply other threads:[~2020-02-26 10:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 17:52 [PATCH 0/3] sched/debug: Add uclamp values to procfs Valentin Schneider
2020-02-25 17:52 ` [PATCH 1/3] sched/debug: Remove redundant macro define Valentin Schneider
2020-02-25 17:52 ` [PATCH 2/3] sched/debug: Bunch up printing formats in common macros Valentin Schneider
[not found] ` <20200226072121.GA8957@geo.homenetwork>
2020-02-26 10:15 ` Valentin Schneider [this message]
2020-02-25 17:52 ` [PATCH 3/3] sched/debug: Add task uclamp values to SCHED_DEBUG procfs Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32939f53-3916-07d5-c92b-1b57339dfe65@arm.com \
--to=valentin.schneider@arm.com \
--cc=Dietmar.Eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=patrick.bellasi@matbug.net \
--cc=peterz@infradead.org \
--cc=qais.yousef@arm.com \
--cc=t1zhou@aliyun.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®