From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDECB39479F for ; Mon, 22 Jun 2026 09:33:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782120840; cv=none; b=GJ46Z/18tz+kccoAMR3L2D/bwGpkJNNubWdkjQ3tfg9tWgvvNKZze3KqlkeuMpHLtWIndUenxh4DGroW4udtjTJgXC07Cqcvq78mrNOY/9V+zZJ4k4ExRJYdUC1UdNgFG9gVkhI1Sc9FQfGl8P94PebmKyPNYEwm0GN0iBPJNro= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782120840; c=relaxed/simple; bh=0iGkx5cwZg7ESD/ve9ZgPq335l/pOYBudqpoC72Vk8I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EoZII2vHCqxggakYZTYDoVcpeCx39AQ9hEC97VvAuckRxXA+ml2bnlTBvKXWuymJR1zu+lST2bY+/6xv5yv5Z1AWq2IysnVZh5K4qSc9fvvSU/+wxbTjpCFPwSMij+P4jVCgjW4q5RsNuDf7EjBsrnjbV8nnybz6rCtYXVwQf2Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OtUjeRPR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bn8wHpyM; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OtUjeRPR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bn8wHpyM" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65M59AxC3786541 for ; Mon, 22 Jun 2026 09:33:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bYutGgsfO2AN1trsSrxGaYnXS03MJi3F08rSkRm1PWk=; b=OtUjeRPR8VNetq7W YmycshRN3TdLLy+vKtg7/eoRbgn7FzhbshagB8geZRZcwCHeGoKa2iWqDv0BKl7c 31EdLyTCjMnks4xCf6Y65Z03aN8Oqp6uXOGbdzVJYsN7gNbuH2+i5cLF/+zsF4cl 7XJw7I2dbS0hIz7poR7KxABLtWO1dEWW+qsFi+F3qsxmoMkXPEcZ0LTBxnwCv/Iv A5haOm/a9I6hoqgxTithxBSWknn5Mm6pwIG+dM7FRmzvET5+f5HD940vuwbzi/51 hCZGzqet65hekVjYVlZ1QLHu12gT/6Le9WXMWFmTjCk2lRoHPTOfY82SF80vgEVz lNB0wQ== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ewkmedqbw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 22 Jun 2026 09:33:58 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51968526a68so10894891cf.1 for ; Mon, 22 Jun 2026 02:33:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782120837; x=1782725637; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bYutGgsfO2AN1trsSrxGaYnXS03MJi3F08rSkRm1PWk=; b=bn8wHpyM7ZZeNIKOqMCh5h2vIQnMayGmcPTyCCv02QtCoc6HZdwLyp5QdrJPQK3ueY PweteTzRHUYNBIOZzdyAcMv4jL7FoQ1H/iCFeqlPe1b4FJXYnuRlI+HuDH/526iHdlJM clxsn2VORGM4QKEyr8D/FDDZbL4R5QjJzoMGfzdG377VPMfPiEBZzfuJTs33lpYv6wul hVed696laXm1vlbAt0ne7fqrBQwTP/cairBCpKMXJCF58GsHcIPpetZXAfozsWidH9FW o1HZSbf7ENRNlXW/s5NsfHALpppGP0PkCdw2OtR6UBlJhctnOW0610xFfq8FfkgnQaY+ eRrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782120837; x=1782725637; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bYutGgsfO2AN1trsSrxGaYnXS03MJi3F08rSkRm1PWk=; b=b7qELoVwPG/S8TOYAIscgKDJtEK28+aR8u85lobzjr0FgZwn7mbq8xB8HRjKosk8jH AucQ1hAS7ImVy2qmr+ygIt0v6auFd+uQFFVXvoaNaG5928J2TrcOtoJgfsAXZRcsEifF gBK9293YF23pOEY2wQT74cJ5LorarPc2KzZGTgO5VhvmqUeBKI/8imjXerOletmdeDuy fab1WaxlsPH84FbV4S8PeetUUa+ie2NQVvy8aB7ITwzNNdVIVPr2yroeqTLkmiG0t+Up FVMomiqyNmZ50QB/pIn/1zXxj2X5lLhhGuv8B3UqHDcHp2MJ9dSCDrqrGL1wlyr0dMTp 3JeA== X-Forwarded-Encrypted: i=1; AFNElJ8zx97XhSS8eOjKU5t6lTGRD3XryScS3o9bZ4H4IRGpPXypUZr+6RJxTb7Px5ucRIy58m/KYPlUp24+u3E=@vger.kernel.org X-Gm-Message-State: AOJu0YypLxR4PU1aPSaZBchWqC6Sl4X3D9o8enEu6WxZiwjSwii1PAyy tSA+n86zdZb3HU2tVItoBHDNJGCPI6cRALaSvzP/bMWQ5NjEKkOuaAb44AxxDIARJ29yGjB3Qi8 wQHVJ5pyiIn5dpLfNn56GJuxnXw/l/DEuYgX0QCckUv+BKyMQyoQ21OYBE/5FlyPbTiA= X-Gm-Gg: AfdE7ckoEdMOdRkTMThf5Z4WI6/6npqadYzSgCz1LLDRQhM4nLfW3+Nfj+azLkvj8qf +lHZQ81dDJe4NFVut0V8SvGEFhX4d6+hghyzRO9dN3t9aujq4P84vlbST0zulec4z0u9GeVcSaC 25j6Q4g/+tcLyiDP5Rof4Yn5a75gnbb+yfpF3+Z1ZDr7AG5JKe0LKmSjLxvo/StXJhLibb1c1To P7IRYfiRfpsZC98Dt4L2WCglMXtVUAY0ylTD84iwWJ6L3LxxUfCVHd6NGdqOfsu3Bq7BcnYqYqg +5plD/nP9Gf3GY5PmaUdDymvmDkBC7KtCtSbvmqb+2yjRa7n0pmT+vgVetkpdjPQE9kgUZksaMV VYJeeX+YGOb5Y+LPRnpVcEMjTV/bC3GTPrmM= X-Received: by 2002:a05:620a:27d5:b0:90d:11b2:80f3 with SMTP id af79cd13be357-9208d5f227fmr1213620785a.7.1782120837084; Mon, 22 Jun 2026 02:33:57 -0700 (PDT) X-Received: by 2002:a05:620a:27d5:b0:90d:11b2:80f3 with SMTP id af79cd13be357-9208d5f227fmr1213618385a.7.1782120836583; Mon, 22 Jun 2026 02:33:56 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c0c610e48ddsm333515466b.50.2026.06.22.02.33.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jun 2026 02:33:55 -0700 (PDT) Message-ID: <32948426-7148-424e-91be-0a313aa8e0d3@oss.qualcomm.com> Date: Mon, 22 Jun 2026 11:33:53 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] arm64: dts: qcom: Add HP EliteBook X G2q 14 AI To: Jason Pettit , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Akhil P Oommen , Mahadevan P , Sibi Sankar , Jingyi Wang , Ananthu C V References: <20260620-glymur-send-v1-0-fc4a2cfd107c@oss.qualcomm.com> <20260620-glymur-send-v1-2-fc4a2cfd107c@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260620-glymur-send-v1-2-fc4a2cfd107c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIyMDA5NCBTYWx0ZWRfX2IvPdp4rmKzJ qAb2/WbYY0YXLkKhBsKGjqC8c8v1IgJi7s0BJDdhyqyfr/OWW+LHlIUvLAYS1pltLPOONBi0oK1 KNwNuADP4EA10k6GDQ4QQ2+pbw4s0acfCS2q6QuSL44pmAjgn2X/kE8e++NRt5YtD700aQxFtXm ETlb6HU7QonGJeIO15q26WEwthBwWyqEN1tefkv2DxYJwqOMIyncunWokLWNkkdI9HFeBulQawj EfAEzeZ8TyEoxQv67JIQOmMjOvmvnmM6d927sWz7RiTzOQiUvgNfqji8By61M5QdAdi4VSnDhhy /Tp1CC/b/VP6d0xQ6iL1qjV0OFoEVHcfEFEvkDOfqhSPxVZvNlgRh4TTVaVcAfzZrwpJJUncO45 xPGu+8qhrMdy9V9BaNjVN5i7Ge/M8hhXqZEL7mbi6+rEDpLtARZRCnAGRjop8C7BC4jKG58Ht5o TY9Z0wrSAy8XGnUFc9g== X-Authority-Analysis: v=2.4 cv=MtFiLWae c=1 sm=1 tr=0 ts=6a390186 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=cH6R9-kdAAAA:8 a=2HuRI5RJ3cZe6tb9nYkA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: EKvHCTWfdrfmE2anMYR894Exr5UtiFHv X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIyMDA5NCBTYWx0ZWRfXwDGbfoxUrrlH ufXWFdW9DvBldk30WVJ5OQQyPv6F0+2HbsXHBHCFk9u0baZ8QoCspa/Wvnz8oC0BLDc5Q0zOqGt yk5G/n2PaBzzdamI5Z5dodzutgoeT7s= X-Proofpoint-ORIG-GUID: EKvHCTWfdrfmE2anMYR894Exr5UtiFHv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-22_01,2026-06-18_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 clxscore=1015 phishscore=0 adultscore=0 spamscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606220094 On 6/21/26 6:50 AM, Jason Pettit wrote: > Add board support for the HP EliteBook X G2q 14" Next Gen AI PC > (product SKU C4JG0AV, board 8E91), a Snapdragon X2 Elite (Glymur) > laptop, using the "hp,elitebook-x-g2q" / "qcom,glymur" compatible. > > Enabled by this device tree: > > - internal eDP panel (samsung,atna33xc20) > - 2x USB Type-C with DisplayPort alt-mode and USB > - chassis HDMI output > - chassis USB-A host port (usb_mp multiport controller) > - internal eUSB2 host with the Elan fingerprint reader > - NVMe SSD on PCIe5 > - Wi-Fi and Bluetooth > - HID-over-I2C keyboard, touchpad, touchscreen; lid switch > - Adreno GPU and GMU (Freedreno GL on Mesa) > - audio playback and capture [...] > + /* Left side display-adjacent port */ > + connector@0 { > + compatible = "usb-c-connector"; > + reg = <0>; > + power-role = "dual"; > + data-role = "dual"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + pmic_glink_hs_in: endpoint { > + remote-endpoint = <&usb_0_dwc3_hs>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + pmic_glink_ss_in: endpoint { > + remote-endpoint = <&usb_0_qmpphy_out>; > + }; > + }; > + }; > + }; > + > + /* Left side user-adjacent port */ "left/right side port?" https://support.hp.com/pl-pl/document/ish_14499364-14499440-16 [...] > +&apps_rsc { > + regulators-0 { > + compatible = "qcom,pmh0101-rpmh-regulators"; > + qcom,pmic-id = "B_E0"; > + > + vreg_l1b_e0_1p8: ldo1 { I find these voltage suffixes not very useful (although you're free to keep them if you prefer) [...] > +&i2c0 { > + clock-frequency = <400000>; > + > + status = "okay"; > + > + keyboard@3a { > + compatible = "hid-over-i2c"; > + reg = <0x3a>; > + > + hid-descr-addr = <0x1>; > + interrupts-extended = <&tlmm 67 IRQ_TYPE_LEVEL_LOW>; > + > + pinctrl-0 = <&kybd_default>; > + pinctrl-names = "default"; > + > + wakeup-source; > + }; > + > + touchpad@2c { > + compatible = "hid-over-i2c"; > + reg = <0x2c>; Let's sort these nodes by address (i.e. touchpad@2c < keyboard@3a) Konrad