From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B99FCCA479 for ; Wed, 13 Jul 2022 21:25:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237487AbiGMVZA (ORCPT ); Wed, 13 Jul 2022 17:25:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237463AbiGMVY6 (ORCPT ); Wed, 13 Jul 2022 17:24:58 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 908EB1F2C2 for ; Wed, 13 Jul 2022 14:24:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657747496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2Prw975jaglYxtkVp+vq83GSZySiqpzDYEyN9m98BO8=; b=fhcC2oZ460W5HfCrwAP1fN17gKQgFX9JnsUxPCN6j2Clqn7br52FqW6s0ZIuD44IJkgvvm uT03/PHHjfuGWwYNu0CsBLR/fe4FglSi3LZahqJyuzK+anmNlLyvxgykRqdzF/mXEtrlM5 TUj6E5zNAeS1ErumZAuFBIqGRHaUcBY= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-512-XW3U59M7NYicpZxsnwppqA-1; Wed, 13 Jul 2022 17:24:55 -0400 X-MC-Unique: XW3U59M7NYicpZxsnwppqA-1 Received: by mail-ed1-f69.google.com with SMTP id m10-20020a056402510a00b0043a93d807ffso9155772edd.12 for ; Wed, 13 Jul 2022 14:24:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=2Prw975jaglYxtkVp+vq83GSZySiqpzDYEyN9m98BO8=; b=KdCkYC6mhcZlw40P1tSViCag3lNPmMcSHnI5bSKRRF+S/U2dGLkAh9bsQo9R5zKGYd WbrPVkE4fgWqb96CLvOdoge7xsn12puKSq8vnj4CYiTry7wRbopB0UcJHhjHqc4l0T+K 9FVrd4jqSqPsyPnfYZZPxiTw1QpXZbT4xlsMQAiKln9qTl1Xcy5zSrA2oK/kG8BUO9qU UxojJcRC/JkoXiMdjjs7Ajm4Xrh/gJXBIti19+YUpFFMPihJXv5jxNZzlWJzZM/z51Zx 9HJC4LDteyopVqYJAH1y2YF0FRohVTGULlTan6dIadg3e//BkR3ksaKt3sBE6WNIgXH6 BmTw== X-Gm-Message-State: AJIora9VTJmlY8WSu5lH2K3y1e3cwgemtch+yr3qW0rl4ZagfFI9UtKu C/8pzQHtLwxP/7fwyFuy/e9yfhrANTML/2cTN/wAX9KxNRtdtfQzIFtgAR/Rlj1WB3k6QpPZ+rB j0IM/JM/v1haKt+rR6CqHw40s X-Received: by 2002:a17:907:6e89:b0:72b:68d6:c9d6 with SMTP id sh9-20020a1709076e8900b0072b68d6c9d6mr5424565ejc.711.1657747494244; Wed, 13 Jul 2022 14:24:54 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tKBz+IWpbjn95o3r0w4RFo76+LtvJZNuG6ihRK7LxgdjesQrErdjjV4j3Jq6uvWdh4hx78DQ== X-Received: by 2002:a17:907:6e89:b0:72b:68d6:c9d6 with SMTP id sh9-20020a1709076e8900b0072b68d6c9d6mr5424560ejc.711.1657747494059; Wed, 13 Jul 2022 14:24:54 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id ky6-20020a170907778600b0072b11cb485asm5355840ejc.208.2022.07.13.14.24.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jul 2022 14:24:53 -0700 (PDT) Message-ID: <3295df49-1ef0-7726-5cfa-462bac1ccf12@redhat.com> Date: Wed, 13 Jul 2022 23:24:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] pinctrl: Don't allow PINCTRL_AMD to be a module Content-Language: en-US To: Mario Limonciello , Linus Walleij Cc: Basavaraj.Natikar@amd.com, madcatx@atlas.cz, jwrdegoede@fedoraproject.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220713175950.964-1-mario.limonciello@amd.com> From: Hans de Goede In-Reply-To: <20220713175950.964-1-mario.limonciello@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 7/13/22 19:59, Mario Limonciello wrote: > It was observed that by allowing pinctrl_amd to be loaded > later in the boot process that interrupts sent to the GPIO > controller early in the boot are not serviced. The kernel treats > these as a spurious IRQ and disables the IRQ. > > This problem was exacerbated because it happened on a system with > an encrypted partition so the kernel object was not accesssible for > an extended period of time while waiting for a passphrase. > > To avoid this situation from occurring, stop allowing pinctrl-amd > from being built as a module and instead require it to be built-in > or disabled. > > Reported-by: madcatx@atlas.cz > Suggested-by: jwrdegoede@fedoraproject.org Note I generally use: "Hans de Goede " for all things kernel related. This looks good to me. Fedora is already building in amd-pinctrl which AFAIK is done because of similar issues to the reason given in the commit message: Acked-by: Hans de Goede Regards, Hans > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216230 > Signed-off-by: Mario Limonciello > --- > drivers/pinctrl/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index f52960d2dfbe..bff144c97e66 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -32,7 +32,7 @@ config DEBUG_PINCTRL > Say Y here to add some extra checks and diagnostics to PINCTRL calls. > > config PINCTRL_AMD > - tristate "AMD GPIO pin control" > + bool "AMD GPIO pin control" > depends on HAS_IOMEM > depends on ACPI || COMPILE_TEST > select GPIOLIB