From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67E95C433EF for ; Mon, 4 Apr 2022 12:37:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346485AbiDDMi5 (ORCPT ); Mon, 4 Apr 2022 08:38:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239289AbiDDMi5 (ORCPT ); Mon, 4 Apr 2022 08:38:57 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F4DF275C0; Mon, 4 Apr 2022 05:37:00 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 2DBFA1F44659 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1649075818; bh=XbLfwMKXJkz6MxHKBidnhRWo+AyuXXqSQNzQrjCWxQE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=OxtjPaso8uKDX+NcM3s+he+mbywxsV8V4QNBBSrU+y0eaQF07rfRdtzEoBBwUHQR/ hwcrdSDvcZZxLicA5/ywh+baAjGkhoIJqS7fbG1ZEqB9OH5V0jSBzP5oLWjFPWRacP bQ3sQY8eitB+hP7BgRvCkl8WNWhCC4dMm7xHBWmsqVpqHY4Er4+o2gxI5i1HcXZ8Hi umO5qQrXWtvbQmroc6dV7rJDNvnS6IZR6vbmXdJ1G7wDlMehCiBFX0IDERiI9Vg/+j UU+5ndHU7p6yDhvqXyNScGyKiJnVfVHnWyQ1ofWJvx8IN9EyJUgSraMuVjpvUmR7iW 5AHqsGzY8IICA== Message-ID: <329bed03-770d-106c-29b4-eb1d6037bf65@collabora.com> Date: Mon, 4 Apr 2022 14:36:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 1/1] arm64: dts: mt8192: Add mmc device nodes Content-Language: en-US To: Allen-KH Cheng , Matthias Brugger , Rob Herring Cc: Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Chen-Yu Tsai , Ryder Lee , Hui Liu References: <20220401053052.2160-1-allen-kh.cheng@mediatek.com> <20220401053052.2160-2-allen-kh.cheng@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220401053052.2160-2-allen-kh.cheng@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 01/04/22 07:30, Allen-KH Cheng ha scritto: > Add mmc nodes for mt8192 SoC. > > Signed-off-by: Allen-KH Cheng > --- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 33 ++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > index a6da7b04b9d4..23eb92057cb9 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > @@ -989,6 +989,39 @@ > compatible = "mediatek,mt8192-msdc"; > reg = <0 0x11f60000 0 0x1000>; > #clock-cells = <1>; > + status = "disabled"; > + }; > + Hello! Please explain the reason (in the commit message) why you're disabling the mediatek,mt8192-msdc node, which was enabled before this change. Also, introducing the mtk-sd controller at the same address as the mt8192-msdc clock controller will produce a warning... Thanks, Angelo