From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756893AbcG0QuL (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 Jul 2016 12:50:11 -0400
Received: from mail-pa0-f65.google.com ([209.85.220.65]:33009 "EHLO
	mail-pa0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752446AbcG0QuJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 Jul 2016 12:50:09 -0400
Subject: Re: [PATCH] perf sched: fix wrong conversion of task state
To: =?UTF-8?B?6Zai5bGx5Y+L6LydIC8gU0VLSVlBTUHvvIxUT01PS0k=?= 
	<tomoki.sekiyama.qu@hitachi.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <1469624093-16601-1-git-send-email-tomoki.sekiyama.qu@hitachi.com>
 <63263328-bde5-8cc1-e98b-08448fc163ea@gmail.com>
 <17B1347950C8C843BCB8CE95F55D63BAB5241488@GSjpTKYDCembx32.service.hitachi.net>
Cc: "ltc-kernel@rdgml.intra.hitachi.co.jp" 
	<ltc-kernel@rdgml.intra.hitachi.co.jp>,
        =?UTF-8?B?5qOu6LC355yf5a+/576OIC8gTU9SSVRBTknvvIxNQVNVTUk=?= 
	<masumi.moritani.ju@hitachi.com>,
        Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Masami Hiramatsu <mhiramat@kernel.org>
From: David Ahern <dsahern@gmail.com>
Message-ID: <329ca7da-d6ca-2067-0789-63d75f345a90@gmail.com>
Date: Wed, 27 Jul 2016 10:50:06 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0)
 Gecko/20100101 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <17B1347950C8C843BCB8CE95F55D63BAB5241488@GSjpTKYDCembx32.service.hitachi.net>
Content-Type: text/plain; charset=iso-2022-jp; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/27/16 9:58 AM, 関山友輝 / SEKIYAMA，TOMOKI wrote:
>>> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
>>> index 0dfe8df..eb2f7f4 100644
>>> --- a/tools/perf/builtin-sched.c
>>> +++ b/tools/perf/builtin-sched.c
>>> @@ -71,6 +71,7 @@ struct sched_atom {
>>>  };
>>>
>>>  #define TASK_STATE_TO_CHAR_STR "RSDTtZXxKWP"
>>> +#define TASK_STATE_MASK 0x7ff
>>
>> The mask should not be needed and looking at top of tree there are 2 new
>> states (N and n) that need to be added.
>
> I couldn't find the state for 'n'. Where can I find it?

Check Linus' tree -- top of tree; commit 7dc603c9028ea.


> I have rechecked the code and found that __trace_sched_switch_state() uses
> TASK_STATE_MAX for preempted tasks.

since TASK_STATE_MAX is kernel version dependent perf should not rely on it.

> I will add 'N', and '+' (instead of "R+" ftrace shows) for preempted tasks.
> (Also add_sched_out_event should set THREAD_WAIT_CPU for preempted tasks.)
>