From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753036AbbJNJrL (ORCPT ); Wed, 14 Oct 2015 05:47:11 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:35887 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751980AbbJNJrI (ORCPT ); Wed, 14 Oct 2015 05:47:08 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.0 \(3094\)) Subject: Re: [RFC][PATCH] spi: Setup the master controller driver before setting the chipselect From: "Ivan T. Ivanov" In-Reply-To: <1444683671-15570-2-git-send-email-fcooper@ti.com> Date: Wed, 14 Oct 2015 12:47:04 +0300 Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, broonie@kernel.org, nsekhar@ti.com, ssantosh@kernel.org, "Ivan T. Ivanov" , m-karicheri2@ti.com Content-Transfer-Encoding: 7bit Message-Id: <32A34513-E312-40FD-9390-B080A85822B7@gmail.com> References: <1444683671-15570-1-git-send-email-fcooper@ti.com> <1444683671-15570-2-git-send-email-fcooper@ti.com> To: Franklin S Cooper Jr , Andy Shevchenko X-Mailer: Apple Mail (2.3094) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Adding Andy. > On Oct 13, 2015, at 12:01 AM, Franklin S Cooper Jr wrote: > > Some devices depend on the master controller driver setup function being > called before calling any chipselect functions. > > Insure that this is done otherwise uninitialized structures may be > accessed causing a kernel panic. > > Signed-off-by: Franklin S Cooper Jr > --- > drivers/spi/spi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c > index 38006cc..9374d82 100644 > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -2053,11 +2053,11 @@ int spi_setup(struct spi_device *spi) > if (!spi->max_speed_hz) > spi->max_speed_hz = spi->master->max_speed_hz; > > - spi_set_cs(spi, false); > - > if (spi->master->setup) > status = spi->master->setup(spi); > > + spi_set_cs(spi, false); > + > dev_dbg(&spi->dev, "setup mode %d, %s%s%s%s%u bits/w, %u Hz max --> %d\n", > (int) (spi->mode & (SPI_CPOL | SPI_CPHA)), > (spi->mode & SPI_CS_HIGH) ? "cs_high, " : "", > -- > 2.6.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-spi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html