From: Jakob Koschel <jakobkoschel@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mike Rapoport <rppt@kernel.org>,
David Hildenbrand <david@redhat.com>,
Oscar Salvador <osalvador@suse.de>,
LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
Cristiano Giuffrida <c.giuffrida@vu.nl>,
"Bos, H.J." <h.j.bos@vu.nl>
Subject: Re: [PATCH] fs/proc/kcore.c: remove check of list iterator against head past the loop body
Date: Tue, 5 Apr 2022 10:48:30 +0200 [thread overview]
Message-ID: <32C4FBEE-D56B-46AA-AB95-1A17B5CC0A87@gmail.com> (raw)
In-Reply-To: <20220404155516.a5fb4c23ee017a7212e4b22c@linux-foundation.org>
> On 5. Apr 2022, at 00:55, Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Fri, 1 Apr 2022 09:19:57 +0200 Jakob Koschel <jakobkoschel@gmail.com> wrote:
>
>>> Speaking of limiting scope...
>>
>> Fair point :-)
>>
>> I see you have applied this already to the -mm tree. Shall I still move the iterator?
>> The hope is to remove the 'iter' variable altogether when there are no uses after
>> the loop anymore.
>
> I don't really understand the question.
Basically I was asking if I should send a v2 with the change you suggested.
>
> My plan is to merge your patch with my fixlet immediately prior to
> sending upstream.
ok, great. Even better, so ignore my question.
Thanks,
Jakob
prev parent reply other threads:[~2022-04-05 12:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 22:37 Jakob Koschel
2022-03-31 23:48 ` Andrew Morton
2022-04-01 7:19 ` Jakob Koschel
2022-04-04 22:55 ` Andrew Morton
2022-04-05 8:48 ` Jakob Koschel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32C4FBEE-D56B-46AA-AB95-1A17B5CC0A87@gmail.com \
--to=jakobkoschel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bjohannesmeyer@gmail.com \
--cc=c.giuffrida@vu.nl \
--cc=david@redhat.com \
--cc=h.j.bos@vu.nl \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osalvador@suse.de \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®