From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C74AC3C81A9 for ; Mon, 13 Jul 2026 09:53:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783936422; cv=none; b=hLljLarTASs+lYIBQ5nPi/xu1XA0LDfsoc67tDhGcRRwd0l7qq+MI2/K9JStiZ1y5ohlozpvrfis3v01N+a/8uKcClBicTpUh/HnqlS9Cf1i5NuqcZbDcjVq1p/pf3SwXR7Uf00grsSIizmuX1eXlQV3X4mlws3IUyYPxaEIFPQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783936422; c=relaxed/simple; bh=kngE0lL648nAyvUh0+iYcyckbgYing28fV2SNdT9oOc=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=r1CEpHxPMCjSdTekeVIH57p5+NXYzSe3jnKy9VR+uSqx/JWcDW+1kiJ+l8IXWLaTem8sTNehid5eLflayHDqZt+eaznlDni51EmsORbbleIt3RPqCEoI0ULYsazGvwMw/nXYsEYw9tnDR7cnaGJmhg5LWAD6Xg/D6Q6T7+pVODs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bRDh3Tbj; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bRDh3Tbj" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-8486672f03cso2535735b3a.0 for ; Mon, 13 Jul 2026 02:53:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783936420; x=1784541220; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:message-id :references:in-reply-to:user-agent:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=dGOSO8sGjHKjdBRL+JsTb/fGsqegAWj+oEAzRJ22a0A=; b=bRDh3TbjdmqLmkE34ZL+StoXHPpZ4P09SBDz13RgAgAIPKE4M2bnZixA/75sF1+lMG 5ikFGilN1mUKBLGzrrZE/SqvLuTtCKZ+HadiH1TrwhSbASwEejplo0lZRKXzPeRfvzb5 n0FrakUCMGom0TIetoCTxHJ95whqpBxFJOehLfNGLdFJ13LsqCkjMdaqtkZsLX+/h+5M cDOcVvYu5OzhEuST4v/k2GmLLJyv6+X0VbCIKiSNcE0Jz+1fyyK9maP9qBFWdMon0J7y vBkCjrR9W3lL3PX1ItRiyrmkuG2u23cON3KGnRSyz/yDYdqVdRPfAwDjQcCmcn5jfPqL WNXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783936420; x=1784541220; h=content-transfer-encoding:content-type:mime-version:message-id :references:in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=dGOSO8sGjHKjdBRL+JsTb/fGsqegAWj+oEAzRJ22a0A=; b=m5/uj+mHo3TVkJDN+MkPwEJVKpjh3FpYDEBbYctD+u5oZZnO13wLv238SNBOKU03ab vSQ/npkoelhIlt0cB4oTh4oCZIWS9cgtxRo92epKC4BMkbmBBhh3ybr/MjDIz7D16O8y SP7Sxd9ohbNVYmS2hrwuM6oLqIxNIF/tzyeFLZAsMHzQ9CfixaXl8LYUnxf6tNfVTWBe woVMf/s0Z79zLpkjWQV8sEkbJyc0stbumQ1Dl/ATPV0yPe+CgrvPOv8T9ks/tLrmFORu AS9Ur5tKt1RPJJliGIyKD8i0E6ID6S3zdAv7AOvSWEJa2k+AFRKbYCRJrHFKLGGSRR78 4OTA== X-Forwarded-Encrypted: i=1; AHgh+Rqll/v+TlMqKc1vC7dPkCn9o60aFYyGTeNn1EEO/0DlQKi4/Sl9XBezfImUxDUdvXqtjWtg9R5XAWQXcrE=@vger.kernel.org X-Gm-Message-State: AOJu0YzuHABv00XUusxOU0crw8TW5lIkCbN+YowgsOZiTMfKVt86qKRW QZeZTgeH3Qq60yRlU33QDjoILefterTia6Ne6dkRyhb5j1rusispM6Hc X-Gm-Gg: AfdE7clLsTjo6uCRtdCdVRvFPef2FqibkqTxSbZ8QPDYoMcnrtkPQIaPah9wxjgeA8I YOvbZL8T5eC0WYofN2a1SMIwAqO93AH5wl9G2r3lsJub3ePbCK6qYGSLdkJKgoAWwvdbrgAQb5p piCBN3pV6+OllAYLQGFeWk8MLYE7UQHjve4rkQbFwJ/jOfoZPz0aCnbcvIds+3SvwAqcZxuOflL RZen5uDPhtarSKuj6Gw7qRvkCuWXIGSHB7CtrmCgZwe8l8vhYwVnt2dOXaho+i+rEa5ymkbt/Q/ kMAH7n4yGqbRh/8V9fPF/s9MWPsg+sLug0ZiPyIq0l2w3Gn/1Rfb9OxuX1x0IDQPWZnuWoTBn+4 rNmZT+OpfKE1AWiCs9knBfkfh2eW6ltNEjgvrjvmAvh1CK1MC+k2NDTJNnoj+lAB0zIG/puD4Cq KLCLBgOEd3o6lr+jHamSrP5ty88w154BkkOfbwZRL+UcQ7oaVfMy/5XeUACCHKJuuJ/tuyxhtl X-Received: by 2002:a05:6a00:f08:b0:848:4859:a45 with SMTP id d2e1a72fcca58-848895dc4b9mr7927348b3a.2.1783936419975; Mon, 13 Jul 2026 02:53:39 -0700 (PDT) Received: from ehlo.thunderbird.net (221x252x203x146.ap221.ftth.ucom.ne.jp. [221.252.203.146]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84870d76ce7sm4796626b3a.55.2026.07.13.02.53.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2026 02:53:39 -0700 (PDT) Date: Mon, 13 Jul 2026 18:53:36 +0900 From: "Derek J. Clark" To: Sean Rhodes , tzungbi@kernel.org CC: hansg@kernel.org, ilpo.jarvinen@linux.intel.com, corentin.chary@gmail.com, luke@ljones.dev, denis.benato@linux.dev, prasanth.ksr@dell.com, jorge.lopez2@hp.com, mpearson-lenovo@squebb.ca, josh@joshuagrisham.com, briannorris@chromium.org, jwerner@chromium.org, tzimmermann@suse.de, javierm@redhat.com, kees@kernel.org, u.kleine-koenig@baylibre.com, mst@redhat.com, chenhuacai@kernel.org, wenst@chromium.org, florian.fainelli@broadcom.com, titouan.ameline@gmail.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Dell.Client.Kernel@dell.com, chrome-platform@lists.linux.dev Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v6_0/3=5D_firmware=3A_Add_cor?= =?US-ASCII?Q?eboot_CFR_firmware_attributes_driver?= User-Agent: Thunderbird for Android In-Reply-To: <20260713081317.2954586-1-sean@starlabs.systems> References: <20260713054526.2902319-1-sean@starlabs.systems> <20260713081317.2954586-1-sean@starlabs.systems> Message-ID: <32F6BAAE-9BC8-42BA-9F1A-51AB3EADDBE7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On July 13, 2026 5:13:14 PM GMT+09:00, Sean Rhodes wrote: >Move the firmware attributes class helper out of platform/x86, rename >the coreboot-table firmware driver directory from google to coreboot, and >add a coreboot CFR firmware attributes driver=2E > >Changes in v6: >- Move firmware_attributes=2Eh into the sorted Linux include block in eac= h > converted platform/x86 driver=2E >- Add Derek's Reviewed-by to patch 1=2E > Hi Sean, Generally you will want to give a bit more time between revisions to allow= people to review=2E 1-2 days during the work week is usually the acceptabl= e minimum time between versions=2E Sending too frequently can cause people = to review older patches without noticing the same issue was already identif= ied/fixed later and nobody wants to read the same patch 4 times in a row on= a Monday=2E Cheers, - Derek >Sean Rhodes (3): > firmware: Move firmware attributes class helper > firmware: Rename google firmware directory to coreboot > firmware: coreboot: Add CFR firmware attributes driver > > MAINTAINERS | 18 +- > drivers/firmware/Kconfig | 5 +- > drivers/firmware/Makefile | 3 +- > drivers/firmware/{google =3D> coreboot}/Kconfig | 19 +- > =2E=2E=2E/firmware/{google =3D> coreboot}/Makefile | 1 + > drivers/firmware/{google =3D> coreboot}/cbmem=2Ec | 0 > drivers/firmware/coreboot/coreboot-cfr=2Ec | 1065 +++++++++++++++++ > =2E=2E=2E/{google =3D> coreboot}/coreboot_table=2Ec | 0 > =2E=2E=2E/{google =3D> coreboot}/coreboot_table=2Eh | 0 > =2E=2E=2E/framebuffer-coreboot=2Ec | 0 > drivers/firmware/{google =3D> coreboot}/gsmi=2Ec | 0 > =2E=2E=2E/memconsole-coreboot=2Ec | 0 > =2E=2E=2E/memconsole-x86-legacy=2Ec | 0 > =2E=2E=2E/{google =3D> coreboot}/memconsole=2Ec | 0 > =2E=2E=2E/{google =3D> coreboot}/memconsole=2Eh | 6 +- > drivers/firmware/{google =3D> coreboot}/vpd=2Ec | 0 > =2E=2E=2E/{google =3D> coreboot}/vpd_decode=2Ec | 0 > =2E=2E=2E/{google =3D> coreboot}/vpd_decode=2Eh | 0 > =2E=2E=2E/firmware_attributes_class=2Ec | 2 +- > drivers/platform/x86/Kconfig | 3 - > drivers/platform/x86/Makefile | 2 - > drivers/platform/x86/asus-armoury=2Ec | 2 +- > =2E=2E=2E/x86/dell/dell-wmi-sysman/sysman=2Ec | 9 +- > drivers/platform/x86/hp/hp-bioscfg/bioscfg=2Ec | 9 +- > drivers/platform/x86/lenovo/think-lmi=2Ec | 5 +- > drivers/platform/x86/lenovo/wmi-other=2Ec | 2 +- > drivers/platform/x86/samsung-galaxybook=2Ec | 3 +- > =2E=2E=2E/linux/firmware_attributes=2Eh | 6 +- > 28 files changed, 1128 insertions(+), 32 deletions(-) > rename drivers/firmware/{google =3D> coreboot}/Kconfig (83%) > rename drivers/firmware/{google =3D> coreboot}/Makefile (92%) > rename drivers/firmware/{google =3D> coreboot}/cbmem=2Ec (100%) > create mode 100644 drivers/firmware/coreboot/coreboot-cfr=2Ec > rename drivers/firmware/{google =3D> coreboot}/coreboot_table=2Ec (100%) > rename drivers/firmware/{google =3D> coreboot}/coreboot_table=2Eh (100%) > rename drivers/firmware/{google =3D> coreboot}/framebuffer-coreboot=2Ec = (100%) > rename drivers/firmware/{google =3D> coreboot}/gsmi=2Ec (100%) > rename drivers/firmware/{google =3D> coreboot}/memconsole-coreboot=2Ec (= 100%) > rename drivers/firmware/{google =3D> coreboot}/memconsole-x86-legacy=2Ec= (100%) > rename drivers/firmware/{google =3D> coreboot}/memconsole=2Ec (100%) > rename drivers/firmware/{google =3D> coreboot}/memconsole=2Eh (82%) > rename drivers/firmware/{google =3D> coreboot}/vpd=2Ec (100%) > rename drivers/firmware/{google =3D> coreboot}/vpd_decode=2Ec (100%) > rename drivers/firmware/{google =3D> coreboot}/vpd_decode=2Eh (100%) > rename drivers/{platform/x86 =3D> firmware}/firmware_attributes_class=2E= c (94%) > rename drivers/platform/x86/firmware_attributes_class=2Eh =3D> include/l= inux/firmware_attributes=2Eh (60%) > >Range-diff against v5: >1: 4a82d0a07612 ! 1: 02edc6d05059 firmware: Move firmware attributes cl= ass helper > @@ Commit message > under platform/x86=2E > =20 > Reviewed-by: Mark Pearson > + Reviewed-by: Derek J=2E Clark > Signed-off-by: Sean Rhodes > =20 > ## MAINTAINERS ## > @@ drivers/platform/x86/Makefile: obj-$(CONFIG_X86_PLATFORM_DRIVERS_H= P) +=3D hp/ > obj-$(CONFIG_SENSORS_HDAPS) +=3D hdaps=2Eo > =20 > ## drivers/platform/x86/asus-armoury=2Ec ## > +@@ > + #include > + #include > + #include > ++#include > + #include > + #include > + #include > @@ > #include > =20 > #include "asus-armoury=2Eh" > -#include "firmware_attributes_class=2Eh" > -+#include > =20 > #define ASUS_NB_WMI_EVENT_GUID "0B3CBB35-E3C2-45ED-91C2-4C5A6D195D1= C" > =20 > =20 > ## drivers/platform/x86/dell/dell-wmi-sysman/sysman=2Ec ## > @@ > + #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > +=20 > + #include > +-#include > + #include > +-#include > ++#include > ++#include > + #include > ++#include > ++#include > + #include > #include > #include > ++ > #include "dell-wmi-sysman=2Eh" > -#include "=2E=2E/=2E=2E/firmware_attributes_class=2Eh" > -+#include > =20 > #define MAX_TYPES 4 > - #include > +-#include > +=20 > + struct wmi_sysman_priv wmi_priv =3D { > + =2Emutex =3D __MUTEX_INITIALIZER(wmi_priv=2Emutex), > =20 > ## drivers/platform/x86/hp/hp-bioscfg/bioscfg=2Ec ## > @@ > +=20 > + #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > +=20 > ++#include > ++#include > + #include > +-#include > + #include > ++#include > ++#include > + #include > #include > #include > ++ > #include "bioscfg=2Eh" > -#include "=2E=2E/=2E=2E/firmware_attributes_class=2Eh" > -+#include > - #include > - #include > +-#include > +-#include > =20 > + MODULE_AUTHOR("Jorge Lopez "); > + MODULE_DESCRIPTION("HP BIOS Configuration Driver"); > =20 > ## drivers/platform/x86/lenovo/think-lmi=2Ec ## > @@ > +=20 > + #include > + #include > ++#include > + #include > ++#include > + #include > + #include > + #include > #include > - #include > +-#include > #include > -#include "=2E=2E/firmware_attributes_class=2Eh" > -+#include > ++ > #include "think-lmi=2Eh" > =20 > static bool debug_support; > =20 > ## drivers/platform/x86/lenovo/wmi-other=2Ec ## > +@@ > + #include > + #include > + #include > ++#include > + #include > + #include > + #include > @@ > #include "wmi-capdata=2Eh" > #include "wmi-events=2Eh" > #include "wmi-helpers=2Eh" > -#include "=2E=2E/firmware_attributes_class=2Eh" > -+#include > =20 > #define LENOVO_OTHER_MODE_GUID "DC2A8805-3A8C-41BA-A6F7-092E0089CD3= B" > =20 > =20 > ## drivers/platform/x86/samsung-galaxybook=2Ec ## > @@ > + #include > + #include > + #include > ++#include > + #include > + #include > + #include > +@@ > + #include > #include > #include > ++ > #include > -#include "firmware_attributes_class=2Eh" > -+#include > =20 > #define DRIVER_NAME "samsung-galaxybook" > =20 >2: 285b33f805dc =3D 2: d5d3d1334994 firmware: Rename google firmware di= rectory to coreboot >3: ce91f4da5510 =3D 3: 7a65c6b0e631 firmware: coreboot: Add CFR firmwar= e attributes driver