From: Daniel Almeida <daniel.almeida@collabora.com>
To: Tamir Duberstein <tamird@gmail.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Boris-Chengbiao Zhou" <bobo1239@web.de>,
"Kees Cook" <kees@kernel.org>, "Fiona Behrens" <me@kloenk.dev>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
"Lukas Wirth" <lukas.wirth@ferrous-systems.com>
Subject: Re: [PATCH v4 06/11] scripts: generate_rust_analyzer.py: use str(pathlib.Path)
Date: Tue, 25 Mar 2025 10:56:16 -0300 [thread overview]
Message-ID: <32FF4399-D3BB-4F41-A103-CC41290CDA3A@collabora.com> (raw)
In-Reply-To: <20250322-rust-analyzer-host-v4-6-1f51f9c907eb@gmail.com>
> On 22 Mar 2025, at 10:23, Tamir Duberstein <tamird@gmail.com> wrote:
>
> Use the `/` operator on `pathlib.Path` rather than directly crafting a
> string. This is consistent with all other path manipulation in this
> script.
>
> Reviewed-by: Fiona Behrens <me@kloenk.dev>
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>
> ---
> scripts/generate_rust_analyzer.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/generate_rust_analyzer.py b/scripts/generate_rust_analyzer.py
> index 0772ea309f94..1ee079c6d916 100755
> --- a/scripts/generate_rust_analyzer.py
> +++ b/scripts/generate_rust_analyzer.py
> @@ -123,7 +123,7 @@ def generate_crates(
> proc_macro_crate: ProcMacroCrate = {
> **crate,
> "is_proc_macro": True,
> - "proc_macro_dylib_path": f"{objtree}/rust/{proc_macro_dylib_name}",
> + "proc_macro_dylib_path": str(objtree / "rust" / proc_macro_dylib_name),
> }
> register_crate(proc_macro_crate)
>
>
> --
> 2.48.1
>
>
Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>
next prev parent reply other threads:[~2025-03-25 13:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-22 13:23 [PATCH v4 00/11] rust: generate_rust_analyzer.py: define host crates and scripts Tamir Duberstein
2025-03-22 13:23 ` [PATCH v4 01/11] scripts: generate_rust_analyzer.py: add missing whitespace Tamir Duberstein
2025-03-25 13:08 ` Daniel Almeida
2025-03-22 13:23 ` [PATCH v4 02/11] scripts: generate_rust_analyzer.py: use double quotes Tamir Duberstein
2025-03-25 13:11 ` Daniel Almeida
2025-03-22 13:23 ` [PATCH v4 03/11] scripts: generate_rust_analyzer.py: add trailing comma Tamir Duberstein
2025-03-25 13:12 ` Daniel Almeida
2025-03-22 13:23 ` [PATCH v4 04/11] scripts: generate_rust_analyzer.py: extract `{build,register}_crate` Tamir Duberstein
2025-03-25 13:24 ` Daniel Almeida
2025-03-25 16:51 ` Fiona Behrens
2025-03-22 13:23 ` [PATCH v4 05/11] scripts: generate_rust_analyzer.py: add type hints Tamir Duberstein
2025-03-25 13:37 ` Daniel Almeida
2025-03-25 13:39 ` Daniel Almeida
2025-03-25 14:19 ` Miguel Ojeda
2025-03-25 14:40 ` Daniel Almeida
2025-03-25 16:47 ` Tamir Duberstein
2025-03-22 13:23 ` [PATCH v4 06/11] scripts: generate_rust_analyzer.py: use str(pathlib.Path) Tamir Duberstein
2025-03-25 13:56 ` Daniel Almeida [this message]
2025-03-22 13:23 ` [PATCH v4 07/11] scripts: generate_rust_analyzer.py: identify crates explicitly Tamir Duberstein
2025-03-25 14:01 ` Daniel Almeida
2025-03-22 13:23 ` [PATCH v4 08/11] scripts: generate_rust_analyzer.py: define host crates Tamir Duberstein
2025-03-25 14:05 ` Daniel Almeida
2025-03-22 13:23 ` [PATCH v4 09/11] scripts: generate_rust_analyzer.py: avoid FD leak Tamir Duberstein
2025-03-25 14:06 ` Daniel Almeida
2025-03-25 16:51 ` Fiona Behrens
2025-03-22 13:23 ` [PATCH v4 10/11] scripts: generate_rust_analyzer.py: define scripts Tamir Duberstein
2025-03-25 14:08 ` Daniel Almeida
2025-03-25 16:53 ` Fiona Behrens
2025-03-22 13:23 ` [PATCH v4 11/11] scripts: generate_rust_analyzer.py: use `cfg_groups` Tamir Duberstein
2025-03-23 12:40 ` Miguel Ojeda
2025-03-25 14:38 ` Daniel Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32FF4399-D3BB-4F41-A103-CC41290CDA3A@collabora.com \
--to=daniel.almeida@collabora.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=bobo1239@web.de \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.wirth@ferrous-systems.com \
--cc=me@kloenk.dev \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®