From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11D9D1B5EA2 for ; Thu, 29 Aug 2024 19:44:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724960649; cv=none; b=pc8RLH9j++aBRJLV8B7sDBARlSpxNntpBN/+tBanhUEaWral6sWCn4ONE7BJlAA7Nm/KvRdwsdJEPBjNqmuQyCc/j069wMsK24KQgsjBfOxd2nQKKWm36kD5dLnVbjMvcYUMLvy9b2mNN3T6nJmCprXMRDeIudX1s6dhHpvHhc0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724960649; c=relaxed/simple; bh=bXjJdHgoJ/gf8p/nQ0iqm1gd55gvbLyJ9mhQp0JSHqs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Z2RV/0xtc6xGmq6vToL4JNDIGu8Sr0cqv2G5QYaEx+0gyuH322+yEs5qXFkrAaDCuo9F/0FRf5L+7fRIonIvZ3Mud/D6Ha+8a11+0ahX+Pnj5tzM1fGdaPozdehFK1JcjJM4GcyYTOhfeH20gFAX49qoLHVkoihIfXyxe9qOEfM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Oahsf2w7; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Oahsf2w7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724960646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7gxUzp50O1mInc9XDA/L9eFmSo7JrCc7dhrGNNIpXkg=; b=Oahsf2w7PQ+yjLoASazB8SCg3RZEKS3sJVYfxzPn90PTPKeRRVp4slz1h4kRxYihwheOH/ 1F5zB5s2JP+4VVWr7N9J6hKwbTV/Y08Ew0UQgl3umYNB4uMYe9Bj2lpp1pm9QKjOGLmy4l W9i6koD5qFei5W94xbBrumLyVM6wcOo= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-599-phOXQTIENkC_PJ-0YyIm6w-1; Thu, 29 Aug 2024 15:44:05 -0400 X-MC-Unique: phOXQTIENkC_PJ-0YyIm6w-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-371a804f191so670614f8f.3 for ; Thu, 29 Aug 2024 12:44:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724960644; x=1725565444; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=7gxUzp50O1mInc9XDA/L9eFmSo7JrCc7dhrGNNIpXkg=; b=nDZCeqL3ElqvESFL1x8QKSCrngqhwU+gesoozTpD0E8qKJ78j9vW2E0XLBD1Vm5+oe lm4+iwy4k6pvYqlh0W4ZzkxuvC+mJ9UikFESUtfceKqH2NSTALfx1MHQl/tLSeGRXDBb 1+1Gu97MK6cFuTJwS7yuUpiHyAtT6/haUXkoM989BQRtHpXWCSzdy6hYjOluZV6xqhLX srK88Ex4pJhxH8D4S96w8FIvFTZBCcqlckXA5A9vXkj9xMSRbN9hCvd3kVP/hbnwFi8v Yybie0hpbcQ4rLuyGy3LipwhD0lU/LKCEgoGqpBmIHLm5a6yRGjRCvMwLfy8Vle9wcfl bTuA== X-Gm-Message-State: AOJu0YwjkawybRNrreBH8w3ZDNFJw8wPQF9n+hkerfVLs7VmNuHloiuT fTadBzWpIBDeFiWc8FrhWjCkXztR6J2tvvm5Bgc4YooP27hxmt4yecXXsqrjjzxxDTl3ehXN/Bb hbtgjqNJtCG+PaqSbYhEctzrHQhQixSrvdaBrfbtQHqaA12cxNFitCSUVllgoKA== X-Received: by 2002:a5d:5848:0:b0:371:7db6:89df with SMTP id ffacd0b85a97d-3749b54d0d3mr3240266f8f.31.1724960644338; Thu, 29 Aug 2024 12:44:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHj7wSmf+BALvcj9Vavd2cBipEI9aWDfaheAlF4lOQP8quj0z4TYnx8DzRdYpBH8QjiC7U7iA== X-Received: by 2002:a5d:5848:0:b0:371:7db6:89df with SMTP id ffacd0b85a97d-3749b54d0d3mr3240226f8f.31.1724960643488; Thu, 29 Aug 2024 12:44:03 -0700 (PDT) Received: from ?IPV6:2003:cb:c711:c600:c1d6:7158:f946:f083? (p200300cbc711c600c1d67158f946f083.dip0.t-ipconnect.de. [2003:cb:c711:c600:c1d6:7158:f946:f083]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42bacaac810sm44098825e9.33.2024.08.29.12.44.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Aug 2024 12:44:02 -0700 (PDT) Message-ID: <32a451ee-6836-4d4d-814c-752c15415aae@redhat.com> Date: Thu, 29 Aug 2024 21:44:01 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 07/19] mm/fork: Accept huge pfnmap entries To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Gavin Shan , Catalin Marinas , x86@kernel.org, Ingo Molnar , Andrew Morton , Paolo Bonzini , Dave Hansen , Thomas Gleixner , Alistair Popple , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sean Christopherson , Oscar Salvador , Jason Gunthorpe , Borislav Petkov , Zi Yan , Axel Rasmussen , Yan Zhao , Will Deacon , Kefeng Wang , Alex Williamson References: <20240826204353.2228736-1-peterx@redhat.com> <20240826204353.2228736-8-peterx@redhat.com> <78d77162-11df-4437-b70b-fa04f868a494@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 29.08.24 20:26, Peter Xu wrote: > On Thu, Aug 29, 2024 at 05:10:42PM +0200, David Hildenbrand wrote: >> On 26.08.24 22:43, Peter Xu wrote: >>> Teach the fork code to properly copy pfnmaps for pmd/pud levels. Pud is >>> much easier, the write bit needs to be persisted though for writable and >>> shared pud mappings like PFNMAP ones, otherwise a follow up write in either >>> parent or child process will trigger a write fault. >>> >>> Do the same for pmd level. >>> >>> Signed-off-by: Peter Xu >>> --- >>> mm/huge_memory.c | 29 ++++++++++++++++++++++++++--- >>> 1 file changed, 26 insertions(+), 3 deletions(-) >>> >>> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >>> index e2c314f631f3..15418ffdd377 100644 >>> --- a/mm/huge_memory.c >>> +++ b/mm/huge_memory.c >>> @@ -1559,6 +1559,24 @@ int copy_huge_pmd(struct mm_struct *dst_mm, struct mm_struct *src_mm, >>> pgtable_t pgtable = NULL; >>> int ret = -ENOMEM; >>> + pmd = pmdp_get_lockless(src_pmd); >>> + if (unlikely(pmd_special(pmd))) { >> >> I assume I have to clean up your mess here as well? > > Can you leave meaningful and explicit comment? I'll try to address. Sorry Peter, but I raised all that as reply to v1. For example, I stated that vm_normal_page_pmd() already *exist* and why these pmd_special() checks should be kept there. I hear you, you're not interested in cleaning that up. So at this point it's easier for me to clean it up myself. -- Cheers, David / dhildenb