From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABFFCC4332F for ; Tue, 31 Oct 2023 04:18:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235850AbjJaES7 (ORCPT ); Tue, 31 Oct 2023 00:18:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236280AbjJaESw (ORCPT ); Tue, 31 Oct 2023 00:18:52 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83822E4; Mon, 30 Oct 2023 21:18:50 -0700 (PDT) Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39V3ol5E010778; Tue, 31 Oct 2023 04:18:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=8T2KQUSFh9TdIX8gLoZuwNgZZ2p+9xS6EK/92JSxnHA=; b=RLH0xKBLMZ4n78ItJ7WbOYdXPshRgSfjqdECizGujlFcWL0b14dbu3AHiMZNqUjx43Se OAr4jpgXSa0yo/w0QzQ25K9Su1viIRjGFeXb5OJeTpfQapOof6d1wHTqwIvgjkYrgAK3 yHqd+DZAUqpGkHxuXlKT7eZCfAjsFIq3KkO64Zb99qZW2wH6CHwv7T3NVhquahOzSzxb 4S9shWkqHD4fICclv8OhpOxqkHx/G97p5KWm9BWVkrBeQnQVPQCcHTaWdh7VY4MAskh8 p0EvdSsldeERORcpw36QC/ZUyVCSulbh6pD97RkJA0cCQpXinqWnBEV7CvblNzJJ0/FN eA== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3u2dey1qwg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 31 Oct 2023 04:18:41 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 39V4IdDJ009768 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 31 Oct 2023 04:18:39 GMT Received: from [10.201.2.96] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Mon, 30 Oct 2023 21:18:33 -0700 Message-ID: <32a55443-02c2-47e8-956b-28d8b106ceab@quicinc.com> Date: Tue, 31 Oct 2023 09:48:33 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/8] arm64: dts: qcom: ipq5332: add support for the NSSCC Content-Language: en-US To: Krzysztof Kozlowski , Bjorn Andersson , Andy Gross , Konrad Dybcio , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Catalin Marinas , Will Deacon CC: , , , , , References: <20231030-ipq5332-nsscc-v1-0-6162a2c65f0a@quicinc.com> <20231030-ipq5332-nsscc-v1-7-6162a2c65f0a@quicinc.com> <6cc57f82-cd65-42b3-99cd-79b5b784c386@linaro.org> From: Kathiravan Thirumoorthy In-Reply-To: <6cc57f82-cd65-42b3-99cd-79b5b784c386@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: PX-TiHzytzsnFlnbHLu5S6SxcctFu8iZ X-Proofpoint-GUID: PX-TiHzytzsnFlnbHLu5S6SxcctFu8iZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-30_13,2023-10-31_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 spamscore=0 bulkscore=0 mlxscore=0 phishscore=0 priorityscore=1501 impostorscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310240000 definitions=main-2310310031 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/30/2023 4:43 PM, Krzysztof Kozlowski wrote: > On 30/10/2023 10:47, Kathiravan Thirumoorthy wrote: >> Describe the NSS clock controller node and it's relevant external >> clocks. >> >> Signed-off-by: Kathiravan Thirumoorthy >> --- >> arch/arm64/boot/dts/qcom/ipq5332.dtsi | 28 ++++++++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi >> index 42e2e48b2bc3..291f14a3f10a 100644 >> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi >> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi >> @@ -15,6 +15,18 @@ / { >> #size-cells = <2>; >> >> clocks { >> + cmn_pll_nss_clk_200m: cmn-pll-nss-clk-200m { > > Node names should be generic. See also an explanation and list of > examples (not exhaustive) in DT specification: > https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > > > so with "clk" suffix, e.g. cmn-pll-nss-1-clk. Sure, will fix it in V2. > >> + compatible = "fixed-clock"; >> + clock-frequency = <200000000>; >> + #clock-cells = <0>; >> + }; >> + >> + cmn_pll_nss_clk_300m: cmn-pll-nss-clk-300m { >> + compatible = "fixed-clock"; >> + clock-frequency = <300000000>; >> + #clock-cells = <0>; >> + }; >> + >> sleep_clk: sleep-clk { >> compatible = "fixed-clock"; >> #clock-cells = <0>; >> @@ -473,6 +485,22 @@ frame@b128000 { >> status = "disabled"; >> }; >> }; > Best regards, > Krzysztof >