From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Xu Yang <xu.yang_2@nxp.com>,
gregkh@linuxfoundation.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
conor+dt@kernel.org
Cc: s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com, peter.chen@kernel.org,
jun.li@nxp.com, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 07/11] dt-bindings: usb: ci-hdrc-usb2-imx: remove fsl,anatop property
Date: Thu, 29 Feb 2024 16:15:35 +0100 [thread overview]
Message-ID: <32a5605a-c810-4b3d-bb72-4d413d9f9bb9@linaro.org> (raw)
In-Reply-To: <20240228113004.918205-7-xu.yang_2@nxp.com>
On 28/02/2024 12:30, Xu Yang wrote:
> Property "fsl,anatop" is needed by usb phy rather usb controller.
> This will remove it from ci-hdrc-usb2-imx schema.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
>
> ---
> Changes in v7:
> - new patch
> ---
> Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml
> index a2932af2c09b..0a6ebb427130 100644
> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml
> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml
> @@ -74,10 +74,6 @@ properties:
> - description: phandle to usbmisc node
> - description: index of usb controller
>
> - fsl,anatop:
> - description: phandle for the anatop node.
> - $ref: /schemas/types.yaml#/definitions/phandle
Then why did you copy it from original schema? Just remove it before all
this work.
Again: Do not add lines in one patch which immediately later are being
removed. Such patchset has no effect and is only confusing. This
suggests your order is incorrect.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-29 15:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 11:29 [PATCH v7 01/11] dt-bindings: usb: usbmisc-imx: add fsl,imx8ulp-usbmisc compatible Xu Yang
2024-02-28 11:29 ` [PATCH v7 02/11] arm64: dts: imx8ulp: add usb nodes Xu Yang
2024-02-28 11:29 ` [PATCH v7 03/11] arm64: dts: imx8ulp-evk: enable usb nodes and add ptn5150 nodes Xu Yang
2024-02-28 11:29 ` [PATCH v7 04/11] dt-bindings: usb: ci-hdrc-usb2-imx: move imx parts to dedicated schema Xu Yang
2024-02-29 15:11 ` Krzysztof Kozlowski
2024-03-08 8:30 ` [EXT] " Xu Yang
2024-03-08 8:38 ` Krzysztof Kozlowski
2024-02-28 11:29 ` [PATCH v7 05/11] dt-bindings: usb: ci-hdrc-usb2-imx: add restrictions for reg, interrupts, clock and clock-names properties Xu Yang
2024-02-29 15:13 ` Krzysztof Kozlowski
2024-03-08 8:46 ` [EXT] " Xu Yang
2024-02-28 11:29 ` [PATCH v7 06/11] dt-bindings: usb: ci-hdrc-usb2-imx: add compatible and clock-names restriction for imx93 Xu Yang
2024-02-29 15:14 ` Krzysztof Kozlowski
2024-03-12 6:36 ` [EXT] " Xu Yang
2024-02-29 15:14 ` Krzysztof Kozlowski
2024-02-28 11:30 ` [PATCH v7 07/11] dt-bindings: usb: ci-hdrc-usb2-imx: remove fsl,anatop property Xu Yang
2024-02-29 15:15 ` Krzysztof Kozlowski [this message]
2024-03-12 6:38 ` [EXT] " Xu Yang
2024-02-28 11:30 ` [PATCH v7 08/11] ARM: dts: imx6: remove fsl,anatop property from usb controller node Xu Yang
2024-02-28 11:30 ` [PATCH v7 09/11] arm64: dts: imx93: add usb nodes Xu Yang
2024-02-28 11:30 ` [PATCH v7 10/11] arm64: dts: imx93-11x11-evk: enable usb and typec nodes Xu Yang
2024-02-28 11:30 ` [PATCH v7 11/11] usb: chipidea: ci_hdrc_imx: align usb wakeup clock name with dt-bindings Xu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32a5605a-c810-4b3d-bb72-4d413d9f9bb9@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®