From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4A6AC43331 for ; Tue, 31 Mar 2020 02:36:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 70C9720714 for ; Tue, 31 Mar 2020 02:36:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZcpA+D57" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729591AbgCaCgP (ORCPT ); Mon, 30 Mar 2020 22:36:15 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:28970 "EHLO us-smtp-delivery-74.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729299AbgCaCgO (ORCPT ); Mon, 30 Mar 2020 22:36:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585622173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nhe1R9fcd9sn8sBUTkjUECHmGPeTRwWPtrkYv9HeUA4=; b=ZcpA+D57kkQXRJiPSwen/I4mUZOMQy7s7omIDoYKx/oBNbLHs9qZFU7bM5awdPMrMpa0/u 58Av6BENgpeRgpoTvNcfFQSWNjsTEgyz3C8FmQ42wAQ83aazFOd9gQvwddvhg8Em7RCKCs LEDo1ovLGRHNyej9OiBfbvqxlX/k78U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-157-htrLS0PsNj2cJicau63YfA-1; Mon, 30 Mar 2020 22:36:09 -0400 X-MC-Unique: htrLS0PsNj2cJicau63YfA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E29BA800D5B; Tue, 31 Mar 2020 02:36:07 +0000 (UTC) Received: from [10.72.12.115] (ovpn-12-115.pek2.redhat.com [10.72.12.115]) by smtp.corp.redhat.com (Postfix) with ESMTP id 82F3F5C1C5; Tue, 31 Mar 2020 02:35:58 +0000 (UTC) Subject: Re: [PATCH] vhost: vdpa: remove unnecessary null check To: "Gustavo A. R. Silva" , "Michael S. Tsirkin" , Tiwei Bie , =?UTF-8?Q?Eugenio_P=c3=a9rez?= Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200330235040.GA9997@embeddedor> From: Jason Wang Message-ID: <32ae2f4c-de7c-050b-85a2-489b6813fd5f@redhat.com> Date: Tue, 31 Mar 2020 10:35:56 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200330235040.GA9997@embeddedor> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/3/31 =E4=B8=8A=E5=8D=887:50, Gustavo A. R. Silva wrote: > container_of is never null, so this null check is > unnecessary. > > Addresses-Coverity-ID: 1492006 ("Logically dead code") > Fixes: 20453a45fb06 ("vhost: introduce vDPA-based backend") > Signed-off-by: Gustavo A. R. Silva > --- > drivers/vhost/vdpa.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c > index 421f02a8530a..3d2cb811757a 100644 > --- a/drivers/vhost/vdpa.c > +++ b/drivers/vhost/vdpa.c > @@ -678,8 +678,6 @@ static int vhost_vdpa_open(struct inode *inode, str= uct file *filep) > int nvqs, i, r, opened; > =20 > v =3D container_of(inode->i_cdev, struct vhost_vdpa, cdev); > - if (!v) > - return -ENODEV; > =20 > opened =3D atomic_cmpxchg(&v->opened, 0, 1); > if (opened) Acked-by: Jason Wang Thanks