From: Krzysztof Kozlowski <krzk@kernel.org>
To: Brajesh Patil <brajeshpatil11@gmail.com>,
jic23@kernel.org, lars@metafoo.de, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, marcelo.schmitt1@gmail.com,
dlechner@baylibre.com
Subject: Re: [PATCH v2 2/5] dt-bindings: iio: magnetometer: qst: Add QMC5883L device tree binding
Date: Thu, 8 May 2025 14:16:26 +0200 [thread overview]
Message-ID: <32b295ae-4186-4d37-9bfb-15b81afaa5ec@kernel.org> (raw)
In-Reply-To: <20250508120846.114262-1-brajeshpatil11@gmail.com>
On 08/05/2025 14:08, Brajesh Patil wrote:
> Signed-off-by: Brajesh Patil <brajeshpatil11@gmail.com>
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
...
> +
> + mount-matrix:
> + description: |
> + A 3x3 rotation matrix describing how the magnetometer is mounted
> + on the device. This is used to orient the sensor measurements
> + to match the device's coordinate system.
No supplies?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-08 12:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 12:08 Brajesh Patil
2025-05-08 12:16 ` Krzysztof Kozlowski [this message]
2025-05-11 15:19 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32b295ae-4186-4d37-9bfb-15b81afaa5ec@kernel.org \
--to=krzk@kernel.org \
--cc=brajeshpatil11@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®