From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA9AAC00528 for ; Wed, 2 Aug 2023 12:38:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234527AbjHBMif (ORCPT ); Wed, 2 Aug 2023 08:38:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234519AbjHBMiX (ORCPT ); Wed, 2 Aug 2023 08:38:23 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED12326B0 for ; Wed, 2 Aug 2023 05:38:20 -0700 (PDT) Received: from dggpemm100001.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4RGBJJ01GtztRLq; Wed, 2 Aug 2023 20:34:55 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 2 Aug 2023 20:38:17 +0800 Message-ID: <32b748d2-3d88-87d6-3797-c82d7bb7a927@huawei.com> Date: Wed, 2 Aug 2023 20:38:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 0/4] mm: migrate: more folio conversion Content-Language: en-US To: David Hildenbrand , Andrew Morton , , CC: Huang Ying , Matthew Wilcox References: <20230802095346.87449-1-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm100001.china.huawei.com (7.185.36.93) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/8/2 19:47, David Hildenbrand wrote: > On 02.08.23 11:53, Kefeng Wang wrote: >> This patch series converts several functions to use folio in migrate.c. > > Please clearly spell out in the patch descriptions when you are changing > mapcount logic and which effects that might have (both, positive and > negative) for PTE-mapped THP. Oh, I see your comments on another mail[1], the folio_estimated_sharers() is not good to evaluate the sharing by multiple processes, will read more history of the mail's discussion, maybe just ignore the first three patches. Thank. [1] [PATCH 0/2] don't use mapcount() to check large folio sharing >