From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B57DC46464 for ; Mon, 13 Aug 2018 22:15:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B151821765 for ; Mon, 13 Aug 2018 22:15:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ourkYo1P" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B151821765 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731933AbeHNBAG (ORCPT ); Mon, 13 Aug 2018 21:00:06 -0400 Received: from mail-qk0-f193.google.com ([209.85.220.193]:46946 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729855AbeHNBAG (ORCPT ); Mon, 13 Aug 2018 21:00:06 -0400 Received: by mail-qk0-f193.google.com with SMTP id 191-v6so12107959qki.13; Mon, 13 Aug 2018 15:15:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2eFpbeWYk+o8i7DKTgKe9+e/OZteF8P5YQ0BN6t7IoU=; b=ourkYo1PiEOOsZ3pchZ6PuNLiYQr8axyN/8+C9YeHIHu/RKGitlSRk7KbgK3V6H+mK dkJTnD+F1lcVflnZAeYG3kyTUNlmrM5aIwh1R5ONkUubfK+zW9bkq7BUiMiF4iGeJlzD fp4z88QTptalrNpNFhHqHYH7e1lFk7mVA8DMoRRc2tTH+pIiHpRbayfB6QIrIn0F0FKu WgQ/kgkYT+sjyN5y4W6WGS6cI/1LU0KoQceNlEiVtJ5IjIgpxMMvV4gPuXzm2k3x/+Pc iEXqJZb7DhoczmwNb13joy5M+Mp4DfHmgDLhcxsBEcO2a4rK3mcZVwRaZDKDQsBWg2kO 77qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=2eFpbeWYk+o8i7DKTgKe9+e/OZteF8P5YQ0BN6t7IoU=; b=Rt1ZpPWFhBjuOiRz/1zDNpNs1bArVovTjKIH98r240GHyttzqLFmVkw8hyGcuaZ9e+ nPtoIKcUWnnsJjw0JYmlgee+jHqzzCrwG1QvX4Jpz1dnQpG7+7ST0CHte+D+TpRrztNf 5TpqvC6v3DdMbh3QXqGn7B2DdQLwFhaS1DlImC+Q4lzqV363S69sfqc1HKaLfKQdGv8o cFWRnq7/eGGDL/z6DREkHLE97I9HFyLsv9oDoq5pcjajTIBaMFADHPsEAEx5NDCpUf20 hwyVAhrChx+VEOgvlrpL1Li88M1VPQNU8Qw2OpxI+VKQ2BJF7MmUVBWOyke/R91leszy 6WqQ== X-Gm-Message-State: AOUpUlFVH8rVMtYpcgzD+uKbkqR35pVjyIOEUfuLUbqtEcPec7s0i6Kg 1Wp29z9gjnsBbgRSu/24HDUV2wZR X-Google-Smtp-Source: AA+uWPzbmgP3FYqinqdGd8q1UMCUqpgnBPwStr4ZiJSW9d/RllB8rDSmhgzKf4ib8SJoSM3Lx85g1w== X-Received: by 2002:a37:484a:: with SMTP id v71-v6mr17011971qka.38.1534198554839; Mon, 13 Aug 2018 15:15:54 -0700 (PDT) Received: from [10.69.41.93] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id s73-v6sm12248618qkl.65.2018.08.13.15.15.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Aug 2018 15:15:53 -0700 (PDT) Subject: Re: [PATCH] net: systemport: fix unused function warning To: Arnd Bergmann , "David S. Miller" Cc: Tal Gilboa , Alexander Duyck , Jeff Kirsher , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180813221041.219857-1-arnd@arndb.de> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= xsDiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz80nRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+wmYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSDOw00ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU8JPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJw== Message-ID: <32b85b26-29cb-6d90-8974-ed9929fb3d68@gmail.com> Date: Mon, 13 Aug 2018 15:15:46 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180813221041.219857-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/13/2018 03:10 PM, Arnd Bergmann wrote: > The only remaining caller of this function is inside of an #ifdef > after another caller got removed. This causes a harmless warning > in some configurations: > > drivers/net/ethernet/broadcom/bcmsysport.c:1068:13: error: 'bcm_sysport_resume_from_wol' defined but not used [-Werror=unused-function] > > Removing the #ifdef around the PM functions simplifies the code > and avoids the problem but letting the compiler drop the unused > functions silently. > > Fixes: 9e85e22713d6 ("net: systemport: Do not re-configure upon WoL interrupt") > Signed-off-by: Arnd Bergmann Acked-by: Florian Fainelli Thank you Arnd. -- Florian