From: Maarten Zanders <maarten.zanders@mind.be>
To: Lee Jones <lee@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/2] leds: lp55xx: configure internal charge pump
Date: Thu, 6 Apr 2023 10:28:42 +0200 [thread overview]
Message-ID: <32c0a958-58bd-7476-c276-94c8f33ffbb3@mind.be> (raw)
In-Reply-To: <20230405152627.GO8371@google.com>
> Sorry Maarten, just a couple of small nits.
No need to be sorry.
> This fits on one line, no? < 100-chars?
I thought the line length was meant to be <80 chars according to:
https://www.kernel.org/doc/html/latest/process/coding-style.html#breaking-long-lines-and-strings
Happy to adapt if this shouldn't be taken as strict as I tried to do.
Either way I'll post an update with a cleanup.
>
>> --- a/include/linux/platform_data/leds-lp55xx.h
>> +++ b/include/linux/platform_data/leds-lp55xx.h
>> @@ -73,6 +73,9 @@ struct lp55xx_platform_data {
>> /* Clock configuration */
>> u8 clock_mode;
>>
>> + /* Charge pump mode */
>> + u32 charge_pump_mode;
> That's a lot of data. Does it need to be u32?
No, it luckily doesn't get that big. This is to avoid an intermediate
variable & casting as the DT parameter has to be 32bit (which I learned
from an earlier comment). It was changed from u8 in v5 of the patch.
Thanks for the review,
Maarten
next prev parent reply other threads:[~2023-04-06 8:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 11:46 [PATCH v6 0/2] " Maarten Zanders
2023-03-31 11:46 ` [PATCH v6 1/2] dt-bindings: leds-lp55xx: add ti,charge-pump-mode Maarten Zanders
2023-03-31 11:46 ` [PATCH v6 2/2] leds: lp55xx: configure internal charge pump Maarten Zanders
2023-04-05 15:26 ` Lee Jones
2023-04-06 8:28 ` Maarten Zanders [this message]
2023-04-06 9:13 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32c0a958-58bd-7476-c276-94c8f33ffbb3@mind.be \
--to=maarten.zanders@mind.be \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®