From: Eric Blake <eblake@redhat.com>
To: Colin Walters <walters@verbum.org>, Greg Kurz <groug@kaod.org>,
viro@zeniv.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] vfs: implement fchmodat2() syscall
Date: Tue, 11 Apr 2017 13:08:52 -0500 [thread overview]
Message-ID: <32c7aa8f-e881-d85c-6508-fb0e58922a41@redhat.com> (raw)
In-Reply-To: <9005445d-2a56-effd-55da-b3bc700c5cf2@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 641 bytes --]
On 04/11/2017 01:07 PM, Eric Blake wrote:
>
> But even if using open(O_PATH)/fchmod() works, it is not immediately
> obvious whether it can catch all the same cases that chmodat(O_NOFOLLOW)
Typo; I obviously meant fchmodat(AT_SYMLINK_NOFOLLOW)
> would cover, as there are cases where you have permissions to change
> mode bits but not open() the file for reading or writing. And even if
> it gets rid of a TOCTTOU race, it still is a 2-syscall hit rather than
> an atomic single syscall.
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-04-11 18:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 17:03 Greg Kurz
2017-02-28 17:03 ` [PATCH 2/2] x86: wire up " Greg Kurz
2017-03-01 9:00 ` kbuild test robot
2017-02-28 18:23 ` [PATCH 1/2] vfs: implement " Eric Blake
2017-02-28 18:41 ` Greg Kurz
2017-02-28 18:59 ` Eric Blake
2017-04-11 17:52 ` Colin Walters
2017-04-11 17:55 ` Eric Blake
2017-04-11 18:07 ` Eric Blake
2017-04-11 18:08 ` Eric Blake [this message]
2017-04-11 19:09 ` Colin Walters
2017-04-19 12:45 ` Greg Kurz
2017-03-01 9:01 ` Michael Kerrisk
2017-04-11 11:39 ` Greg Kurz
2017-04-11 12:04 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32c7aa8f-e881-d85c-6508-fb0e58922a41@redhat.com \
--to=eblake@redhat.com \
--cc=groug@kaod.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=walters@verbum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®