From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m49237.qiye.163.com (mail-m49237.qiye.163.com [45.254.49.237]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D7B0A935; Wed, 25 Dec 2024 09:34:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.254.49.237 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735119274; cv=none; b=DtopuQzHN8udh8qyNpW+gHNmGK8NtowRMdmyJ+S1pK22d8SFFQKTfuy8Vl4tLuEAi4xy6rIINobp/Sm20BFUduHdNXzTnZ5cX3LzUlgXkjXnosJ+Ftx7aH04qIBmzBReiU4vvbDvh2otDKfI3frQePPASz9kk09e9Co2f7ApAck= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735119274; c=relaxed/simple; bh=BUaIvx5v8Pa8yaseCMKxx+JIjT3o4ecfRsjn6xaUB2E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jShLAggmcWoMLvCC+3OXPjPrWWIQfs8iI+DQKgqZSJhoqM3wp2x+NxjDRbl2Ay2gtBcDZ9Y/qQPh1HL4OaQiFnsNaEHN4QNRC0iWNK+CTZNySOdNaRFKaFFmyxKVQKYBKZYD25ascWWCEp+J3OtpF0uRJu0QYAIoARBUzuZOo1A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=kaQs319T; arc=none smtp.client-ip=45.254.49.237 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="kaQs319T" Received: from [172.16.12.26] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 6c6e1666; Wed, 25 Dec 2024 17:34:17 +0800 (GMT+08:00) Message-ID: <32c7ef0a-8da6-449a-8f2d-59965aa622ec@rock-chips.com> Date: Wed, 25 Dec 2024 17:34:17 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 14/15] arm64: dts: rockchip: Enable eDP0 display on RK3588S EVB1 board To: Dmitry Baryshkov Cc: heiko@sntech.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, rfoss@kernel.org, vkoul@kernel.org, sebastian.reichel@collabora.com, cristian.ciocaltea@collabora.com, l.stach@pengutronix.de, andy.yan@rock-chips.com, hjc@rock-chips.com, algea.cao@rock-chips.com, kever.yang@rock-chips.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org References: <20241219080604.1423600-1-damon.ding@rock-chips.com> <20241219080604.1423600-15-damon.ding@rock-chips.com> Content-Language: en-US From: Damon Ding In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGUweGVYeQk1KSx1MHR9OTEhWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSUhCSE NVSktLVUpCS0tZBg++ X-HM-Tid: 0a93fd2abf9b03a3kunm6c6e1666 X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6ODY6Ehw4NjIcNk4LOEswEgEB KDhPCxJVSlVKTEhOSkpCSU5CSUhKVTMWGhIXVR8aFhQVVR8SFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFPSk1INwY+ DKIM-Signature:a=rsa-sha256; b=kaQs319TgZLgE3daBx/HJEGlYlzgtVyLFOX29FOzekUTHT2VO0cM3Rtl3ZVhJA+lzlxZk0zUL2BKuKKG4P8vmv29QCBtfzvhrskZJiATdGo4/HQ9nqRotKayLndUOxQ8Dww+D7xUD3qnxGbJptgP0wpZI0e4HT7SiKdehVWUlMg=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=pWriVfSDH2sEpg8pcOmkXvybXUKi737yhk7CRzVorzU=; h=date:mime-version:subject:message-id:from; Hi Dmitry, On 2024/12/20 13:38, Dmitry Baryshkov wrote: > On Fri, 20 Dec 2024 at 04:38, Damon Ding wrote: >> >> Hi Dmitry, >> >> On 2024/12/20 8:20, Dmitry Baryshkov wrote: >>> On Thu, Dec 19, 2024 at 04:06:03PM +0800, Damon Ding wrote: >>>> Add the necessary DT changes to enable eDP0 on RK3588S EVB1 board: >>>> - Add edp-panel node >>>> - Set pinctrl of pwm12 for backlight >>>> - Enable edp0/hdptxphy0/vp2 >>>> >>>> Signed-off-by: Damon Ding >>>> >>>> --- >>>> >>>> Changes in v2: >>>> - Remove brightness-levels and default-brightness-level properties in >>>> backlight node. >>>> - Add the detail DT changes to commit message. >>>> >>>> Changes in v3: >>>> - Use aux-bus instead of platform bus for edp-panel. >>>> --- >>>> .../boot/dts/rockchip/rk3588s-evb1-v10.dts | 52 +++++++++++++++++++ >>>> 1 file changed, 52 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts >>>> index bc4077575beb..9547ab18e596 100644 >>>> --- a/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts >>>> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts >>>> @@ -9,6 +9,7 @@ >>>> #include >>>> #include >>>> #include >>>> +#include >>>> #include >>>> #include "rk3588s.dtsi" >>>> >>>> @@ -238,6 +239,41 @@ &combphy2_psu { >>>> status = "okay"; >>>> }; >>>> >>>> +&edp0 { >>>> + force-hpd; >>>> + status = "okay"; >>>> + >>>> + aux-bus { >>>> + panel { >>>> + compatible = "lg,lp079qx1-sp0v"; >>> >>> Why do you need the particular compat string here? Can you use the >>> generic "edp-panel" instead? What if the user swaps the panel? >>> >> >> The eDP panels used in conjunction with the RK3588S EVB1 have broken >> identification, which is one of the valid reasons for using a particular >> compat string. So the generic_edp_panel_probe() can not return success >> when using the "edp-panel". > > Broken how? I don't see such info in the commit message. > The log related to the broken identification may be like: [ 0.623793] panel-simple-dp-aux aux-fdec0000.edp: Unknown panel ETC 0x0000, using conservative timings The eDP panel used in RK3588S EVB1 is indeed the LP079QX1_SP0V model, it should be also reasonable to use the "lg,lp079qx1-sp0v". And I will mention all of the above in the commit message for the next version. >> >>>> + backlight = <&backlight>; >>>> + power-supply = <&vcc3v3_lcd_edp>; >>>> + >>>> + port { >>>> + panel_in_edp: endpoint { >>>> + remote-endpoint = <&edp_out_panel>; >>>> + }; >>>> + }; >>>> + }; >>>> + }; >>>> +}; >>>> + >>>> +&edp0_in { >>>> + edp0_in_vp2: endpoint { >>>> + remote-endpoint = <&vp2_out_edp0>; >>>> + }; >>>> +}; >>>> + >>>> +&edp0_out { >>>> + edp_out_panel: endpoint { >>>> + remote-endpoint = <&panel_in_edp>; >>>> + }; >>>> +}; >>>> + >>>> +&hdptxphy0 { >>>> + status = "okay"; >>>> +}; >>>> + >>>> &i2c3 { >>>> status = "okay"; >>>> >>>> @@ -399,6 +435,7 @@ usbc0_int: usbc0-int { >>>> }; >>>> >>>> &pwm12 { >>>> + pinctrl-0 = <&pwm12m1_pins>; >>>> status = "okay"; >>>> }; >>>> >>>> @@ -1168,3 +1205,18 @@ usbdp_phy0_dp_altmode_mux: endpoint@1 { >>>> }; >>>> }; >>>> }; >>>> + >>>> +&vop_mmu { >>>> + status = "okay"; >>>> +}; >>>> + >>>> +&vop { >>>> + status = "okay"; >>>> +}; >>>> + >>>> +&vp2 { >>>> + vp2_out_edp0: endpoint@ROCKCHIP_VOP2_EP_EDP0 { >>>> + reg = ; >>>> + remote-endpoint = <&edp0_in_vp2>; >>>> + }; >>>> +}; >>>> -- >>>> 2.34.1 >>>> Best regards Damon