From: "Michel Dänzer" <michel@daenzer.net>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Use kvzalloc for allocating blob property memory
Date: Fri, 29 Jun 2018 18:27:28 +0200 [thread overview]
Message-ID: <32deece3-b583-ca58-cd41-ba11846240c8@daenzer.net> (raw)
In-Reply-To: <20180629161205.GE5565@intel.com>
On 2018-06-29 06:12 PM, Ville Syrjälä wrote:
> On Fri, Jun 29, 2018 at 04:27:10PM +0200, Michel Dänzer wrote:
>> From: Michel Dänzer <michel.daenzer@amd.com>
>>
>> The property size may be controlled by userspace, can be large (I've
>> seen failure with order 4, i.e. 16 pages / 64 KB) and doesn't need to be
>> physically contiguous.
>
> I wonder if we should enforce some kind of reasonable limit
> on the blob size. Looks like we allow anything up to
> ULONG_MAX currently. We can't tell at createblob time how
> the thing is going to be used, so can't have any kind
> of property specific limit unfortunately.
The failure I was seeing was for a gamma LUT, so a size limit alone
cannot solve the issue.
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
next prev parent reply other threads:[~2018-06-29 16:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 14:27 Michel Dänzer
2018-06-29 14:50 ` Alex Deucher
2018-06-29 16:12 ` Ville Syrjälä
2018-06-29 16:27 ` Michel Dänzer [this message]
2018-06-29 16:38 ` Ville Syrjälä
2018-07-02 8:07 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32deece3-b583-ca58-cd41-ba11846240c8@daenzer.net \
--to=michel@daenzer.net \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®