mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Gopi Krishna Menon <krishnagopi487@gmail.com>,
	corbet@lwn.net, will@kernel.org, yangyicong@hisilicon.com,
	fj2767dz@fujitsu.com
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	skhan@linuxfoundation.org, david.hunter.linux@gmail.com,
	linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH v3] docs: perf: Fujitsu: Fix htmldocs build warnings and errors
Date: Thu, 25 Sep 2025 22:14:41 -0700	[thread overview]
Message-ID: <32e30b90-c089-4b96-9573-3c57a4e66a8e@infradead.org> (raw)
In-Reply-To: <20250926043748.3785-1-krishnagopi487@gmail.com>



On 9/25/25 9:36 PM, Gopi Krishna Menon wrote:
> Running "make htmldocs" generates the following build errors and
> warnings for fujitsu_uncore_pmu.rst:
> 
> Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst:20: ERROR: Unexpected indentation.
> Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst:23: WARNING: Block quote ends without a blank line; unexpected unindent.
> Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst:28: ERROR: Unexpected indentation.
> Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst:29: WARNING: Block quote ends without a blank line; unexpected unindent.
> Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst:81: ERROR: Unexpected indentation.
> Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst:82: WARNING: Block quote ends without a blank line; unexpected unindent.
> 
> Add blank line before bullet lists, block quotes to fix build
> errors, resolve warnings and properly render perf commands as
> code blocks.
> 
> Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Tested-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
> Changelog:
> 
> Changes in v3:
>    - Properly render perf commands as code blocks (use "e.g.::").
> 
> Changes in v2:
>    - Remove formatting changes unrelated to the fix.
> 
> Suggested-by: Randy Dunlap <rdunlap@infradead.org>
> Suggested-by: Shuah Khan <skhan@linuxfoundation.org>
> 
>   Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst b/Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst
> index 46595b788d3a..2ec0249e37b6 100644
> --- a/Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst
> +++ b/Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst
> @@ -15,15 +15,19 @@ The driver provides a description of its available events and configuration
>   options in sysfs, see /sys/bus/event_sources/devices/mac_iod<iod>_mac<mac>_ch<ch>/
>   and /sys/bus/event_sources/devices/pci_iod<iod>_pci<pci>/.
>   This driver exports:
> +
>   - formats, used by perf user space and other tools to configure events
>   - events, used by perf user space and other tools to create events
> -  symbolically, e.g.:
> +  symbolically, e.g.::
> +
>       perf stat -a -e mac_iod0_mac0_ch0/event=0x21/ ls
>       perf stat -a -e pci_iod0_pci0/event=0x24/ ls
> +
>   - cpumask, used by perf user space and other tools to know on which CPUs
>     to open the events
>   
>   This driver supports the following events for MAC:
> +
>   - cycles
>     This event counts MAC cycles at MAC frequency.
>   - read-count
> @@ -77,6 +81,7 @@ Examples for use with perf::
>     perf stat -e mac_iod0_mac0_ch0/ea-mac/ ls
>   
>   And, this driver supports the following events for PCI:
> +
>   - pci-port0-cycles
>     This event counts PCI cycles at PCI frequency in port0.
>   - pci-port0-read-count

-- 
~Randy


  reply	other threads:[~2025-09-26  5:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-26  0:39 [PATCH v2] " Gopi Krishna Menon
2025-09-26  3:27 ` Randy Dunlap
2025-09-26  4:36   ` [PATCH v3] " Gopi Krishna Menon
2025-09-26  5:14     ` Randy Dunlap [this message]
2025-09-26  6:33     ` Bagas Sanjaya
2025-09-26  9:07     ` Koichi Okuno (Fujitsu)
2025-09-26 13:39     ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32e30b90-c089-4b96-9573-3c57a4e66a8e@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=corbet@lwn.net \
    --cc=david.hunter.linux@gmail.com \
    --cc=fj2767dz@fujitsu.com \
    --cc=krishnagopi487@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=will@kernel.org \
    --cc=yangyicong@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®