From: Liam Merwick <liam.merwick@oracle.com>
To: Michael Roth <michael.roth@amd.com>, kvm@vger.kernel.org
Cc: linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org,
pbonzini@redhat.com, seanjc@google.com, jroedel@suse.de,
thomas.lendacky@amd.com, ashish.kalra@amd.com,
pankaj.gupta@amd.com, dionnaglaze@google.com, huibo.wang@amd.com,
liam.merwick@oracle.com
Subject: Re: [PATCH v3] KVM: Introduce KVM_EXIT_SNP_REQ_CERTS for SNP certificate-fetching
Date: Fri, 10 Jan 2025 08:58:17 +0000 [thread overview]
Message-ID: <32ed551f-d499-47fe-8f76-f80cb1513d9a@oracle.com> (raw)
In-Reply-To: <20241218152226.1113411-2-michael.roth@amd.com>
On 18/12/2024 15:22, Michael Roth wrote:
> For SEV-SNP, the host can optionally provide a certificate table to the
> guest when it issues an attestation request to firmware (see GHCB 2.0
> specification regarding "SNP Extended Guest Requests"). This certificate
> table can then be used to verify the endorsement key used by firmware to
> sign the attestation report.
>
> While it is possible for guests to obtain the certificates through other
> means, handling it via the host provides more flexibility in being able
> to keep the certificate data in sync with the endorsement key throughout
> host-side operations that might resulting in the endorsement key
> changing.
>
> In the case of KVM, userspace will be responsible for fetching the
> certificate table and keeping it in sync with any modifications to the
> endorsement key by other userspace management tools. Define a new
> KVM_EXIT_SNP_REQ_CERTS event where userspace is provided with the GPA of
> the buffer the guest has provided as part of the attestation request so
> that userspace can write the certificate data into it while relying on
> filesystem-based locking to keep the certificates up-to-date relative to
> the endorsement keys installed/utilized by firmware at the time the
> certificates are fetched.
>
> Also introduce a KVM_CAP_EXIT_SNP_REQ_CERTS capability to enable/disable
> the exit for cases where userspace does not support
> certificate-fetching, in which case KVM will fall back to returning an
> empty certificate table if the guest provides a buffer for it.
>
> Signed-off-by: Michael Roth <michael.roth@amd.com>
Reviewed-by: Liam Merwick <liam.merwick@oracle.com>
Tested-by: Liam Merwick <liam.merwick@oracle.com>
> ---
> Documentation/virt/kvm/api.rst | 93 +++++++++++++++++++++++++++++++++
> arch/x86/include/asm/kvm_host.h | 1 +
> arch/x86/kvm/svm/sev.c | 43 ++++++++++++---
> arch/x86/kvm/x86.c | 11 ++++
> include/uapi/linux/kvm.h | 10 ++++
> include/uapi/linux/sev-guest.h | 8 +++
> 6 files changed, 160 insertions(+), 6 deletions(-)
>
next prev parent reply other threads:[~2025-01-10 8:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 15:22 [PATCH v3 0/2] SEV-SNP: Add KVM support for SNP certificate fetching Michael Roth
2024-12-18 15:22 ` [PATCH v3] KVM: Introduce KVM_EXIT_SNP_REQ_CERTS for SNP certificate-fetching Michael Roth
2025-01-08 20:43 ` Dionna Amalie Glaze
2025-01-10 8:58 ` Liam Merwick [this message]
2024-12-18 15:52 ` [PATCH v3 0/2] SEV-SNP: Add KVM support for SNP certificate fetching Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32ed551f-d499-47fe-8f76-f80cb1513d9a@oracle.com \
--to=liam.merwick@oracle.com \
--cc=ashish.kalra@amd.com \
--cc=dionnaglaze@google.com \
--cc=huibo.wang@amd.com \
--cc=jroedel@suse.de \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=pankaj.gupta@amd.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®