From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7208BC433EF for ; Wed, 22 Sep 2021 14:10:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C5736115A for ; Wed, 22 Sep 2021 14:10:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233133AbhIVOL7 (ORCPT ); Wed, 22 Sep 2021 10:11:59 -0400 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:37866 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235346AbhIVOL5 (ORCPT ); Wed, 22 Sep 2021 10:11:57 -0400 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 96407402DB for ; Wed, 22 Sep 2021 14:10:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1632319826; bh=iNMj8PKQUNev51ZEKfGzcirSHdmbfqXjl4kbh441iow=; h=Subject:To:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=XIjct1eOxjWAAz9RTg5isOahsbjov4ldN2WntrN07bMsLylHSeSOWuCbpq97nkAyJ JWuQDArDUb/segs/QRPiDROrQ03vjl4iNJtgZsDaq0Si5OTh/T4V9f8nD4fCRk7HvL 5BFOk2CivOgunHCUm9hDfci0l95pJckPRsTKytb+8UgEGoPWC4pGpqwBxX9GboZnQt jE5VcRU96YFTC0MU2cHz5OYq5Ha3f0VY7A0YPy3ysm7Lm0Cr2j+KPn9rFMSwm91jAs 4yfSphu8m9zq7qBFqU5/zv14W9TcINE6CXd4wHaM4T5PxaXTraMvY1+/+7rUT4a4BZ YHhiRr2jQkKvA== Received: by mail-ed1-f69.google.com with SMTP id l29-20020a50d6dd000000b003d80214566cso3157466edj.21 for ; Wed, 22 Sep 2021 07:10:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iNMj8PKQUNev51ZEKfGzcirSHdmbfqXjl4kbh441iow=; b=ulgRM50TSiJ7jtd9aw7xrnhr4vWDJJdkywgO0rYeNlsks0j1KQDDdVV+xcGmjZgujw He0istrY+wticAco/FQ9FrqLUzLdxXx1j9pwj04xeB0mPIlfhuPPOG99k3rYypQ3uuI5 xI+HQ86ij60OUcgG5Wb9QDS27QqE+ctjmjCy4lm/26e+ptJA89pzfQpgzsoTpOGL0aO0 0ZysJyna4oyogxPb9nMRkDOYIgiKvUYnAOddXfywYE45yVYUp1pCqUq0kmRkjeO35gS6 FYWel+nDa+dno+F8YToTW7yZ9GaHHwph8z/vHXVvL1APzzl8RIBti4QP1Q0jw9FLJWdQ HsZA== X-Gm-Message-State: AOAM531TrbwOYMm9xBLOZSdAYzk5MxdRVWCNhRFQdM3IiiJVYZrrxiTp 4y19qVf+vxtxIwc8HUYCQJhgjH7Q0igxEu2fSOtFDSvnTBQOY3QYHGYfzQvJqnhdDLnpoN0D+vQ xLjjjN7OcI/j6tTH3x63x83YgP9lhNVM31k3U/ps5mw== X-Received: by 2002:a05:6402:64e:: with SMTP id u14mr43168069edx.184.1632319823968; Wed, 22 Sep 2021 07:10:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzpsp4VMavM5vx191UsZKZeFxUGy6aFJnlOU4UVgDRR9QT2MJHyEjJZbwqlRc/RX1AObv+5Hg== X-Received: by 2002:a05:6402:64e:: with SMTP id u14mr43167991edx.184.1632319823063; Wed, 22 Sep 2021 07:10:23 -0700 (PDT) Received: from [192.168.0.134] (lk.84.20.244.219.dc.cable.static.lj-kabel.net. [84.20.244.219]) by smtp.gmail.com with ESMTPSA id i6sm1112859ejd.57.2021.09.22.07.10.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Sep 2021 07:10:22 -0700 (PDT) Subject: Re: [RESEND PATCH 1/2] powerpc/powermac: add missing g5_phy_disable_cpu1() declaration To: Christophe Leroy , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Rob Herring , Frank Rowand , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20210922084415.18269-1-krzysztof.kozlowski@canonical.com> From: Krzysztof Kozlowski Message-ID: <32efc1e8-7c00-3550-4a39-af343397013a@canonical.com> Date: Wed, 22 Sep 2021 16:10:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/09/2021 15:52, Christophe Leroy wrote: > > > Le 22/09/2021 à 10:44, Krzysztof Kozlowski a écrit : >> g5_phy_disable_cpu1() is used outside of platforms/powermac/feature.c, >> so it should have a declaration to fix W=1 warning: >> >> arch/powerpc/platforms/powermac/feature.c:1533:6: >> error: no previous prototype for ‘g5_phy_disable_cpu1’ [-Werror=missing-prototypes] > > > While you are at it, can you clean it up completely, that is remove the > declaration in arch/powerpc/platforms/powermac/smp.c ? > Sure, I'll send a v2. Thanks for pointing this out. Best regards, Krzysztof