From: Chris Lew <quic_clew@quicinc.com>
To: Bjorn Andersson <quic_bjorande@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: <linux-arm-msm@vger.kernel.org>,
<linux-remoteproc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] rpmsg: glink: Introduce packet tracepoints
Date: Wed, 7 Aug 2024 17:17:17 -0700 [thread overview]
Message-ID: <32f201b8-c0c6-42cd-b9f7-8a8abb33eccc@quicinc.com> (raw)
In-Reply-To: <20240805-glink-tracepoints-v1-3-a5f3293fb09e@quicinc.com>
On 8/5/2024 8:56 PM, Bjorn Andersson wrote:
> Introduce tracepoints to allow tracing the GLINK packets being exchanged
> with other subsystems. This is useful for debugging both interaction
> with remote processors and client driver issues, as well as tracking
> latency through the communication stack.
>
> Channel events are traced with both local and remote channel ids, as
> well as the textual representation when possible. The channel ids are
> useful when matching traces with traces from the firmware side logs,
> while the textual representation is necessary to identify channels when
> we're starting to trace an already running system.
>
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> ---
> drivers/rpmsg/Makefile | 1 +
> drivers/rpmsg/qcom_glink_native.c | 96 ++++++++-
> drivers/rpmsg/qcom_glink_trace.h | 406 ++++++++++++++++++++++++++++++++++++++
> 3 files changed, 501 insertions(+), 2 deletions(-)
>
Reviewed-by: Chris Lew <quic_clew@quicinc.com>
next prev parent reply other threads:[~2024-08-08 0:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 3:56 [PATCH 0/3] rpmsg: glink: Introduce tracepoints Bjorn Andersson
2024-08-06 3:56 ` [PATCH 1/3] rpmsg: glink: Tidy up RX advance handling Bjorn Andersson
2024-08-07 23:42 ` Chris Lew
2024-08-06 3:56 ` [PATCH 2/3] rpmsg: glink: Pass channel to qcom_glink_send_close_ack() Bjorn Andersson
2024-08-07 23:42 ` Chris Lew
2024-08-06 3:56 ` [PATCH 3/3] rpmsg: glink: Introduce packet tracepoints Bjorn Andersson
2024-08-08 0:17 ` Chris Lew [this message]
2024-08-13 1:50 ` [PATCH 0/3] rpmsg: glink: Introduce tracepoints Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32f201b8-c0c6-42cd-b9f7-8a8abb33eccc@quicinc.com \
--to=quic_clew@quicinc.com \
--cc=andersson@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=quic_bjorande@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®