From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F5E22877DE for ; Tue, 23 Jun 2026 16:47:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.7 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782233253; cv=fail; b=R7zxvN0NgPyzDRIb78TDInPon50FoCYmVEsPDBIDVAaeZYrdgafpH7SWsuKwy0zp4U9+lXZ2WfQ0nVae/dMrzOukKmyGBRJwnoOlmtjGqprybcyq95r815JOTTBpPCz1BNuZt1s0j1uuYMWERuumqRcalvnevKv/ZNLnIBhVM/E= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782233253; c=relaxed/simple; bh=M2oaaodECR0q953653s173+78qCShj8f68TNkSGcQpg=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=ttNYvYVQYahdsnf1I+y6GZuaYmtgEZTSwosilP78hxK6f8m7vv8rnAmhg81W3KHYta/kc01MQi4d5kCA2RwGahRE60Uxtqvh1iEpg3xjgXo2t5joSDRSVNdH0Fe7BVNVQank1/3Jd+lJ2FCOogk4hHcKM6k3KR3I1NEvqxmJAk4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=U84qZF+R; arc=fail smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="U84qZF+R" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782233252; x=1813769252; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=M2oaaodECR0q953653s173+78qCShj8f68TNkSGcQpg=; b=U84qZF+RpUi1KyEHnk9UN3ZwiZvuguh2PXKWA+O1DKnX52O6/moePhj8 GRcxHtVb2dbZNWoeXAxDGaWVRk12T2OH500bGOkaslGtnf1NgHKU4WfBa 0rPBNZvFx8ONgYns/+NBUvw9WrKLUt7UBT41t3ripg0sE+0aka/yzwRgD DhEua9uIZ2J9dk1fFcuChNe9ZilGeLbgz3CYtnzbf8B9g4QVyd8X2TVHv /tDPdweeBQBM1B+1G6NLfnMDgsU7ZRQho5/gJXVnHuu/vePt6LtDRkZjP klgnqgNnOljQRYkvTdw0BmNhJBAsKAYaKNo+0NYSz5UUptVJ6GyJWfk3X A==; X-CSE-ConnectionGUID: ML5yJqr+Q6iY6/JzWMUoPw== X-CSE-MsgGUID: QcBJNPqzRpmGzS2eRieWKw== X-IronPort-AV: E=McAfee;i="6800,10657,11826"; a="108524511" X-IronPort-AV: E=Sophos;i="6.24,221,1774335600"; d="scan'208";a="108524511" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2026 09:47:31 -0700 X-CSE-ConnectionGUID: zz/YJCyHR9+xCjDZOp0Qaw== X-CSE-MsgGUID: qeAaJjs0T5esvz3yXAFIQw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,221,1774335600"; d="scan'208";a="245195864" Received: from fmsmsx901.amr.corp.intel.com ([10.18.126.90]) by fmviesa006.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2026 09:47:31 -0700 Received: from FMSMSX902.amr.corp.intel.com (10.18.126.91) by fmsmsx901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 23 Jun 2026 09:47:31 -0700 Received: from fmsedg902.ED.cps.intel.com (10.1.192.144) by FMSMSX902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Tue, 23 Jun 2026 09:47:31 -0700 Received: from BN8PR05CU002.outbound.protection.outlook.com (52.101.57.16) by edgegateway.intel.com (192.55.55.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 23 Jun 2026 09:47:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tN4aiPh4xpTrfvbrbEIXO8fO79Hw72vryzuVKOGOHL9PkX+ptG1iKaMA98IhP3YkBNhJnT/JPpi6QMd+VTazFpj3GAht1QfrGBY1Zd+VurvEG7pbvqzOsfcBVzgFDbVY46uEP8la8/nkfEZ9WYce2vCtwmfINREK5XgbUpQxCGBLFPp0EL0MrMN/HZpCKuh5SDO3dRHpOlQY6Wjc9i4FiwEZTW0B9ZU6D01JdBVcMmHQCm6Y9ThWTCHioKtidY+B1/p6PBHD6VeufUdi68w35Jhxn5pEeuG0sSjcTSTopnhlyD5fptKHibZeAakKHaJEuSPl4chFgUlMeoUtsurgeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H27kBEKcJgvlqZfWYHwGsnfyTQuu1SqPLttNBPZJ6/k=; b=Mhmnz8l+nvVNyrvPOEjbw8MOAjr7zsGTADwCv+FhAKBu1fzakbQft4RqQZ4R8onGTkXr/LAVkdJMvmEuslYvqdAnv6d2WWDM2aw+bpMiLkqSQJl+q/pRoUykZf/O4ar/FBCHa8AvBxaJngs3EMpArwucmq6s0nt2d7s7xy239+Ab1BFGtaCJZ4RrU/+Qp0+l/KzbHBlOfW59X6ycAPbmqANJHaOLlfLK3d0J4pKVKJEbPZKkQ5a3Yc+oZ2td16HICsEQ+0z9f7zx5yywcd/hcyTq7zhf8nhS78+6cmwA1t3ps/cLJaakvLjWuTkyKWigLlVbT5dPJaWO4PUKU4teiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ2PR11MB8370.namprd11.prod.outlook.com (2603:10b6:a03:540::20) by CY5PR11MB6391.namprd11.prod.outlook.com (2603:10b6:930:38::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.159.12; Tue, 23 Jun 2026 16:47:28 +0000 Received: from SJ2PR11MB8370.namprd11.prod.outlook.com ([fe80::b6cf:ce77:3cdf:7cc]) by SJ2PR11MB8370.namprd11.prod.outlook.com ([fe80::b6cf:ce77:3cdf:7cc%5]) with mapi id 15.21.0139.018; Tue, 23 Jun 2026 16:47:28 +0000 Message-ID: <32f450b0-9357-42b6-b3c6-637bc99c5789@intel.com> Date: Tue, 23 Jun 2026 09:47:26 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/6] x86/resctrl: Rename prev_msr to prev_mon_val To: "Chen, Yu C" CC: , , , , , , , , , , , , References: <2e9bd6a1a012b937e9205908ab6bbb09a21e0f71.1781332698.git.yu.c.chen@intel.com> <3ee018f0-689d-4175-bfd2-dda62a4aa45b@intel.com> <4ee138d9-3d42-4452-a24d-b183690836ea@intel.com> From: Reinette Chatre Content-Language: en-US In-Reply-To: <4ee138d9-3d42-4452-a24d-b183690836ea@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR04CA0185.namprd04.prod.outlook.com (2603:10b6:303:86::10) To SJ2PR11MB8370.namprd11.prod.outlook.com (2603:10b6:a03:540::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR11MB8370:EE_|CY5PR11MB6391:EE_ X-MS-Office365-Filtering-Correlation-Id: d2def75d-40c5-4fd2-6875-08ded1471c26 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|23010399003|1800799024|56012099006|11063799006|4143699003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: AtBqDUpsQdA80rxUITWigEBVYapKj15aXcq8cniRhJChU1W/O1aTFgraoy1Dc4+YVYUhYPYT7jwls6/XjFLYvsmNJB7HnSyz92NrxfodJnK4gcbU471+FnEgAFBcem73ZsY5B2N84py0NWqM0R8N9hMcHD2TE3P/kYYx4Bb+tP1SEtKWAoIJTLZcfSSSUXu0HCcq71O9hHn9eu9fjh8Ax8BLgdrFyzEe4wN1OoeBVBsB8D5JRtQ8DCkz/+63oXIY1vNTmXbwEWva41AOaiHqUBSn2d0N4mfhetrcePKz11z7yQaEuKpVFl+8L14OsT4Z0R5ZaqgoiJZjdociXo2XH/82CVyvWiEpgtzxmjzwoAowUfrd6J5CwzTEvRGoH+lKKgrvN+bYLiawObzyQFCoqgFG7h3HQIAGjGHq4hJ02eJKYXe2J0BBCXXSfNaf69uEGDkM+tf1aMxTRzCkjZIP7fdunXf+q4xz3b8H0gw5qNXefd6GtZJkHok8xZ6cBRkSbOe69owCNJNRFBrkS9q0jwviwyX4/jf55yelasWryBusRGRC1ywgHtomhHL3d68fO6IQrp6pzQVJ5ty7h9Oa0Y0iKP3jZ7B4EedmMRLG8ATn1Mr+GV3bndderwDmMSUQCUxmv5kxADo2AIWz3xOQSY01+C2NuDLcg4QOts1FyTc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR11MB8370.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(23010399003)(1800799024)(56012099006)(11063799006)(4143699003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2poVTRKaDI4cjdIZDF1Q1lVOE8wdGprLzQ3QUNXK3BjMGhWd2lxZGo3aVNt?= =?utf-8?B?bmFldWhGa1dZZmN5RmZHcm1kZDRnK0RHWXdkUnFRWnc2elNOMVlja043bVRV?= =?utf-8?B?eHNXVFd3ZnE5aXdoWUxLNmNNdCtwUllENExEVWtvUGtJUFhaR2tLY1hVaTlJ?= =?utf-8?B?V3hjVlREenorRy9TeWdENDdaUk43S0JJUnpWSFZ6RFhOOGE1YldaN3lNZXJ3?= =?utf-8?B?TFRzbXY5UlFmM1lhcnY2eEU1S3U5OGtEaERqUnc2UjU3SCtpMkNtQTlzdmg1?= =?utf-8?B?QWx5TEhHZzJxd2xFeVZlQzhTdElUY1kyYkZ5NHl0OFhrNjNRNThTaWlrUkto?= =?utf-8?B?RW5EMUF6bkZmNzI3OWpqZXF4RHpoZDFUNkVNVmlOY3FvZ05iMkRTR29mQVB6?= =?utf-8?B?RDUvMGpwcklxUDhyR2dXU25pQzhVaDgwamFGdGxneGtmVm5yZW1QN0s3eEJh?= =?utf-8?B?Ui9McVFrcGhHVkYvZU5CRndsL1oyWVFFQ3ZveUh6NElkUmtUUWEzcElQM29u?= =?utf-8?B?a2dkcmdNd25yZ1huS2VJMUFFUHRXUlZFdFNKOGZScUcrTnQyQ0VpazIxY2tK?= =?utf-8?B?UXFZWEtqT0w0QWxHMjR2LzBaZUc4ZytqYmRxY3JFRFFjSmE0L1R4cmJQWVVZ?= =?utf-8?B?VEhIMWNMTFRNcERmdkhPa3EzQVpwT2Z4S0FIM1Y0NURyUkpwLy9VT21aLy9v?= =?utf-8?B?bWNtc2tXUWNmSG8xcHRJVjlaS0VIckpVOFVxWUFlMkQ4cWliZWQvR1hPZ1RT?= =?utf-8?B?WE5xR1d0bm5HL2pxMTVYZHdCK3ZTbStrL1o0c2M0dll2aHU4blVZQnk0Y1hz?= =?utf-8?B?NlgxV1orbFBLZ1Z6cXd0SDJwaU9EZkN4Y29vaGRYKzc1aFBoSjNJN3lCajNT?= =?utf-8?B?dk1WT1daalNNYzE4d1RGazQ3RFd1MXllQzllZlE0Tlkxd1gxa3ByZTNTb0xj?= =?utf-8?B?dXR1Mk9xRVQ4am9VbFFKZS93cTFlM3dOQTVjV241bjhtWUtRaG1DVHM5c1lO?= =?utf-8?B?WjhBNEQ1ajJnUWxia3NKMWplb2wxSlpCK1F5UW5qc0toeHBqd3R0Qys4OU52?= =?utf-8?B?SDhYV2ZKSi9tL3hkUXkxUmx6VGViMlFiVHRrcHFlSDltaHRPRzFKTHQxajNG?= =?utf-8?B?ZkZ1ZmRFRGppMWtvcldTc1k1ZHI1Ylg1QTdHSVNlckRkYll4WUxOQzFoKzVs?= =?utf-8?B?Q1FzSVE0cXlJbVhoN0hTaFRaYk91WUIvK2dxaFdXd3dGbjJGWTJQR0NGR09u?= =?utf-8?B?bm1vWnFKaFFNeFJJakQyTmlMSTJxc214dVlCTE12dGRnUWM2N2tKWUs3T0lm?= =?utf-8?B?SzlmNVF4Vkl4VThUUGFpSEcvZjBjMjJNcEk0OEdJcU1CYk84TE1SOFF2bm1K?= =?utf-8?B?RXJsOHRicVduOSt4Ym9NaTBJRU5IKzFFeWtOVjBsNWdSWjlPRGE0N1NkeWdH?= =?utf-8?B?eFpTdzlhUUlkbjhVQk9DZ2pZdVE5Y0JvVERjQk84cmNKcEdFdkdiNUN3eTZT?= =?utf-8?B?VXNEZVZESHU0RFhQMTFtbUJWSXloSDlYYmRFUHQwUG9UUTNZekRSbWFubEFz?= =?utf-8?B?VW11VE5vSDdVaHZSdC9kNk5YM1g1Rk1kU2ZRZVdXeVQ1b2dETG5uSzVLU1Bm?= =?utf-8?B?Tnc5T3lEUW8xMXA5WDJGRVkxV3JtQS8rVE9uYVc5S3ZIS2RWd1NqNDFyZ3lz?= =?utf-8?B?cWVqT0YxZkJ3R2o1RGEyNTdqZ0Nxc05uTE1VWFc4SG5NaDR4bUtHSk9INmJO?= =?utf-8?B?aG4vZFQyM3dkbnJwV0xIYjREQTZNZkcxVDZSbXFWbG54Vy9TUExQZVZMY0Iz?= =?utf-8?B?a1FTdm1obmRYZTFkR3lpQ0xuOERJRnFtZlJyamxiZWsxVHAwbDNhcEdGSWx0?= =?utf-8?B?RHRxbHNEZC9kUFVlUEJXSkNMaVJZRXZ5UmJnSFpxWlc4aWszZ2cvN0FFTS9h?= =?utf-8?B?NHVQcVh2UzdIMWRqU3hEbmZWMldoVlBRR2NnMmFISHB5aWZiWU00eU1ZMVR3?= =?utf-8?B?WGR6NDlpVXVYR0NsTHpFb2VpUURWVnpWZzBzVWRGUVlrNHFWUkpHbU1xNzl6?= =?utf-8?B?UHdPbWsrS3R1S2JsRExOMHl1VXFtOTQyVlRVakdJRkMyUzYrUklLU25WaldT?= =?utf-8?B?V1JwYkhabStaTEV3b0NBTURnZXEveXlOemFJRWFhUkwzRnljNDl5UXJNTmZ5?= =?utf-8?B?YWpPTmlad3lEZzhQS2tRYkd3dXNoSHFaNGw3T0MxZW5oQ1RoOEJaeVFaOWVZ?= =?utf-8?B?a0tNWDREUGFjREFETEMzek1IaC9wSkpoUjhRTnN6WFU0K0VjM1REeXJicUZx?= =?utf-8?B?RWZrT0t4a0xKL1dwL3YwNDhxRFpnSnFUQWd5ODkrVGlJN3BTK3RmbExpSGxY?= =?utf-8?Q?FFb1MZcysRuNDMVs=3D?= X-Exchange-RoutingPolicyChecked: HBBLrE/Xg2FPzEfDVBBwYG6diGydEirVRSncxU1x5j8CnO21hGAnLpkzATKibmJs8c8DN88EQT4KEOcsb6unzlRRniqmKD8z2h3OFSmG3E/lF+mWoqr/RdbMKaqXqGP9q/+w09J4vBQMF+h9barK0Dgi/iVUDVCbJvzA881seI4JyzwQVnW7SxSLlv6XVtcAoNEv1/g+VLLzsOd1XZE8OmVWXKLqTK7qA36Uky+F1P+yCQzi+D00VLifLL+Loy5BtP4tgAKEeqIuydhKLppiBpx5zn4AnzZ3ibJpByaV4sBiJO4mdDL6G4mVA+uvhAXbMSdsGsE9mF9p6MaxfazwOQ== X-MS-Exchange-CrossTenant-Network-Message-Id: d2def75d-40c5-4fd2-6875-08ded1471c26 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB8370.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2026 16:47:27.9741 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TDCvK2KNNoezyRXPhIpnBEVSh23oYsbMEPokoYMzZELVLvhl9ulRfh+KP2iJ9LwSpc9aBbFgnvQuWtBkvxrcpgNmFiT30rFkuOkoZ0mUgW4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6391 X-OriginatorOrg: intel.com Hi Chenyu, On 6/23/26 12:48 AM, Chen, Yu C wrote: > On 6/23/2026 5:29 AM, Reinette Chatre wrote: > Would the following be appropriate? > > x86/resctrl: Replace "msr" in monitoring data identifiers > > Monitoring counter values are currently obtained via MSR and many > identifiers involved in processing these values contain "msr" > as part of their names, for example "prev_msr" and "msr_val". > > The ERDT ACPI table describes MMIO registers for monitoring access. > A subsequent patch adds MMIO-based L3 occupancy reads. Rename "msr" Please drop the "A subsequent patch ...". Apart from it resembling the dreaded "this patch", once it is merged the intended meaning is lost. As an alternative the second paragraph can be: The ERDT ACPI table describes MMIO registers for monitoring data access. Rename "msr"-based identifiers to be interface-agnostic to support their upcoming use for MMIO-read values. No functional change. > based identifiers to interface-agnostic names so they remain accurate > as monitoring values may no longer originate exclusively from MSR. > > No functional change. Reinette