From: Jens Axboe <axboe@kernel.dk>
To: Oleksandr Natalenko <oleksandr@natalenko.name>,
linux-kernel@vger.kernel.org
Cc: linux-block@vger.kernel.org, Ming Lei <ming.lei@redhat.com>,
Christoph Hellwig <hch@lst.de>,
Laurence Oberman <loberman@redhat.com>,
Paolo Valente <paolo.valente@linaro.org>,
David Jeffery <djeffery@redhat.com>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH] block: increase BLKCG_MAX_POLS
Date: Sat, 17 Jul 2021 13:07:09 -0600 [thread overview]
Message-ID: <32f6b089-46fa-55ec-ce7c-88da7e224728@kernel.dk> (raw)
In-Reply-To: <20210717123328.945810-1-oleksandr@natalenko.name>
On 7/17/21 6:33 AM, Oleksandr Natalenko wrote:
> After mq-deadline learnt to deal with cgroups, the BLKCG_MAX_POLS value
> became too small for all the elevators to be registered properly. The
> following issue is seen:
>
> ```
> calling bfq_init+0x0/0x8b @ 1
> blkcg_policy_register: BLKCG_MAX_POLS too small
> initcall bfq_init+0x0/0x8b returned -28 after 507 usecs
> ```
>
> and BFQ is non-functional.
>
> Increase BLKCG_MAX_POLS to allow space for everyone
LGTM, just needs a:
Fixes: 08a9ad8bf607 ("block/mq-deadline: Add cgroup support")
in there too, I'll add it.
--
Jens Axboe
prev parent reply other threads:[~2021-07-17 19:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-17 12:33 Oleksandr Natalenko
2021-07-17 19:07 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32f6b089-46fa-55ec-ce7c-88da7e224728@kernel.dk \
--to=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=djeffery@redhat.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=ming.lei@redhat.com \
--cc=oleksandr@natalenko.name \
--cc=paolo.valente@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®