From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
To: Zhenzhong Duan <zhenzhong.duan@oracle.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: pbonzini@redhat.com, rkrcmar@redhat.com,
joao.m.martins@oracle.com, mtosatti@redhat.com
Subject: Re: [PATCH v2 0/4] misc fixes on halt-poll code both KVM and guest
Date: Wed, 6 Nov 2019 12:05:55 +0100 [thread overview]
Message-ID: <32fce2c2-9056-b4ab-1bfb-3f4b69f30da6@intel.com> (raw)
In-Reply-To: <1573031332-2121-1-git-send-email-zhenzhong.duan@oracle.com>
On 11/6/2019 10:08 AM, Zhenzhong Duan wrote:
> This patchset tries to fix below issues:
>
> 1. Admin could set halt_poll_ns to 0 at runtime to disable poll and kernel
> behave just like the generic halt driver. Then If guest_halt_poll_grow_start
> is set to 0 and guest_halt_poll_ns set to nonzero later, cpu_halt_poll_us will
> never grow beyond 0. The first two patches fix this issue from both kvm and
> guest side.
>
> 2. guest_halt_poll_grow_start and guest_halt_poll_ns could be adjusted at
> runtime by admin, this could make a window where cpu_halt_poll_us jump out
> of the boundary. the window could be long in some cases(e.g. guest_halt_poll_grow_start
> is bumped and cpu_halt_poll_us is shrinking) The last two patches fix this
> issue from both kvm and guest side.
>
> 3. The 4th patch also simplifies branch check code.
>
> v2:
> Rewrite the patches and drop unnecessory changes
>
> Zhenzhong Duan (4):
> cpuidle-haltpoll: ensure grow start value is nonzero
> KVM: ensure grow start value is nonzero
> cpuidle-haltpoll: ensure cpu_halt_poll_us in right scope
> KVM: ensure vCPU halt_poll_us in right scope
>
> drivers/cpuidle/governors/haltpoll.c | 50 ++++++++++++++++++++++++-----------
> virt/kvm/kvm_main.c | 51 ++++++++++++++++++++++++------------
> 2 files changed, 68 insertions(+), 33 deletions(-)
>
Please resend the series with CCs to linux-pm@vger.kernel.org, thanks!
prev parent reply other threads:[~2019-11-06 11:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 9:08 Zhenzhong Duan
2019-11-06 9:08 ` [PATCH v2 1/4] cpuidle-haltpoll: ensure grow start value is nonzero Zhenzhong Duan
2019-11-06 9:08 ` [PATCH v2 2/4] KVM: " Zhenzhong Duan
2019-11-06 9:08 ` [PATCH v2 3/4] cpuidle-haltpoll: ensure cpu_halt_poll_us in right scope Zhenzhong Duan
2019-11-06 9:08 ` [PATCH v2 4/4] KVM: ensure vCPU halt_poll_us " Zhenzhong Duan
2019-11-06 11:05 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32fce2c2-9056-b4ab-1bfb-3f4b69f30da6@intel.com \
--to=rafael.j.wysocki@intel.com \
--cc=joao.m.martins@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=zhenzhong.duan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®