From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760984AbcINKXc (ORCPT ); Wed, 14 Sep 2016 06:23:32 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:51900 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757915AbcINKX1 (ORCPT ); Wed, 14 Sep 2016 06:23:27 -0400 From: Arnd Bergmann To: Peter Ujfalusi Cc: ulf.hansson@linaro.org, tony@atomide.com, kishon@ti.com, linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mmc: omap_hsmmc: Initialize dma_slave_config to avoid random data Date: Wed, 14 Sep 2016 12:23:20 +0200 Message-ID: <3300411.hNyGPzA0ak@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20160914101048.1061-1-peter.ujfalusi@ti.com> References: <20160914101048.1061-1-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:crptyv92A7IYvbUx6Fq2XYE3tV6PqeNGU+pPDmk5xVvEuHNFw5q 3LG9ybqx9rQ2zM83zxMCNgigT1YrgVP1efhEIhlzsNP9coEjcFXxoGamTQQnrMLiiF/Iciu etiupuh7Qm8cChlQdDDDSeXZmDgwzXilUyjxnwy5NmzPxB0EL4KqKWTKC8puAlns+W7ylph 0XP3Ban5/8AC5piPHwhOA== X-UI-Out-Filterresults: notjunk:1;V01:K0:VAT4mifgU1k=:DbrkP3gpDANwSA8LscpQeJ B83Wb9ggxDAp/XPjUDQjx3uf6Z1a5dh6/6dzTtOTcn/212+UALVr7f+xNjCXKVH7nOqXab04q CwaTWPoG/VabmPaKnQA/APRz6G3QOLGsJp5Fn64qL6+keLql4VhEyP0NcIbRaWrvfsN1tjLUj myUkEv8mEdcOoCuBKsXyH6C8HnSUYicjFaUfUafgC0hDC3BtKJ1mYn7LUuMaDunTM+9pNMixt 2pbfSrEbff7FjW5iHN1aANxGixcAmfFf3QOfDe+dqzGPVDdxmaQGZFso56z3JSuIFXjdi07TG WgWNR0G+KeCFyVM+4jSW1YqtpBL3tazcCdzsoL69HKudh7HQCCl2Xayljr0slH7N8LpBe11bV FZIXrWoa0fHVPg4lbrZR+JSwftUYdzE+ItV5nfgy6lJ15PtugYK4JY9FCPWqfZuQvkp9pn3QJ o4+UE0TAWE/DnZhbdKOChHWkxg2Ltv89etxvZ/i+Zg7GBcBXaAK/wjDjcg4+ZHiRZ7nyn3d8q q3Al24QaUKQn2Vw2WdK10b2djYLt+PpL4VRUJVZaz7sW9Zxq1RrVRAmEGDGeHnG9ebbtsNESn sRSGXbv/NKOWt3ILbXxmHRB9SGRAvbuCWWluPknRF2Nlbx5df+Rng+0phHDMgHB2B269BjWAX DyQvuvnhdIvjkor7PyHtbLqGgb1cBin9qnIoqAmn6fT5mERH97aqn9WVPq9v4UTWcIFr60cvh DfTJMuiiDjh3J853 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, September 14, 2016 1:10:48 PM CEST Peter Ujfalusi wrote: > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > index 24ebc9a8de89..0a5640156159 100644 > --- a/drivers/mmc/host/omap_hsmmc.c > +++ b/drivers/mmc/host/omap_hsmmc.c > @@ -1409,7 +1409,7 @@ static int omap_hsmmc_pre_dma_transfer(struct omap_hsmmc_host *host, > static int omap_hsmmc_setup_dma_transfer(struct omap_hsmmc_host *host, > struct mmc_request *req) > { > - struct dma_slave_config cfg; > + struct dma_slave_config cfg = {}; > struct dma_async_tx_descriptor *tx; > int ret = 0, i; > struct mmc_data *data = req->data; > This change looks correct and is certainly the simplest solution if you want to get it into v4.8, but generally speaking, I think it would be nicer to combine it with the initialization of the fields: struct dma_slave_config cfg = { .src_addr = host->mapbase + OMAP_HSMMC_DATA; .dst_addr = host->mapbase + OMAP_HSMMC_DATA; .src_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES; .dst_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES; .src_maxburst = data->blksz / 4; .dst_maxburst = data->blksz / 4; }; Arnd