mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Waiman Long <longman@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: "Ridong Chen" <ridong.chen@linux.dev>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	"Michal Koutný" <mkoutny@suse.com>,
	"Shuah Khan" <shuah@kernel.org>,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org,
	"Guopeng Zhang" <guopeng.zhang@linux.dev>
Subject: Re: [PATCH v2 0/3] cgroup/cpuset: Fix some more bugs in cpuset partition code
Date: Tue, 3 Nov 2026 11:46:00 -0500	[thread overview]
Message-ID: <33024a13-9706-486c-aef0-aeeb2193c8ee@redhat.com> (raw)
In-Reply-To: <886a562b52b1c5094142d547a8336457@kernel.org>

On 11/2/26 3:04 AM, Tejun Heo wrote:
>>    cgroup/cpuset: Fix incorrect CPU accounting with parent's
>>      effective_xcpus expansion
>>    cgroup/cpuset: Recompute effective cpumask in update_cpumasks_hier()
>>      after calling update_parent_effective_cpumask()
>>    cgroup/cpuset: Do housekeeping check when isolated child with root
>>      parent may get more xcpus
> Applied 1-3 to cgroup/for-7.4-fixes with the following tags added:
>
>    Reviewed-by: Guopeng Zhang <zhangguopeng@kylinos.cn>
>    Tested-by: Guopeng Zhang <zhangguopeng@kylinos.cn>
>
> Two issues I noticed:
>
> - Three of patch 1's new TEST_MATRIX rows end with A1 as a single-CPU
>    root partition, which has no sched domain, so they fail the ISOLCPUS
>    check when the script runs with -v.
>
> - The comment at the end of the "partcmd_update w/o newmask" block in
>    update_parent_effective_cpumask() still says there is no need to
>    adjust the parent's effective_cpus. Patch 1's new expansion branch now
>    does exactly that.

Thanks for noticing that. Will fix that in the next set of fixes that I 
am working on.

Cheers,
Longman


      reply	other threads:[~2026-11-03 16:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-30 19:06 Waiman Long
2026-10-30 19:06 ` [PATCH v2 1/3] cgroup/cpuset: Fix incorrect CPU accounting with parent's effective_xcpus expansion Waiman Long
2026-11-02  1:28   ` Guopeng Zhang
2026-10-30 19:07 ` [PATCH v2 2/3] cgroup/cpuset: Recompute effective cpumask in update_cpumasks_hier() after calling update_parent_effective_cpumask() Waiman Long
2026-11-02  1:28   ` Guopeng Zhang
2026-10-30 19:07 ` [PATCH v2 3/3] cgroup/cpuset: Do housekeeping check when isolated child with root parent may get more xcpus Waiman Long
2026-11-02  1:30   ` Guopeng Zhang
2026-11-02  8:04 ` [PATCH v2 0/3] cgroup/cpuset: Fix some more bugs in cpuset partition code Tejun Heo
2026-11-03 16:46   ` Waiman Long [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33024a13-9706-486c-aef0-aeeb2193c8ee@redhat.com \
    --to=longman@redhat.com \
    --cc=cgroups@vger.kernel.org \
    --cc=guopeng.zhang@linux.dev \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mkoutny@suse.com \
    --cc=ridong.chen@linux.dev \
    --cc=shuah@kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®