From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBE16C6FD18 for ; Sun, 23 Apr 2023 23:17:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230074AbjDWXOx (ORCPT ); Sun, 23 Apr 2023 19:14:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229476AbjDWXOv (ORCPT ); Sun, 23 Apr 2023 19:14:51 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D92EDE7D for ; Sun, 23 Apr 2023 16:14:49 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-94f59fbe2cbso113750066b.1 for ; Sun, 23 Apr 2023 16:14:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682291688; x=1684883688; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=ZRxPl+Yy6WKstlVVudzzEelVVl+1ufbRFvrSlt7z3z4=; b=kKOr+CR+YJWTPgQArTZ5On01P8r/uh4X01AVj7ePQgsv2jzXHor9eIOpBtj/FQjrur aOR8WGhX9Q3KwgcuzcIwWN7v1ZuPU08XnRWCtxs4wOy4/bfXFxO8qaQENbVeQ82Qk2Ky SSPP+FcMP0CnjpdkhqImCFkMpduo8JwpWB2KP5PZ+5qJ4aRGFyA1XBO4mVtPkeHAXEyt iQ6qKBBK++b9EpEM5HBx4GOGkyL1uwPgXW5Qfkb0EnnkdRYF40xhxc/a9aLxU91YVcV1 UHc376JVSTHGvFpS89KVvxkTlrsW/kDGqgKoLTlC4HxnOWvb6VUxGeBy4RAoyMDlBlhH nFuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682291688; x=1684883688; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZRxPl+Yy6WKstlVVudzzEelVVl+1ufbRFvrSlt7z3z4=; b=GyBMuyKPFufeinK/NCY3tt+fKSXbCQT2NWNersCYNy1PmSRHURvN+V9tLbuk51L/4H BwdDeqB0sxFhbChl6iQ5d8jSLQCWzQY07885ePdotmxvAB6jXmqLHDUBaf1E4/oAutvn 4PK4gj9mpE2ygFAMMKqaK8sJ4oNJ9IHZpsBLL41VCYrGCDwYCb5mOWLo1nzTufcILxt3 PzQRh21QhEn5viQwE3S/tztnaR/vdhi9ImYlGGQBO9pHbReakzErGkC8PAp0X0SSjoX6 VklxlTP0EEUGgYpR04lJ9PxNrNj8glh79PdlmMzQLRVb6lM1BIOAMULivWyM6nB4SdRx sTUA== X-Gm-Message-State: AAQBX9el6WU/4C/t6xEkbx4asjBoqzIzOaDNw7C4YS/+KxtbUMO5FAsB q+tEWWiF/iJWLEPrMADQwcQ= X-Google-Smtp-Source: AKy350bVOXeBaAJ4fnHSYKNM5U18nI3auHL5CNTy3KyZN5eIxFKc2kX5h+finBW15PFl8Bj5lT7tuA== X-Received: by 2002:a05:6402:5202:b0:504:b68e:9676 with SMTP id s2-20020a056402520200b00504b68e9676mr10930685edd.2.1682291687923; Sun, 23 Apr 2023 16:14:47 -0700 (PDT) Received: from [192.168.0.105] (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id n20-20020aa7d054000000b004fc01b0aa55sm4178723edo.4.2023.04.23.16.14.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Apr 2023 16:14:47 -0700 (PDT) Message-ID: <33083972-9a37-adf3-0a1c-39de72e79e3d@gmail.com> Date: Mon, 24 Apr 2023 01:14:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 3/4] staging: rtl8192e: Remove unused _rtl92e_wx_set_sens function To: Yogesh Hegde , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <5220fec656830820f0dfd116edddbd0941a5cafa.1682257566.git.yogi.kernel@gmail.com> Content-Language: en-US From: Philipp Hortmann In-Reply-To: <5220fec656830820f0dfd116edddbd0941a5cafa.1682257566.git.yogi.kernel@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/23/23 16:22, Yogesh Hegde wrote: > After removal of rf_set_sens variable, the _rtl92e_wx_set_sens function > always returns an error code. > This commit removes the unused function and the respective ioctl. > > Suggested-by: Philipp Hortmann > Signed-off-by: Yogesh Hegde > --- > > Changes in v4: > 1. Split changes into patch series per feedback from > gregkh@linuxfoundation.org > > Changes in v3: > -- None > > Changes in v2: > -- None > > Changes in v1: > -- None > --- > drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 20 -------------------- > 1 file changed, 20 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c > index e4a726cd0b31..0bb657fda06c 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c > +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c > @@ -803,25 +803,6 @@ static int _rtl92e_wx_get_retry(struct net_device *dev, > return 0; > } > > -static int _rtl92e_wx_set_sens(struct net_device *dev, > - struct iw_request_info *info, > - union iwreq_data *wrqu, char *extra) > -{ > - struct r8192_priv *priv = rtllib_priv(dev); > - > - short err = 0; > - > - if (priv->hw_radio_off) > - return 0; > - > - mutex_lock(&priv->wx_mutex); > - err = -1; > -exit: > - mutex_unlock(&priv->wx_mutex); > - > - return err; > -} > - > static int _rtl92e_wx_set_encode_ext(struct net_device *dev, > struct iw_request_info *info, > union iwreq_data *wrqu, char *extra) > @@ -1042,7 +1023,6 @@ static iw_handler r8192_wx_handlers[] = { > [IW_IOCTL(SIOCGIWFREQ)] = _rtl92e_wx_get_freq, > [IW_IOCTL(SIOCSIWMODE)] = _rtl92e_wx_set_mode, > [IW_IOCTL(SIOCGIWMODE)] = _rtl92e_wx_get_mode, > - [IW_IOCTL(SIOCSIWSENS)] = _rtl92e_wx_set_sens, > [IW_IOCTL(SIOCGIWRANGE)] = _rtl92e_wx_get_range, > [IW_IOCTL(SIOCSIWAP)] = _rtl92e_wx_set_wap, > [IW_IOCTL(SIOCGIWAP)] = _rtl92e_wx_get_wap, I can apply the first two patches but not this one. Did you do a git pull before? Thanks for your support. Bye Philipp