From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751474AbdGQOfV (ORCPT ); Mon, 17 Jul 2017 10:35:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:50862 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751320AbdGQOfU (ORCPT ); Mon, 17 Jul 2017 10:35:20 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C87122B57 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=chao@kernel.org Subject: Re: [f2fs-dev] [PATCH v2] f2fs: avoid cpu lockup To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20170715012245.24640-1-jaegeuk@kernel.org> <20170716010422.GA51202@jaegeuk-macbookpro.roam.corp.google.com> From: Chao Yu Message-ID: <330acf45-f218-cb85-28b6-08e12c4fb888@kernel.org> Date: Mon, 17 Jul 2017 22:34:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170716010422.GA51202@jaegeuk-macbookpro.roam.corp.google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/7/16 9:04, Jaegeuk Kim wrote: > Before retrying to flush data or dentry pages, we need to release cpu in order > to prevent watchdog. > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu > --- > Change log from v1: > - timeout more specifically > > fs/f2fs/checkpoint.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > index 56bbf592e487..5b876f6d3f6b 100644 > --- a/fs/f2fs/checkpoint.c > +++ b/fs/f2fs/checkpoint.c > @@ -879,6 +879,7 @@ int sync_dirty_inodes(struct f2fs_sb_info *sbi, enum inode_type type) > struct inode *inode; > struct f2fs_inode_info *fi; > bool is_dir = (type == DIR_INODE); > + unsigned long ino = 0; > > trace_f2fs_sync_dirty_inodes_enter(sbi->sb, is_dir, > get_pages(sbi, is_dir ? > @@ -901,8 +902,17 @@ int sync_dirty_inodes(struct f2fs_sb_info *sbi, enum inode_type type) > inode = igrab(&fi->vfs_inode); > spin_unlock(&sbi->inode_lock[type]); > if (inode) { > + unsigned long cur_ino = inode->i_ino; > + > filemap_fdatawrite(inode->i_mapping); > iput(inode); > + /* We need to give cpu to another writers. */ > + if (ino == cur_ino) { We failed to flush dirty pages of inode due to encountering -EAGAIN of writepage? Thanks, > + congestion_wait(BLK_RW_ASYNC, HZ/50); > + cond_resched(); > + } else { > + ino = cur_ino; > + } > } else { > /* > * We should submit bio, since it exists several >