From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933357AbcL0Woe (ORCPT ); Tue, 27 Dec 2016 17:44:34 -0500 Received: from mail.eperm.de ([89.247.134.16]:55172 "EHLO mail.eperm.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933088AbcL0Wnr (ORCPT ); Tue, 27 Dec 2016 17:43:47 -0500 From: Stephan =?ISO-8859-1?Q?M=FCller?= To: Ted Tso Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org Subject: [PATCH 1/8] random: remove stale maybe_reseed_primary_crng Date: Tue, 27 Dec 2016 23:39:04 +0100 Message-ID: <3312945.6Q4mfWFxoU@positron.chronox.de> User-Agent: KMail/5.3.3 (Linux/4.8.14-300.fc25.x86_64; KDE/5.27.0; x86_64; ; ) In-Reply-To: <3254875.f5A5oHPdxF@positron.chronox.de> References: <3254875.f5A5oHPdxF@positron.chronox.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>From 5e84a71d4c4b3c7f015878c0907102634603d270 Mon Sep 17 00:00:00 2001 From: Stephan Mueller Date: Thu, 15 Dec 2016 12:42:33 +0100 Subject: The function maybe_reseed_primary_crng is not used anywhere and thus can be removed. Besides, it contains the check crng_init > 2 which will never become true and thus would never trigger a reseed of the ChaCha20 primary DRNG. Signed-off-by: Stephan Mueller --- drivers/char/random.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/char/random.c b/drivers/char/random.c index 1ef2640..8e5ab20 100644 --- a/drivers/char/random.c +++ b/drivers/char/random.c @@ -855,13 +855,6 @@ static void crng_reseed(struct crng_state *crng, struct entropy_store *r) spin_unlock_irqrestore(&primary_crng.lock, flags); } -static inline void maybe_reseed_primary_crng(void) -{ - if (crng_init > 2 && - time_after(jiffies, primary_crng.init_time + CRNG_RESEED_INTERVAL)) - crng_reseed(&primary_crng, &input_pool); -} - static inline void crng_wait_ready(void) { wait_event_interruptible(crng_init_wait, crng_ready()); -- 2.9.3