mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Dmitry Monakhov <dmonakhov@openvz.org>, linux-kernel@vger.kernel.org
Cc: device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH 8/8] dm: dm-target.c Convert  kmalloc + memset  to kzalloc
Date: Tue, 24 Jul 2007 05:11:39 -0400 (EDT)	[thread overview]
Message-ID: <33136714.1185268299275.JavaMail.root@mswamui-valley.atl.sa.earthlink.net> (raw)



-----Original Message-----
>From: Dmitry Monakhov <dmonakhov@openvz.org>
>Sent: Jul 24, 2007 4:59 AM
>To: linux-kernel@vger.kernel.org
>Cc: device-mapper development <dm-devel@redhat.com>
>Subject: [PATCH 8/8] dm: dm-target.c Convert  kmalloc + memset  to kzalloc
>
>Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
>---
> drivers/md/dm-target.c |    6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/md/dm-target.c b/drivers/md/dm-target.c
>index 477a041..835cf95 100644
>--- a/drivers/md/dm-target.c
>+++ b/drivers/md/dm-target.c
>@@ -88,12 +88,10 @@ void dm_put_target_type(struct target_type *t)
> 
> static struct tt_internal *alloc_target(struct target_type *t)
> {
>-	struct tt_internal *ti = kmalloc(sizeof(*ti), GFP_KERNEL);
>+	struct tt_internal *ti = kzalloc(sizeof(*ti), GFP_KERNEL);
> 
>-	if (ti) {
>-		memset(ti, 0, sizeof(*ti));
>+	if (ti)
> 		ti->tt = *t;
>-	}
> 
> 	return ti;
> }
>-- 
>1.5.2.2
>
>

would it not have made more sense to have submitted all those related,
single-change patches as one patch?

rday




             reply	other threads:[~2007-07-24  9:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-24  9:11 Robert P. J. Day [this message]
2007-07-24 10:10 ` Dmitry Monakhov
  -- strict thread matches above, loose matches on Subject: below --
2007-07-24  8:51 dm: device mapper code cleanup Dmitry Monakhov
2007-07-24  8:59 ` [PATCH 8/8] dm: dm-target.c Convert kmalloc + memset to kzalloc Dmitry Monakhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33136714.1185268299275.JavaMail.root@mswamui-valley.atl.sa.earthlink.net \
    --to=rpjday@mindspring.com \
    --cc=dm-devel@redhat.com \
    --cc=dmonakhov@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome