From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751359AbdAMIil (ORCPT ); Fri, 13 Jan 2017 03:38:41 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:35260 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751323AbdAMIii (ORCPT ); Fri, 13 Jan 2017 03:38:38 -0500 Subject: Re: [PATCH v2 06/26] lib/dma-noop: Only build dma_noop_ops for m32r and s390 To: Bart Van Assche , Doug Ledford References: <20170112190718.6728-1-bart.vanassche@sandisk.com> <20170112190718.6728-7-bart.vanassche@sandisk.com> Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Joerg Roedel , Andy Lutomirski , "Michael S . Tsirkin" , Christoph Hellwig , linux-s390 From: Christian Borntraeger Date: Fri, 13 Jan 2017 09:38:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170112190718.6728-7-bart.vanassche@sandisk.com> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17011308-0024-0000-0000-000015B09E1E X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006424; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000199; SDB=6.00807010; UDB=6.00392785; IPR=6.00584341; BA=6.00005052; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00013909; XFM=3.00000011; UTC=2017-01-13 08:38:35 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17011308-0025-0000-0000-000047E91652 Message-Id: <33170c0b-abc4-005d-d992-cc86a71f07a2@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-13_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1701130122 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/12/2017 08:06 PM, Bart Van Assche wrote: > This was suggested by Christoph Hellwig. > > Signed-off-by: Bart Van Assche > Cc: Christian Borntraeger > Cc: Joerg Roedel > Cc: Andy Lutomirski > Cc: Michael S. Tsirkin > Cc: Christoph Hellwig Should be ok for s390 (as we do have ARCH_DMA_ADDR_T_64BIT). > --- > arch/m32r/Kconfig | 1 + > arch/s390/Kconfig | 1 + > lib/Kconfig | 5 +++++ > lib/Makefile | 2 +- > 4 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/arch/m32r/Kconfig b/arch/m32r/Kconfig > index d227a6988d6b..95474460b367 100644 > --- a/arch/m32r/Kconfig > +++ b/arch/m32r/Kconfig > @@ -18,6 +18,7 @@ config M32R > select MODULES_USE_ELF_RELA > select HAVE_DEBUG_STACKOVERFLOW > select CPU_NO_EFFICIENT_FFS > + select DMA_NOOP_OPS > > config SBUS > bool > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig > index c6722112527d..38ad42358c41 100644 > --- a/arch/s390/Kconfig > +++ b/arch/s390/Kconfig > @@ -137,6 +137,7 @@ config S390 > select HAVE_DEBUG_KMEMLEAK > select HAVE_DMA_API_DEBUG > select HAVE_DMA_CONTIGUOUS > + select DMA_NOOP_OPS > select HAVE_DYNAMIC_FTRACE > select HAVE_DYNAMIC_FTRACE_WITH_REGS > select HAVE_EFFICIENT_UNALIGNED_ACCESS > diff --git a/lib/Kconfig b/lib/Kconfig > index 260a80e313b9..b6baf0609e8b 100644 > --- a/lib/Kconfig > +++ b/lib/Kconfig > @@ -395,6 +395,11 @@ config HAS_DMA > depends on !NO_DMA > default y > > +config DMA_NOOP_OPS > + bool > + depends on HAS_DMA && (!64BIT || ARCH_DMA_ADDR_T_64BIT) > + default n > + > config CHECK_SIGNATURE > bool > > diff --git a/lib/Makefile b/lib/Makefile > index bc4073a8cd08..ada06d5652e8 100644 > --- a/lib/Makefile > +++ b/lib/Makefile > @@ -26,7 +26,7 @@ lib-y := ctype.o string.o vsprintf.o cmdline.o \ > > lib-$(CONFIG_MMU) += ioremap.o > lib-$(CONFIG_SMP) += cpumask.o > -lib-$(CONFIG_HAS_DMA) += dma-noop.o > +lib-$(CONFIG_DMA_NOOP_OPS) += dma-noop.o > > lib-y += kobject.o klist.o > obj-y += lockref.o >