mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Randy.Dunlap" <rddunlap@osdl.org>
To: <roland@topspin.com>
Cc: <linux-kernel@vger.kernel.org>, <kai.germaschewski@gmx.de>,
	<rusty@rustcorp.com.au>
Subject: Re: [PATCH] eliminate gcc warnings on assert [__builtin_expect]
Date: Fri, 22 Aug 2003 22:47:49 -0700 (PDT)	[thread overview]
Message-ID: <33171.4.4.25.4.1061617669.squirrel@www.osdl.org> (raw)
In-Reply-To: <5265kp0wzz.fsf@topspin.com>

>>>>>> "Randy" == Randy Dunlap <Randy.Dunlap> writes:
>
>     Randy> Building genksyms on ia64 (gcc 3.3.1) produces these
>     Randy> warnings:
>
>         [...]
>
>     Randy> Is there a problem with coercing the pointer parameter to Randy>
> be (int)?
>
> Doesn't this produce "warning: cast from pointer to integer of different
> size"? It would be better to do something like "!!__ptr" or "__ptr != 0" to
> test if the pointer is NULL.  (This was discussed to death recently on LKML)

Argh, you are right (on both counts).

I'll try that.

Thanks.

~Randy




      reply	other threads:[~2003-08-23  5:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-23  5:05 Randy.Dunlap
2003-08-23  5:21 ` Roland Dreier
2003-08-23  5:47   ` Randy.Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33171.4.4.25.4.1061617669.squirrel@www.osdl.org \
    --to=rddunlap@osdl.org \
    --cc=kai.germaschewski@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@topspin.com \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®