mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Alexey Klimov <alexey.klimov@linaro.org>,
	broonie@kernel.org, konradybcio@kernel.org,
	konrad.dybcio@oss.qualcomm.com, andersson@kernel.org,
	srinivas.kandagatla@linaro.org
Cc: tiwai@suse.com, lgirdwood@gmail.com, perex@perex.cz,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	dmitry.baryshkov@linaro.org, linux-sound@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 10/10] ASoC: qcom: sm8250: force single channel via RX_1 output
Date: Mon, 4 Nov 2024 12:19:02 +0100	[thread overview]
Message-ID: <33174321-d81d-472a-b267-ed2cdd691b74@oss.qualcomm.com> (raw)
In-Reply-To: <20241101053154.497550-11-alexey.klimov@linaro.org>

On 1.11.2024 6:31 AM, Alexey Klimov wrote:
> In case of mono configurations we need to enforce single channel
> output. This is required for audio playback on QRB4210 RB2 board.
> 
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
> ---
>  sound/soc/qcom/sm8250.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/sound/soc/qcom/sm8250.c b/sound/soc/qcom/sm8250.c
> index 45e0c33fc3f3..7994488d7998 100644
> --- a/sound/soc/qcom/sm8250.c
> +++ b/sound/soc/qcom/sm8250.c
> @@ -39,10 +39,20 @@ static int sm8250_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
>  					SNDRV_PCM_HW_PARAM_RATE);
>  	struct snd_interval *channels = hw_param_interval(params,
>  					SNDRV_PCM_HW_PARAM_CHANNELS);
> +	struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
>  
>  	rate->min = rate->max = 48000;
>  	channels->min = channels->max = 2;
>  
> +	/* Maybe should be moved to driver data variant */
> +	switch (cpu_dai->id) {
> +	case RX_CODEC_DMA_RX_1:
> +		channels->min = channels->max = 1;
> +		break;

This doesn't seem to be specific to either 8250 or 6115. It looks like
this is board specific.

Konrad

      reply	other threads:[~2024-11-04 11:19 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-01  5:31 [PATCH v1 00/10] qrb4210-rb2: add wsa/wcd audio playback support Alexey Klimov
2024-11-01  5:31 ` [PATCH v1 01/10] arm64: dts: qcom: sm6115: add LPASS devices Alexey Klimov
2024-11-01  5:31 ` [PATCH v1 02/10] arm64: dts: qcom: sm4250: add description of soundwire pins Alexey Klimov
2024-11-01  5:31 ` [PATCH v1 03/10] arm64: dts: qcom: qrb4210-rb2: add wcd937x codec support Alexey Klimov
2024-11-01  7:59   ` Krzysztof Kozlowski
2024-12-11 20:37     ` Alexey Klimov
2024-11-01  5:31 ` [PATCH v1 04/10] ASoC: codecs: wsa881x: split into common and soundwire drivers Alexey Klimov
2024-11-01  5:31 ` [PATCH v1 05/10] dt-bindings: arm: qcom-soc: extend pattern matching for QRB4210/QRB2210 SoCs Alexey Klimov
2024-11-01  7:54   ` Krzysztof Kozlowski
2024-12-11 20:12     ` Alexey Klimov
2024-11-01  5:31 ` [PATCH v1 06/10] ASoC: dt-bindings: add wsa881x-i2c binding for analog mode Alexey Klimov
2024-11-01  7:57   ` Krzysztof Kozlowski
2024-11-01  8:00     ` Krzysztof Kozlowski
2024-12-11 20:35     ` Alexey Klimov
2024-12-12  7:23       ` Krzysztof Kozlowski
2024-11-01  5:31 ` [PATCH v1 07/10] ASoC: codecs: add wsa881x-i2c amplifier codec driver Alexey Klimov
2024-11-01  8:12   ` Krzysztof Kozlowski
2024-11-01 13:12     ` Mark Brown
2024-11-01 13:53       ` Krzysztof Kozlowski
2024-11-01 14:03         ` Mark Brown
2024-12-11 21:17     ` Alexey Klimov
2024-11-01 12:02   ` Rob Herring
2024-11-01  5:31 ` [PATCH v1 08/10] arm64: dts: qcom: qrb4210-rb2: enable wsa881x amplifier Alexey Klimov
2024-11-01  8:14   ` Krzysztof Kozlowski
2024-12-12  0:46     ` Alexey Klimov
2024-11-02  9:30   ` Konrad Dybcio
2024-12-11 23:18     ` Alexey Klimov
2024-11-01  5:31 ` [PATCH v1 09/10] arm64: dts: qcom: qrb4210-rb2: add WSA audio playback support Alexey Klimov
2024-11-01  5:31 ` [PATCH v1 10/10] ASoC: qcom: sm8250: force single channel via RX_1 output Alexey Klimov
2024-11-04 11:19   ` Konrad Dybcio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33174321-d81d-472a-b267-ed2cdd691b74@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=alexey.klimov@linaro.org \
    --cc=andersson@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®