mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Harry Yoo <harry.yoo@oracle.com>
Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org,
	andreyknvl@gmail.com, aneesh.kumar@linux.ibm.com,
	anshuman.khandual@arm.com, apopple@nvidia.com, ardb@kernel.org,
	arnd@arndb.de, bp@alien8.de, cl@gentwo.org,
	dave.hansen@linux.intel.com, david@redhat.com, dennis@kernel.org,
	dev.jain@arm.com, dvyukov@google.com, glider@google.com,
	gwan-gyeong.mun@intel.com, hpa@zyccr.com, jane.chu@oracle.com,
	jgross@suse.de, jhubbard@nvidia.com, joao.m.martins@oracle.com,
	joro@8bytes.org, kas@kernel.org, kevin.brodsky@arm.com,
	linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, luto@kernel.org, maobibo@loongson.cn,
	mhocko@suse.com, mingo@redhat.com, osalvador@suse.de,
	peterx@redhat.com, peterz@infradead.org, rppt@kernel.org,
	ryabinin.a.a@gmail.com, ryan.roberts@arm.com,
	stable@vger.kernel.org, surenb@google.com, tglx@linutronix.de,
	thuth@redhat.com, tj@kernel.org, urezki@gmail.com,
	vbabka@suse.cz, vincenzo.frascino@arm.com, x86@kernel.org,
	zhengqi.arch@bytedance.com
Subject: Re: [PATCH] mm: fix KASAN build error due to p*d_populate_kernel()
Date: Thu, 21 Aug 2025 12:46:14 +0100	[thread overview]
Message-ID: <331840cc-c045-4652-b1e9-24253bb994a5@lucifer.local> (raw)
In-Reply-To: <aKb3_jilvwq_gOkf@hyeyoo>

On Thu, Aug 21, 2025 at 07:42:06PM +0900, Harry Yoo wrote:
> > > Signed-off-by: Harry Yoo <harry.yoo@oracle.com>
> >
> > This looks good, other than the nit below re: a comment, I think when we
> > are doing this kind of thing it's necessary to spell out plainly why
> > exactly we're doing it because it's not obvious at first glance.
>
> Good point, will do:
>
> /*
>  * {pgd,p4d}_populate_kernel() are defined as macros to allow
>  * compile-time optimization based on the configured page table levels.
>  * Without this, linking may fail because callers (e.g., KASAN) may rely
>  * on calls to these functions being optimized away when passing symbols
>  * that exist only for certain page table levels.
>  */

Thanks LGTM!

  reply	other threads:[~2025-08-21 11:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18  2:02 [PATCH V5 mm-hotfixes 0/3] mm, x86: fix crash due to missing page table sync and make it harder to miss Harry Yoo
2025-08-18  2:02 ` [PATCH V5 mm-hotfixes 1/3] mm: move page table sync declarations to linux/pgtable.h Harry Yoo
2025-08-18  7:47   ` David Hildenbrand
2025-08-18  2:02 ` [PATCH V5 mm-hotfixes 2/3] mm: introduce and use {pgd,p4d}_populate_kernel() Harry Yoo
2025-08-18  7:48   ` David Hildenbrand
2025-08-21  9:35   ` [PATCH] mm: fix KASAN build error due to p*d_populate_kernel() Harry Yoo
2025-08-21 10:10     ` Lorenzo Stoakes
2025-08-21 10:42       ` Harry Yoo
2025-08-21 11:46         ` Lorenzo Stoakes [this message]
2025-08-21 11:57     ` [PATCH v2] " Harry Yoo
2025-08-21 17:36       ` Dave Hansen
2025-08-22  1:11         ` Harry Yoo
2025-08-22 16:02           ` Andrey Ryabinin
2025-08-27  6:30             ` Harry Yoo
2025-08-22 17:08           ` Dave Hansen
2025-08-25  9:46             ` Andrey Ryabinin
2025-08-22  2:07   ` [PATCH v3] " Harry Yoo
2025-08-18  2:02 ` [PATCH V5 mm-hotfixes 3/3] x86/mm/64: define ARCH_PAGE_TABLE_SYNC_MASK and arch_sync_kernel_mappings() Harry Yoo
2025-08-18  7:49   ` David Hildenbrand
2025-08-18  7:50 ` [PATCH V5 mm-hotfixes 0/3] mm, x86: fix crash due to missing page table sync and make it harder to miss David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=331840cc-c045-4652-b1e9-24253bb994a5@lucifer.local \
    --to=lorenzo.stoakes@oracle.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@gmail.com \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=anshuman.khandual@arm.com \
    --cc=apopple@nvidia.com \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=bp@alien8.de \
    --cc=cl@gentwo.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=david@redhat.com \
    --cc=dennis@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=gwan-gyeong.mun@intel.com \
    --cc=harry.yoo@oracle.com \
    --cc=hpa@zyccr.com \
    --cc=jane.chu@oracle.com \
    --cc=jgross@suse.de \
    --cc=jhubbard@nvidia.com \
    --cc=joao.m.martins@oracle.com \
    --cc=joro@8bytes.org \
    --cc=kas@kernel.org \
    --cc=kevin.brodsky@arm.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@kernel.org \
    --cc=maobibo@loongson.cn \
    --cc=mhocko@suse.com \
    --cc=mingo@redhat.com \
    --cc=osalvador@suse.de \
    --cc=peterx@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rppt@kernel.org \
    --cc=ryabinin.a.a@gmail.com \
    --cc=ryan.roberts@arm.com \
    --cc=stable@vger.kernel.org \
    --cc=surenb@google.com \
    --cc=tglx@linutronix.de \
    --cc=thuth@redhat.com \
    --cc=tj@kernel.org \
    --cc=urezki@gmail.com \
    --cc=vbabka@suse.cz \
    --cc=vincenzo.frascino@arm.com \
    --cc=x86@kernel.org \
    --cc=zhengqi.arch@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®