From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751849Ab3ARLM6 (ORCPT ); Fri, 18 Jan 2013 06:12:58 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:59128 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751622Ab3ARLM5 convert rfc822-to-8bit (ORCPT ); Fri, 18 Jan 2013 06:12:57 -0500 From: "AnilKumar, Chimata" To: "sameo@linux.intel.com" CC: "Porter, Matt" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] mfd: tps65910: Select REGMAP_IRQ in Kconfig to fix build error Thread-Topic: [PATCH] mfd: tps65910: Select REGMAP_IRQ in Kconfig to fix build error Thread-Index: AQHN1seiI6fLegAXTkGaMUde0EWBo5g18YqQgAsYJYCADiHcsA== Date: Fri, 18 Jan 2013 11:12:53 +0000 Message-ID: <331ABD5ECB02734CA317220B2BBEABC13EAF03B5@DBDE01.ent.ti.com> References: <1355138096-7702-1-git-send-email-anilkumar@ti.com> <331ABD5ECB02734CA317220B2BBEABC13EAD58CF@DBDE01.ent.ti.com> <20130109165235.GJ14660@beef> In-Reply-To: <20130109165235.GJ14660@beef> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.24.170.142] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 09, 2013 at 22:22:35, Porter, Matt wrote: > On Wed, Jan 02, 2013 at 10:15:39AM +0000, AnilKumar wrote: > > On Mon, Dec 10, 2012 at 16:44:56, AnilKumar, Chimata wrote: > > > TPS65910 mfd driver uses functions that are only avaiable when > > > REGMAP_IRQ is enabled. So "select REGMAP_IRQ" is added to mfd > > > Kconfig to fix below build error: > > > > > > drivers/built-in.o: In function `tps65910_irq_exit': > > > /media/anil/kernel/drivers/mfd/tps65910.c:265: undefined reference to `regmap_del_irq_chip' > > > drivers/built-in.o: In function `tps65910_irq_init': > > > /media/anil/kernel/drivers/mfd/tps65910.c:254: undefined reference to `regmap_add_irq_chip' > > > drivers/built-in.o: In function `tps65910_i2c_probe': > > > /media/anil/kernel/drivers/mfd/tps65910.c:509: undefined reference to `regmap_irq_get_domain' > > > make: *** [vmlinux] Error 1 > > > > > > Signed-off-by: AnilKumar Ch > > > --- > > > drivers/mfd/Kconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > > index 1c0abd4..01413a2 100644 > > > --- a/drivers/mfd/Kconfig > > > +++ b/drivers/mfd/Kconfig > > > @@ -237,6 +237,7 @@ config MFD_TPS65910 > > > depends on I2C=y && GPIOLIB > > > select MFD_CORE > > > select REGMAP_I2C > > > + select REGMAP_IRQ > > > select IRQ_DOMAIN > > > help > > > if you say yes here you get support for the TPS65910 series of > > > > Hi Samuel, > > > > Could you please pull this fix? > > Tested-by: Matt Porter > > Fixes broken OMAP kernel build here too. > Hi Samuel, Could you please take this in? Thanks AnilKumar