From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751863AbdFMHha (ORCPT ); Tue, 13 Jun 2017 03:37:30 -0400 Received: from foss.arm.com ([217.140.101.70]:43896 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751758AbdFMHh3 (ORCPT ); Tue, 13 Jun 2017 03:37:29 -0400 Subject: Re: [PATCH 1/2] arm: nommu: remove unused KTHREAD_SIZE definition To: =?UTF-8?Q?J=c3=a9r=c3=a9my_Lefaure?= , Russell King References: <20170612170937.2969-1-jeremy.lefaure@lse.epita.fr> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Vladimir Murzin Message-ID: <331b6524-acd6-37ec-df72-9b8b2f3eec97@arm.com> Date: Tue, 13 Jun 2017 08:37:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170612170937.2969-1-jeremy.lefaure@lse.epita.fr> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/06/17 18:09, Jérémy Lefaure wrote: > I didn't find any use of this macro in the current kernel tree (with git > grep). KTHREAD_SIZE is no longer used for a very very long time. So > let's remove this definition. > > Signed-off-by: Jérémy Lefaure > --- > arch/arm/include/asm/page-nommu.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/arch/arm/include/asm/page-nommu.h b/arch/arm/include/asm/page-nommu.h > index 503f488053de..8f2c47bec375 100644 > --- a/arch/arm/include/asm/page-nommu.h > +++ b/arch/arm/include/asm/page-nommu.h > @@ -11,12 +11,6 @@ > #ifndef _ASMARM_PAGE_NOMMU_H > #define _ASMARM_PAGE_NOMMU_H > > -#if !defined(CONFIG_SMALL_TASKS) && PAGE_SHIFT < 13 > -#define KTHREAD_SIZE (8192) > -#else > -#define KTHREAD_SIZE PAGE_SIZE > -#endif > - > #define clear_page(page) memset((page), 0, PAGE_SIZE) > #define copy_page(to,from) memcpy((to), (from), PAGE_SIZE) > > Even more, CONFIG_SMALL_TASKS has gone and only page size we support is 4K. It looks like that similar patch has been submitted several times by different people but never got merged, so if it helps: Reviewed-by: Vladimir Murzin Cheers Vladimir