From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760221AbcIWOU6 (ORCPT ); Fri, 23 Sep 2016 10:20:58 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:54115 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754016AbcIWOU4 (ORCPT ); Fri, 23 Sep 2016 10:20:56 -0400 Subject: Re: [PATCH] usb: gadget: udc: atmel: fix endpoint name To: Felipe Balbi , Greg Kroah-Hartman References: <20160915150722.13103-1-alexandre.belloni@free-electrons.com> CC: Alexandre Belloni , Richard Genoud , , , From: Nicolas Ferre Organization: atmel Message-ID: <331f5819-1f65-980d-486d-732342877f2c@atmel.com> Date: Fri, 23 Sep 2016 16:20:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.145.133.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 16/09/2016 à 10:36, Nicolas Ferre a écrit : > Le 15/09/2016 à 17:07, Alexandre Belloni a écrit : >> Since commit c32b5bcfa3c4 ("ARM: dts: at91: Fix USB endpoint nodes"), >> atmel_usba_udc fails with: >> >> ------------[ cut here ]------------ >> WARNING: CPU: 0 PID: 0 at include/linux/usb/gadget.h:405 >> ecm_do_notify+0x188/0x1a0 >> Modules linked in: >> CPU: 0 PID: 0 Comm: swapper Not tainted 4.7.0+ #15 >> Hardware name: Atmel SAMA5 >> [] (unwind_backtrace) from [] (show_stack+0x10/0x14) >> [] (show_stack) from [] (__warn+0xe4/0xfc) >> [] (__warn) from [] (warn_slowpath_null+0x20/0x28) >> [] (warn_slowpath_null) from [] (ecm_do_notify+0x188/0x1a0) >> [] (ecm_do_notify) from [] (ecm_set_alt+0x74/0x1ac) >> [] (ecm_set_alt) from [] (composite_setup+0xfc0/0x19f8) >> [] (composite_setup) from [] (usba_udc_irq+0x8f4/0xd9c) >> [] (usba_udc_irq) from [] (handle_irq_event_percpu+0x9c/0x158) >> [] (handle_irq_event_percpu) from [] (handle_irq_event+0x28/0x3c) >> [] (handle_irq_event) from [] (handle_fasteoi_irq+0xa0/0x168) >> [] (handle_fasteoi_irq) from [] (generic_handle_irq+0x24/0x34) >> [] (generic_handle_irq) from [] (__handle_domain_irq+0x54/0xa8) >> [] (__handle_domain_irq) from [] (__irq_svc+0x54/0x70) >> [] (__irq_svc) from [] (arch_cpu_idle+0x38/0x3c) >> [] (arch_cpu_idle) from [] (cpu_startup_entry+0x9c/0xdc) >> [] (cpu_startup_entry) from [] (start_kernel+0x354/0x360) >> [] (start_kernel) from [<20008078>] (0x20008078) >> ---[ end trace e7cf9dcebf4815a6 ]--- >> >> Fixes: c32b5bcfa3c4 ("ARM: dts: at91: Fix USB endpoint nodes") >> Reported-by: Richard Genoud >> Signed-off-by: Alexandre Belloni > > Acked-by: Nicolas Ferre > > Felipe, Greg, > It is clearly a regression and material for 4.8-fixes. But I do know > that we are very late in the process :-( > Please do what you can to make it progress before 4.8-final but I'm > truly aware of the challenge. Any chance that we can have it (aka ping)? Bye, > Thanks to Richard for finding this and Alexandre for the quick correction. > > Bye, > >> --- >> drivers/usb/gadget/udc/atmel_usba_udc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c >> index bb1f6c8f0f01..45bc997d0711 100644 >> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c >> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c >> @@ -1978,7 +1978,7 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev, >> dev_err(&pdev->dev, "of_probe: name error(%d)\n", ret); >> goto err; >> } >> - ep->ep.name = name; >> + ep->ep.name = kasprintf(GFP_KERNEL, "ep%d", ep->index); >> >> ep->ep_regs = udc->regs + USBA_EPT_BASE(i); >> ep->dma_regs = udc->regs + USBA_DMA_BASE(i); >> > > -- Nicolas Ferre