From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, Peter Geis <pgwipeout@gmail.com>
Subject: Re: [PATCH v1 00/11] Clean up Tegra20 cpufreq driver
Date: Fri, 18 May 2018 09:30:19 +0200 [thread overview]
Message-ID: <33210093.0R9M0pnSOk@aspire.rjw.lan> (raw)
In-Reply-To: <20180517180056.13336-1-digetx@gmail.com>
On Thursday, May 17, 2018 8:00:45 PM CEST Dmitry Osipenko wrote:
> Hello,
>
> Recently Peter Geis (who is working on Tegra30 cpufreq driver) asked me how
> tegra20-cpufreq driver is getting loaded. After taking a look at the code
> it became apparent that the drivers code has been rusted a tad and so this
> series is intended to refresh the drivers code by disallowing module to be
> loaded on non-Tegra20 machines, by cleaning whitespaces in the code, removing
> dead EMC code and in the end by allowing tegra20-cpufreq to be built as a
> loadable module.
>
> Please review, thanks.
>
> Dmitry Osipenko (11):
> cpufreq: tegra20: Change module description
> cpufreq: tegra20: Clean up whitespaces in the code
> cpufreq: tegra20: Remove EMC clock usage
> cpufreq: tegra20: Release clocks properly
> cpufreq: tegra20: Clean up included headers
> cpufreq: tegra20: Remove unneeded check in tegra_cpu_init
> cpufreq: tegra20: Check if this is Tegra20 machine
> cpufreq: tegra20: Remove unneeded variable initialization
> cpufreq: tegra20: Allow cpufreq driver to be built as loadable module
> cpufreq: tegra20: Wrap cpufreq into platform driver
> ARM: tegra: Create platform device for tegra20-cpufreq driver
>
> arch/arm/mach-tegra/tegra.c | 4 +
> drivers/cpufreq/Kconfig.arm | 2 +-
> drivers/cpufreq/tegra20-cpufreq.c | 172 +++++++++++++++++-------------
> 3 files changed, 101 insertions(+), 77 deletions(-)
>
>
It looks like Viresh has ACKed the majority of the patches in this series,
but there are a few where he had comments.
Please fix up these and resend the entire series with the Acked-by tags from
Viresh added where applicable.
Thanks,
Rafael
next prev parent reply other threads:[~2018-05-18 7:30 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 18:00 Dmitry Osipenko
2018-05-17 18:00 ` [PATCH v1 01/11] cpufreq: tegra20: Change module description Dmitry Osipenko
2018-05-18 1:53 ` Viresh Kumar
2018-05-18 8:34 ` Thierry Reding
2018-05-17 18:00 ` [PATCH v1 02/11] cpufreq: tegra20: Clean up whitespaces in the code Dmitry Osipenko
2018-05-18 1:54 ` Viresh Kumar
2018-05-18 8:34 ` Thierry Reding
2018-05-17 18:00 ` [PATCH v1 03/11] cpufreq: tegra20: Remove EMC clock usage Dmitry Osipenko
2018-05-18 1:54 ` Viresh Kumar
2018-05-18 8:36 ` Thierry Reding
2018-05-17 18:00 ` [PATCH v1 04/11] cpufreq: tegra20: Release clocks properly Dmitry Osipenko
2018-05-18 1:55 ` Viresh Kumar
2018-05-18 8:37 ` Thierry Reding
2018-05-17 18:00 ` [PATCH v1 05/11] cpufreq: tegra20: Clean up included headers Dmitry Osipenko
2018-05-18 1:58 ` Viresh Kumar
2018-05-18 8:05 ` Dmitry Osipenko
2018-05-18 8:57 ` Thierry Reding
2018-05-17 18:00 ` [PATCH v1 06/11] cpufreq: tegra20: Remove unneeded check in tegra_cpu_init Dmitry Osipenko
2018-05-18 1:59 ` Viresh Kumar
2018-05-18 8:57 ` Thierry Reding
2018-05-17 18:00 ` [PATCH v1 07/11] cpufreq: tegra20: Check if this is Tegra20 machine Dmitry Osipenko
2018-05-18 1:59 ` Viresh Kumar
2018-05-18 8:58 ` Thierry Reding
2018-05-17 18:00 ` [PATCH v1 08/11] cpufreq: tegra20: Remove unneeded variable initialization Dmitry Osipenko
2018-05-18 2:00 ` Viresh Kumar
2018-05-18 8:58 ` Thierry Reding
2018-05-17 18:00 ` [PATCH v1 09/11] cpufreq: tegra20: Allow cpufreq driver to be built as loadable module Dmitry Osipenko
2018-05-18 2:00 ` Viresh Kumar
2018-05-18 9:00 ` Thierry Reding
2018-05-17 18:00 ` [PATCH v1 10/11] cpufreq: tegra20: Wrap cpufreq into platform driver Dmitry Osipenko
2018-05-18 2:07 ` Viresh Kumar
2018-05-18 8:09 ` Dmitry Osipenko
2018-05-18 9:04 ` Viresh Kumar
2018-05-18 9:07 ` Thierry Reding
2018-05-18 9:19 ` Dmitry Osipenko
2018-05-17 18:00 ` [PATCH v1 11/11] ARM: tegra: Create platform device for tegra20-cpufreq driver Dmitry Osipenko
2018-05-18 2:07 ` Viresh Kumar
2018-05-18 9:13 ` Thierry Reding
2018-05-18 9:30 ` Dmitry Osipenko
2018-05-18 7:30 ` Rafael J. Wysocki [this message]
2018-05-18 8:18 ` [PATCH v1 00/11] Clean up Tegra20 cpufreq driver Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33210093.0R9M0pnSOk@aspire.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pgwipeout@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®