From: Xin Li <xin@zytor.com>
To: Sohil Mehta <sohil.mehta@intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Cc: "H . Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Sean Christopherson <seanjc@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Tony Luck <tony.luck@intel.com>, Zhang Rui <rui.zhang@intel.com>,
Steven Rostedt <rostedt@goodmis.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Jacob Pan <jacob.pan@linux.microsoft.com>,
Andi Kleen <ak@linux.intel.com>, Kai Huang <kai.huang@intel.com>,
Sandipan Das <sandipan.das@amd.com>,
linux-perf-users@vger.kernel.org, linux-edac@vger.kernel.org,
kvm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v6 9/9] x86/nmi: Print source information with the unknown NMI console message
Date: Tue, 3 Jun 2025 19:41:13 -0700 [thread overview]
Message-ID: <33237e7f-ef8b-458f-b0a6-2538d8961898@zytor.com> (raw)
In-Reply-To: <fa948d41-3f95-4385-86c1-5c115561b939@intel.com>
On 6/3/2025 6:55 PM, Sohil Mehta wrote:
> On 6/3/2025 9:55 AM, Xin Li wrote:
>> On 5/13/2025 1:38 PM, Sohil Mehta wrote:
>>> + if (cpu_feature_enabled(X86_FEATURE_NMI_SOURCE))
>>> + pr_emerg_ratelimited("NMI-source bitmap is 0x%lx\n", fred_event_data(regs));
>>
>> "0x%04lx"?
>
> Yeah, this would be better. But, it might not matter now.
>
> Based on the discussion in the other patch, I am considering printing
> the source names rather than the raw bitmap.
Yep, I saw that :)
next prev parent reply other threads:[~2025-06-04 2:42 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 20:37 [PATCH v6 0/9] x86: Add support for NMI-source reporting with FRED Sohil Mehta
2025-05-13 20:37 ` [PATCH v6 1/9] x86/fred, KVM: VMX: Pass event data to the FRED entry point from KVM Sohil Mehta
2025-05-14 14:15 ` Sean Christopherson
2025-05-14 21:34 ` Sohil Mehta
2025-05-16 1:15 ` Sean Christopherson
2025-06-02 20:45 ` Sohil Mehta
2025-05-13 20:37 ` [PATCH v6 2/9] x86/cpufeatures: Add the CPUID feature bit for NMI-source reporting Sohil Mehta
2025-05-13 20:37 ` [PATCH v6 3/9] x86/nmi: Extend the registration interface to include the NMI-source vector Sohil Mehta
2025-06-03 7:23 ` Xin Li
2025-06-03 17:35 ` Sohil Mehta
2025-06-03 17:07 ` Dave Hansen
2025-06-03 18:02 ` Sohil Mehta
2025-06-03 18:19 ` Dave Hansen
2025-06-03 20:24 ` Sohil Mehta
2025-05-13 20:37 ` [PATCH v6 4/9] x86/nmi: Assign and register NMI-source vectors Sohil Mehta
2025-06-03 16:34 ` Xin Li
2025-06-03 21:45 ` Sohil Mehta
2025-06-04 15:28 ` H. Peter Anvin
2025-06-11 21:34 ` Sohil Mehta
2025-06-03 17:23 ` Dave Hansen
2025-06-03 20:22 ` Sohil Mehta
2025-06-03 21:54 ` Dave Hansen
2025-06-03 22:33 ` Sohil Mehta
2025-06-04 15:22 ` H. Peter Anvin
2025-05-13 20:37 ` [PATCH v6 5/9] x86/nmi: Add support to handle NMIs with source information Sohil Mehta
2025-06-03 16:53 ` Xin Li
2025-05-13 20:38 ` [PATCH v6 6/9] x86/nmi: Prepare for the new NMI-source vector encoding Sohil Mehta
2025-05-13 20:38 ` [PATCH v6 7/9] x86/nmi: Enable NMI-source for IPIs delivered as NMIs Sohil Mehta
2025-05-13 20:38 ` [PATCH v6 8/9] perf/x86: Enable NMI-source reporting for perfmon Sohil Mehta
2025-06-03 16:57 ` Xin Li
2025-05-13 20:38 ` [PATCH v6 9/9] x86/nmi: Print source information with the unknown NMI console message Sohil Mehta
2025-06-03 16:55 ` Xin Li
2025-06-04 1:55 ` Sohil Mehta
2025-06-04 2:41 ` Xin Li [this message]
2025-06-04 15:41 ` H. Peter Anvin
2025-06-11 21:39 ` Sohil Mehta
2025-06-04 15:29 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33237e7f-ef8b-458f-b0a6-2538d8961898@zytor.com \
--to=xin@zytor.com \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jacob.pan@linux.microsoft.com \
--cc=kai.huang@intel.com \
--cc=kan.liang@linux.intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=rui.zhang@intel.com \
--cc=sandipan.das@amd.com \
--cc=seanjc@google.com \
--cc=sohil.mehta@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®