From: "H. Peter Anvin" <hpa@zytor.com>
To: Dave Hansen <dave.hansen@intel.com>,
Jinchao Wang <wangjinchao600@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Masami Hiramatsu <mhiramat@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86/hw_breakpoint: Unify breakpoint install/uninstall
Date: Wed, 10 Sep 2025 07:56:44 -0700 [thread overview]
Message-ID: <332DA932-2A5A-48B1-AEF6-84D4CCDB7BA1@zytor.com> (raw)
In-Reply-To: <cae9c81e-84ac-4da4-abb5-9ff9e20c6d3d@intel.com>
On September 10, 2025 7:47:06 AM PDT, Dave Hansen <dave.hansen@intel.com> wrote:
>On 9/10/25 02:39, Jinchao Wang wrote:
>> Consolidate breakpoint management into a single helper function to
>> reduce code duplication. This introduces new static helpers for
>> slot management and debug register manipulation.
>>
>> Also, add `<linux/types.h>` to the header file to fix a build
>> dependency.
>>
>> Signed-off-by: Jinchao Wang <wangjinchao600@gmail.com>
>> ---
>> arch/x86/include/asm/hw_breakpoint.h | 7 +-
>> arch/x86/kernel/hw_breakpoint.c | 151 ++++++++++++++++-----------
>> 2 files changed, 96 insertions(+), 62 deletions(-)
>
>That diffstat doesn't look like it's reducing code duplication.
He does add a *lot* of comments.
next prev parent reply other threads:[~2025-09-10 14:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 9:39 Jinchao Wang
2025-09-10 9:39 ` [PATCH 2/2] x86/hw_breakpoint: Add arch_reinstall_hw_breakpoint Jinchao Wang
2025-09-11 10:16 ` Masami Hiramatsu
2025-09-10 14:47 ` [PATCH 1/2] x86/hw_breakpoint: Unify breakpoint install/uninstall Dave Hansen
2025-09-10 14:56 ` H. Peter Anvin [this message]
2025-09-11 0:42 ` Jinchao Wang
2025-09-11 8:03 ` Masami Hiramatsu
2025-09-12 1:05 ` Jinchao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=332DA932-2A5A-48B1-AEF6-84D4CCDB7BA1@zytor.com \
--to=hpa@zytor.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=wangjinchao600@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®